From: Kees Cook <keescook@chromium.org>
To: Matteo Croce <mcroce@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v5] proc/sysctl: add shared variables for range check
Date: Thu, 16 May 2019 11:33:21 -0700 [thread overview]
Message-ID: <201905161132.CC4C2F3@keescook> (raw)
In-Reply-To: <CAGnkfhyjmpPAjQFpm-w3v0kMWTKRHTq5v6w0m9KScN2a7bMgeg@mail.gmail.com>
On Thu, May 16, 2019 at 06:09:53PM +0200, Matteo Croce wrote:
> On Tue, Apr 30, 2019 at 8:14 PM Kees Cook <keescook@chromium.org> wrote:
> >
> > On Tue, Apr 30, 2019 at 11:01 AM Matteo Croce <mcroce@redhat.com> wrote:
> > >
> > > In the sysctl code the proc_dointvec_minmax() function is often used to
> > > validate the user supplied value between an allowed range. This function
> > > uses the extra1 and extra2 members from struct ctl_table as minimum and
> > > maximum allowed value.
> > >
> [...]
> > >
> > > Signed-off-by: Matteo Croce <mcroce@redhat.com>
> >
> > Acked-by: Kees Cook <keescook@chromium.org>
> >
> > --
> > Kees Cook
>
> Hi all,
>
> just a ping about this patch. Any tought, suggestion, concern or criticism?
Andrew, does this look okay to pick up after -rc2 for -next?
--
Kees Cook
next prev parent reply other threads:[~2019-05-16 18:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 18:01 [PATCH v5] proc/sysctl: add shared variables for range check Matteo Croce
2019-04-30 18:14 ` Kees Cook
2019-05-16 16:09 ` Matteo Croce
2019-05-16 18:33 ` Kees Cook [this message]
2019-05-23 8:05 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201905161132.CC4C2F3@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcroce@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).