From: "Theodore Ts'o" <tytso@mit.edu>
To: Lee Jones <lee.jones@linaro.org>
Cc: Philippe Mazenauer <philippe.mazenauer@outlook.de>,
Andreas Dilger <adilger.kernel@dilger.ca>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ext4: Variable to signed to check return code
Date: Sat, 18 May 2019 15:54:24 -0400 [thread overview]
Message-ID: <20190518195424.GC14277@mit.edu> (raw)
In-Reply-To: <20190518063834.GX4319@dell>
On Sat, May 18, 2019 at 07:38:34AM +0100, Lee Jones wrote:
> "- Acked-by: indicates an agreement by another developer (often a
> maintainer of the relevant code) that the patch is appropriate for
> inclusion into the kernel."
>
> And I, as a developer (and not a Maintainer in this case) do indicate
> that this patch is appropriate for inclusion into the kernel.
>
> Reviewed-by has stronger connotations and implies I have in-depth
> knowledge of the subsystem/driver AND agree to the Reviewer's
> Statement. I use Acked-by in this case as a weaker agreement after a
> shallow review of the patch based on its merits alone.
Note the "often a maintainer of the relevant code" bit. And
"appropriate for inclusion into the kernel" means to me that you've
done the same level of review as Reviewed-by. So I have very
different understanding of how Acked-by and Reviewed-by than you do.
That being said, no offence to you, but any kind of Acked-by or
Reviewed-by from you is not going to have as much weight as say, a
Reviewed-by: from someone like Jan Kara. That's just because I don't
have a good sense to your technical ability, and so I'd be doing a
full review myself and not rely on your review at all....
Cheers,
- Ted
P.S. And if I find a problem in the patch, and someone had attached
their Acked-by or Reviewed-by to it, it would have the same negative
hit to their reputation either way. Not a big deal if it happens only
once, or it's an esepcially tricky issue, but it if happens more than
once or is really blatent, I as the maintainer definitely do remember.
next prev parent reply other threads:[~2019-05-18 19:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 9:01 [PATCH] ext4: Variable to signed to check return code Philippe Mazenauer
2019-05-17 10:25 ` Lee Jones
2019-05-17 20:28 ` Theodore Ts'o
2019-05-18 6:38 ` Lee Jones
2019-05-18 19:54 ` Theodore Ts'o [this message]
2019-05-20 8:24 ` Lee Jones
2019-05-20 15:36 ` Theodore Ts'o
2019-05-21 7:25 ` Lee Jones
2019-05-21 17:16 ` Theodore Ts'o
2019-05-22 6:59 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190518195424.GC14277@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=lee.jones@linaro.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philippe.mazenauer@outlook.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).