linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gen Zhang <blackgod016574@gmail.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty_io: Fix a missing-check bug in drivers/tty/tty_io.c
Date: Wed, 22 May 2019 19:18:28 +0800	[thread overview]
Message-ID: <20190522111828.GB5849@zhanggen-UX430UQ> (raw)
In-Reply-To: <3a3db304-9725-6a90-65ac-dff09ef31aae@suse.cz>

On Wed, May 22, 2019 at 10:15:56AM +0200, Jiri Slaby wrote:
> Look at the top of alloc_tty_struct: there is tty_ldisc_init. If
> tty_get_device fails here, you have to call tty_ldisc_deinit. Better,
> you should add a failure-handling tail to this function and "goto" there.
Thanks for your explaination, Jiri.
I will work on it.
Thanks
Gen

      parent reply	other threads:[~2019-05-22 11:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22  1:40 [PATCH] tty_io: Fix a missing-check bug in drivers/tty/tty_io.c Gen Zhang
2019-05-22  4:25 ` Jiri Slaby
2019-05-22  8:06   ` Gen Zhang
2019-05-22  8:15     ` Jiri Slaby
2019-05-22 10:29       ` Johan Hovold
2019-05-22 10:32         ` Jiri Slaby
2019-05-22 11:13         ` Gen Zhang
2019-05-22 11:19           ` Johan Hovold
2019-05-22 11:24             ` Gen Zhang
2019-05-22 11:18       ` Gen Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190522111828.GB5849@zhanggen-UX430UQ \
    --to=blackgod016574@gmail.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).