From: Roman Gushchin <guro@fb.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Kernel Team <Kernel-team@fb.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Yonghong Song <yhs@fb.com>
Subject: Re: [PATCH bpf-next] bpf: allow CGROUP_SKB programs to use bpf_skb_cgroup_id() helper
Date: Fri, 7 Jun 2019 00:09:43 +0000 [thread overview]
Message-ID: <20190607000937.GA13090@tower.DHCP.thefacebook.com> (raw)
In-Reply-To: <a9a8d1ec-f0ce-6cde-31f1-9003c6b2c64a@iogearbox.net>
On Fri, Jun 07, 2019 at 02:00:20AM +0200, Daniel Borkmann wrote:
> On 06/06/2019 10:30 PM, Roman Gushchin wrote:
> > Currently bpf_skb_cgroup_id() is not supported for CGROUP_SKB
> > programs. An attempt to load such a program generates an error
> > like this:
> >
> > libbpf:
> > 0: (b7) r6 = 0
> > ...
> > 9: (85) call bpf_skb_cgroup_id#79
> > unknown func bpf_skb_cgroup_id#79
> >
> > There are no particular reasons for denying it, and we have some
> > use cases where it might be useful.
> >
> > So let's add it to the list of allowed helpers.
> >
> > Signed-off-by: Roman Gushchin <guro@fb.com>
> > Cc: Yonghong Song <yhs@fb.com>
> > Cc: Alexei Starovoitov <ast@kernel.org>
> > Cc: Daniel Borkmann <daniel@iogearbox.net>
>
> Applied, thanks!
Thank you, Daniel!
prev parent reply other threads:[~2019-06-07 0:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 20:30 [PATCH bpf-next] bpf: allow CGROUP_SKB programs to use bpf_skb_cgroup_id() helper Roman Gushchin
2019-06-06 21:51 ` Martin Lau
2019-06-07 0:00 ` Daniel Borkmann
2019-06-07 0:09 ` Roman Gushchin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190607000937.GA13090@tower.DHCP.thefacebook.com \
--to=guro@fb.com \
--cc=Kernel-team@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).