linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Jeffrey Hugo <jhugo@codeaurora.org>
Cc: david.brown@linaro.org, agross@kernel.org,
	bjorn.andersson@linaro.org, marc.w.gonzalez@free.fr,
	mturquette@baylibre.com, robh+dt@kernel.org,
	mark.rutland@arm.com, linux-arm-msm@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v4 0/6] MSM8998 Multimedia Clock Controller
Date: Fri, 07 Jun 2019 13:38:37 -0700	[thread overview]
Message-ID: <20190607203838.1361E208C3@mail.kernel.org> (raw)
In-Reply-To: <933023a0-10fd-fedf-6715-381dae174ad9@codeaurora.org>

Quoting Jeffrey Hugo (2019-05-21 07:52:28)
> On 5/21/2019 8:44 AM, Jeffrey Hugo wrote:
> > The multimedia clock controller (mmcc) is the main clock controller for
> > the multimedia subsystem and is required to enable things like display and
> > camera.
> 
> Stephen, I think this series is good to go, and I have display/gpu stuff 
> I'm polishing that will depend on this.  Would you kindly pickup patches 
> 1, 3, 4, and 5 for 5.3?  I can work with Bjorn to pick up patches 2 and 6.
> 

If I apply patch 3 won't it break boot until patch 2 is also in the
tree? That seems to imply that I'll break bisection, and we have
kernelci boot testing clk-next so this will probably set off alarms
somewhere.

I thought we had some code that got removed that was going to make the
transition "seamless" in the sense that it would search the tree for an
RPM clk controller and then not add the XO fixed factor clk somehow.
See commit 54823af9cd52 ("clk: qcom: Always add factor clock for xo
clocks") for the code that we removed. So ideally we do something like
this too, but now we search for a property on the calling node to see if
the XO clk is there?


  reply	other threads:[~2019-06-07 20:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21 14:44 [PATCH v4 0/6] MSM8998 Multimedia Clock Controller Jeffrey Hugo
2019-05-21 14:46 ` [PATCH v4 1/6] dt-bindings: clock: Document external clocks for MSM8998 gcc Jeffrey Hugo
2019-06-06 23:29   ` Stephen Boyd
2019-05-21 14:47 ` [PATCH v4 2/6] arm64: dts: msm8998: Add xo clock to gcc node Jeffrey Hugo
2019-05-21 14:48 ` [PATCH v4 3/6] clk: qcom: smd: Add XO clock for MSM8998 Jeffrey Hugo
2019-05-21 14:48 ` [PATCH v4 4/6] dt-bindings: clock: Add support for the MSM8998 mmcc Jeffrey Hugo
2019-05-21 14:48 ` [PATCH v4 5/6] clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver Jeffrey Hugo
2019-05-21 14:49 ` [PATCH v4 6/6] arm64: dts: qcom: msm8998: Add mmcc node Jeffrey Hugo
2019-05-21 14:52 ` [PATCH v4 0/6] MSM8998 Multimedia Clock Controller Jeffrey Hugo
2019-06-07 20:38   ` Stephen Boyd [this message]
2019-06-07 21:31     ` Jeffrey Hugo
2019-06-07 23:18       ` Stephen Boyd
2019-06-11 20:14         ` Jeffrey Hugo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190607203838.1361E208C3@mail.kernel.org \
    --to=sboyd@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jhugo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.w.gonzalez@free.fr \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).