From: Saravana Kannan <saravanak@google.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Saravana Kannan <saravanak@google.com>,
kernel-team@android.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 4/4] PM / devfreq: Add required OPPs support to passive governor
Date: Tue, 25 Jun 2019 14:33:37 -0700 [thread overview]
Message-ID: <20190625213337.157525-5-saravanak@google.com> (raw)
In-Reply-To: <20190625213337.157525-1-saravanak@google.com>
Look at the required OPPs of the "parent" device to determine the OPP that
is required from the slave device managed by the passive governor. This
allows having mappings between a parent device and a slave device even when
they don't have the same number of OPPs.
Signed-off-by: Saravana Kannan <saravanak@google.com>
---
drivers/devfreq/governor_passive.c | 20 +++++++++++++++-----
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c
index 3bc29acbd54e..f6de03de7a64 100644
--- a/drivers/devfreq/governor_passive.c
+++ b/drivers/devfreq/governor_passive.c
@@ -22,7 +22,7 @@ static int devfreq_passive_get_target_freq(struct devfreq *devfreq,
= (struct devfreq_passive_data *)devfreq->data;
struct devfreq *parent_devfreq = (struct devfreq *)p_data->parent;
unsigned long child_freq = ULONG_MAX;
- struct dev_pm_opp *opp;
+ struct dev_pm_opp *opp = NULL, *p_opp = NULL;
int i, count, ret = 0;
/*
@@ -59,13 +59,20 @@ static int devfreq_passive_get_target_freq(struct devfreq *devfreq,
* list of parent device. Because in this case, *freq is temporary
* value which is decided by ondemand governor.
*/
- opp = devfreq_recommended_opp(parent_devfreq->dev.parent, freq, 0);
- if (IS_ERR(opp)) {
- ret = PTR_ERR(opp);
+ p_opp = devfreq_recommended_opp(parent_devfreq->dev.parent, freq, 0);
+ if (IS_ERR(p_opp)) {
+ ret = PTR_ERR(p_opp);
goto out;
}
- dev_pm_opp_put(opp);
+ if (devfreq->opp_table && parent_devfreq->opp_table)
+ opp = dev_pm_opp_xlate_opp(parent_devfreq->opp_table,
+ devfreq->opp_table, p_opp);
+ if (opp) {
+ *freq = dev_pm_opp_get_freq(opp);
+ dev_pm_opp_put(opp);
+ goto out;
+ }
/*
* Get the OPP table's index of decided freqeuncy by governor
@@ -92,6 +99,9 @@ static int devfreq_passive_get_target_freq(struct devfreq *devfreq,
*freq = child_freq;
out:
+ if (!IS_ERR_OR_NULL(opp))
+ dev_pm_opp_put(p_opp);
+
return ret;
}
--
2.22.0.410.gd8fdbe21b5-goog
next prev parent reply other threads:[~2019-06-25 21:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 21:33 [PATCH v2 0/4] Add required-opps support to devfreq passive gov Saravana Kannan
2019-06-25 21:33 ` [PATCH v2 1/4] OPP: Allow required-opps even if the device doesn't have power-domains Saravana Kannan
2019-07-16 15:14 ` Sibi Sankar
2019-07-16 17:17 ` Sibi Sankar
2019-07-16 18:54 ` Saravana Kannan
2019-06-25 21:33 ` [PATCH v2 2/4] OPP: Add function to look up required OPP's for a given OPP Saravana Kannan
2019-06-25 21:33 ` [PATCH v2 3/4] PM / devfreq: Cache OPP table reference in devfreq Saravana Kannan
2019-06-26 1:57 ` Chanwoo Choi
2019-07-16 17:36 ` Sibi Sankar
2019-07-16 19:12 ` Saravana Kannan
2019-06-25 21:33 ` Saravana Kannan [this message]
2019-06-26 1:59 ` [PATCH v2 4/4] PM / devfreq: Add required OPPs support to passive governor Chanwoo Choi
[not found] ` <CGME20190625213355epcas5p3805e632818ee999a91e48ef9a610a084@epcms1p4>
2019-06-26 1:30 ` [PATCH v2 3/4] PM / devfreq: Cache OPP table reference in devfreq MyungJoo Ham
[not found] ` <CGME20190625213358epcas4p2391bcf70b54646880cbb60eae8b73acf@epcms1p1>
2019-06-26 1:31 ` [PATCH v2 4/4] PM / devfreq: Add required OPPs support to passive governor MyungJoo Ham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625213337.157525-5-saravanak@google.com \
--to=saravanak@google.com \
--cc=cw00.choi@samsung.com \
--cc=kernel-team@android.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@kernel.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).