From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] omap-iommu: no need to check return value of debugfs_create functions
Date: Fri, 5 Jul 2019 07:24:25 +0200 [thread overview]
Message-ID: <20190705052425.GA8544@kroah.com> (raw)
In-Reply-To: <20190704153551.GG3310@8bytes.org>
On Thu, Jul 04, 2019 at 05:35:52PM +0200, Joerg Roedel wrote:
> On Thu, Jul 04, 2019 at 04:36:49PM +0200, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value. The function can work or not, but the code logic should
> > never do something different based on this.
> >
> > Cc: Joerg Roedel <joro@8bytes.org>
> > Cc: iommu@lists.linux-foundation.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> > Warning, not even test-built, but "should" work :)
>
> It almost did :)
>
> > + debugfs_create_file("regs", 0400, d, obj, &attrregs_fops);
> > + debugfs_create_file("tlb", 0400, d, obj, &attrtlb_fops);
> > + debugfs_create_file("pagetable", 0400, d, obj, &attrpagetable_fops);
>
> The _fops were named without the 'attr' prefix, changed that and it
> compiled. Patch is now applied.
Ah, so close :)
Thanks for fixing it up and applying it!
greg k-h
prev parent reply other threads:[~2019-07-05 5:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 14:36 [PATCH] omap-iommu: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-07-04 15:35 ` Joerg Roedel
2019-07-05 5:24 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190705052425.GA8544@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).