From: "J. Bruce Fields" <bfields@fieldses.org>
To: Joe Perches <joe@perches.com>
Cc: Chuck Lever <chuck.lever@oracle.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/8] nfsd: Fix misuse of strlcpy
Date: Mon, 8 Jul 2019 23:14:04 -0400 [thread overview]
Message-ID: <20190709031404.GD14439@fieldses.org> (raw)
In-Reply-To: <b51141d12de77eb22101e81f9eb2c9cc44104d7a.1562283944.git.joe@perches.com>
On Thu, Jul 04, 2019 at 04:57:48PM -0700, Joe Perches wrote:
> Probable cut&paste typo - use the correct field size.
Huh, that's been there forever, I wonder why we haven't seen crashes?
Oh, I see, name and authname both have the same size.
Anyway, makes sense, thanks. Will apply for 5.3.
(Unless someone else is getting this; I didn't get copied on the rest of
the series.)
--b.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> fs/nfsd/nfs4idmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4idmap.c b/fs/nfsd/nfs4idmap.c
> index 2961016097ac..d1f285245af8 100644
> --- a/fs/nfsd/nfs4idmap.c
> +++ b/fs/nfsd/nfs4idmap.c
> @@ -83,7 +83,7 @@ ent_init(struct cache_head *cnew, struct cache_head *citm)
> new->type = itm->type;
>
> strlcpy(new->name, itm->name, sizeof(new->name));
> - strlcpy(new->authname, itm->authname, sizeof(new->name));
> + strlcpy(new->authname, itm->authname, sizeof(new->authname));
> }
>
> static void
> --
> 2.15.0
next prev parent reply other threads:[~2019-07-09 3:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 23:57 [PATCH 0/8] treewide: correct misuses of strscpy/strlcpy Joe Perches
2019-07-04 23:57 ` [PATCH 1/8] Input: synaptics: Fix misuse of strlcpy Joe Perches
2019-07-14 18:29 ` Dmitry Torokhov
2019-07-04 23:57 ` [PATCH 2/8] leds: as3645a: " Joe Perches
2019-07-05 7:33 ` Sakari Ailus
2019-07-05 20:23 ` Pavel Machek
2019-07-15 18:29 ` Jacek Anaszewski
2019-07-04 23:57 ` [PATCH 3/8] media: m2m-deinterlace: Fix misuse of strscpy Joe Perches
2019-07-04 23:57 ` [PATCH 4/8] media: go7007: " Joe Perches
2019-07-04 23:57 ` [PATCH 5/8] net: ethernet: sun4i-emac: Fix misuse of strlcpy Joe Perches
2019-07-08 2:22 ` David Miller
2019-07-04 23:57 ` [PATCH 6/8] net: nixge: " Joe Perches
2019-07-08 2:23 ` David Miller
2019-07-04 23:57 ` [PATCH 7/8] tty: hvcs: Fix odd use " Joe Perches
2019-07-04 23:57 ` [PATCH 8/8] nfsd: Fix misuse " Joe Perches
2019-07-09 3:14 ` J. Bruce Fields [this message]
2019-07-09 5:40 ` Joe Perches
2019-07-09 23:33 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709031404.GD14439@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).