From: Jean Delvare <jdelvare@suse.de>
To: Krzysztof Halasa <khalasa@piap.pl>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/3] soc: ixp4xx: Really select helper drivers automatically
Date: Fri, 12 Jul 2019 15:50:49 +0200 [thread overview]
Message-ID: <20190712155049.09ecfaf5@endymion> (raw)
In-Reply-To: <20190712153722.3d1498be@endymion>
Kconfig claims that the ixp4xx-qmgr and ixp4xx-npe helper drivers
are selected automatically as needed. However this is not what the
Kconfig entries are doing. Convert depends to select to match the
help texts.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Krzysztof Halasa <khalasa@piap.pl>
---
Sorry about the weird patch numbering, I found this issue right before
sending the other patch so I had to insert a new patch in the middle of
the series.
This should get tested on ixp4xx, I could only test on x86.
drivers/net/ethernet/xscale/Kconfig | 7 ++++---
drivers/net/wan/Kconfig | 4 +++-
2 files changed, 7 insertions(+), 4 deletions(-)
--- linux-5.2.orig/drivers/net/ethernet/xscale/Kconfig 2019-07-12 15:44:22.617698231 +0200
+++ linux-5.2/drivers/net/ethernet/xscale/Kconfig 2019-07-12 15:48:00.538938930 +0200
@@ -6,8 +6,7 @@
config NET_VENDOR_XSCALE
bool "Intel XScale IXP devices"
default y
- depends on NET_VENDOR_INTEL && (ARM && ARCH_IXP4XX && \
- IXP4XX_NPE && IXP4XX_QMGR)
+ depends on NET_VENDOR_INTEL && (ARM && ARCH_IXP4XX)
---help---
If you have a network (Ethernet) card belonging to this class, say Y.
@@ -20,9 +19,11 @@ if NET_VENDOR_XSCALE
config IXP4XX_ETH
tristate "Intel IXP4xx Ethernet support"
- depends on ARM && ARCH_IXP4XX && IXP4XX_NPE && IXP4XX_QMGR
+ depends on ARM && ARCH_IXP4XX
select PHYLIB
select NET_PTP_CLASSIFY
+ select IXP4XX_NPE
+ select IXP4XX_QMGR
---help---
Say Y here if you want to use built-in Ethernet ports
on IXP4xx processor.
--- linux-5.2.orig/drivers/net/wan/Kconfig 2019-07-12 15:44:22.628698395 +0200
+++ linux-5.2/drivers/net/wan/Kconfig 2019-07-12 15:47:25.211414758 +0200
@@ -329,7 +329,9 @@ config DSCC4_PCI_RST
config IXP4XX_HSS
tristate "Intel IXP4xx HSS (synchronous serial port) support"
- depends on HDLC && ARM && ARCH_IXP4XX && IXP4XX_NPE && IXP4XX_QMGR
+ depends on HDLC && ARM && ARCH_IXP4XX
+ select IXP4XX_NPE
+ select IXP4XX_QMGR
help
Say Y here if you want to use built-in HSS ports
on IXP4xx processor.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2019-07-12 13:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 13:37 [PATCH 1/2] soc: ixp4xx: List the whole directory in MAINTAINERS Jean Delvare
2019-07-12 13:50 ` Jean Delvare [this message]
2019-07-12 13:57 ` [PATCH 3/3] soc: ixp4xx: Hide auto-selected drivers Jean Delvare
2019-08-01 8:44 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712155049.09ecfaf5@endymion \
--to=jdelvare@suse.de \
--cc=khalasa@piap.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).