From: Jacopo Mondi <jacopo@jmondi.org>
To: Joe Perches <joe@perches.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH 04/12] iio: adc: max9611: Fix misuse of GENMASK macro
Date: Sun, 14 Jul 2019 16:37:56 +0200 [thread overview]
Message-ID: <20190714143756.2hqmncnbx7nftj7w@uno.localdomain> (raw)
In-Reply-To: <b3744e64b22de98bfe8885f76811d4fc7e41b8eb.camel@perches.com>
[-- Attachment #1: Type: text/plain, Size: 2394 bytes --]
Hi Joe, Jonathan,
On Sun, Jul 14, 2019 at 05:19:32AM -0700, Joe Perches wrote:
> On Sun, 2019-07-14 at 12:54 +0100, Jonathan Cameron wrote:
> > On Tue, 9 Jul 2019 22:04:17 -0700
> > Joe Perches <joe@perches.com> wrote:
> >
> > > Arguments are supposed to be ordered high then low.
> > >
> > > Signed-off-by: Joe Perches <joe@perches.com>
> >
> > Applied to the fixes-togreg branch of iio.git and marked for
> > stable etc.
>
> This mask is used in an init function called from a probe.
>
> I don't have this hardware but it looks as if it could
> never have worked so I doubt the driver and the hardware
> have ever been tested.
>
Ups, this is embarassing! Thanks for noticing
I actually tested the device before sending the driver of course
> Does anyone have this device in actual use?
>
The driver is currently in use in Renesas Gen3 Salvator boards:
arch/arm64/boot/dts/renesas/salvator-common.dtsi:466
I might need some time before I can actually test and tell what's
happening though. It might work by pure chance. Fortunately the mask
is only used for validation of the temperature reading at probe time,
and I can tell this passes (we would have noticed otherwise, Salvator
is one of the reference Gen3 platforms for upstream development).
As said I might need some time before I can test this, but the change
is indeed correct.
Thanks
j
>
> regval = ret & MAX9611_TEMP_MASK;
>
> if ((regval > MAX9611_TEMP_MAX_POS &&
> regval < MAX9611_TEMP_MIN_NEG) ||
> regval > MAX9611_TEMP_MAX_NEG) {
> dev_err(max9611->dev,
> "Invalid value received from ADC 0x%4x: aborting\n",
> regval);
> return -EIO;
> }
>
>
> > Thanks,
> >
> > Jonathan
> >
> > > ---
> > > drivers/iio/adc/max9611.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max9611.c
> > > index 917223d5ff5b..0e3c6529fc4c 100644
> > > --- a/drivers/iio/adc/max9611.c
> > > +++ b/drivers/iio/adc/max9611.c
> > > @@ -83,7 +83,7 @@
> > > #define MAX9611_TEMP_MAX_POS 0x7f80
> > > #define MAX9611_TEMP_MAX_NEG 0xff80
> > > #define MAX9611_TEMP_MIN_NEG 0xd980
> > > -#define MAX9611_TEMP_MASK GENMASK(7, 15)
> > > +#define MAX9611_TEMP_MASK GENMASK(15, 7)
> > > #define MAX9611_TEMP_SHIFT 0x07
> > > #define MAX9611_TEMP_RAW(_r) ((_r) >> MAX9611_TEMP_SHIFT)
> > > #define MAX9611_TEMP_SCALE_NUM 1000000
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-07-14 14:36 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190710050444epcas1p250f7aa0f8798a7757df51d66f5970c2a@epcas1p2.samsung.com>
2019-07-10 5:04 ` [PATCH 00/12] treewide: Fix GENMASK misuses Joe Perches
2019-07-10 5:04 ` [PATCH 01/12] checkpatch: Add GENMASK tests Joe Perches
2019-07-24 18:03 ` Joe Perches
2019-07-10 5:04 ` [PATCH 02/12] clocksource/drivers/npcm: Fix misuse of GENMASK macro Joe Perches
2019-07-10 9:10 ` [tip:timers/urgent] " tip-bot for Joe Perches
2019-07-15 10:00 ` [PATCH 02/12] " Avi Fishman
2019-07-10 5:04 ` [PATCH 03/12] drm: aspeed_gfx: " Joe Perches
2019-07-24 17:16 ` Joe Perches
2019-07-25 1:10 ` Andrew Jeffery
2019-07-25 1:18 ` Joe Perches
2019-07-25 2:52 ` Joel Stanley
2019-07-25 14:37 ` Joe Perches
2019-07-10 5:04 ` [PATCH 04/12] iio: adc: max9611: " Joe Perches
2019-07-14 11:54 ` Jonathan Cameron
2019-07-14 12:19 ` Joe Perches
2019-07-14 14:37 ` Jacopo Mondi [this message]
2019-07-29 21:52 ` Jacopo Mondi
2019-07-31 8:37 ` Jonathan Cameron
2019-07-10 5:04 ` [PATCH 05/12] irqchip/gic-v3-its: " Joe Perches
2019-07-10 8:28 ` Marc Zyngier
2019-07-10 9:07 ` [tip:irq/urgent] " tip-bot for Joe Perches
2019-07-10 5:04 ` [PATCH 06/12] mmc: meson-mx-sdio: " Joe Perches
2019-07-22 7:23 ` Neil Armstrong
2019-07-22 13:43 ` Ulf Hansson
2019-07-10 5:04 ` [PATCH 07/12] net: ethernet: mediatek: Fix misuses " Joe Perches
2019-07-10 5:04 ` [PATCH 08/12] net: stmmac: " Joe Perches
2019-07-10 10:33 ` Jose Abreu
2019-07-10 5:04 ` [PATCH 09/12] rtw88: Fix misuse " Joe Perches
2019-07-10 5:07 ` Tony Chuang
2019-07-24 11:48 ` Kalle Valo
2019-07-10 5:04 ` [PATCH 10/12] phy: amlogic: G12A: " Joe Perches
2019-07-22 7:23 ` Neil Armstrong
2019-08-23 2:41 ` Kishon Vijay Abraham I
2019-08-23 4:59 ` Joe Perches
2019-07-10 5:04 ` [PATCH 11/12] staging: media: cedrus: " Joe Perches
2019-07-10 7:23 ` Paul Kocialkowski
2019-07-24 17:09 ` Joe Perches
2019-07-24 18:35 ` Greg Kroah-Hartman
2019-07-24 18:39 ` Joe Perches
2019-07-24 18:55 ` Greg Kroah-Hartman
2019-07-25 6:46 ` Hans Verkuil
2019-07-10 5:04 ` [PATCH 12/12] ASoC: wcd9335: " Joe Perches
2019-07-22 12:22 ` Applied "ASoC: wcd9335: Fix misuse of GENMASK macro" to the asoc tree Mark Brown
2019-07-10 9:17 ` [PATCH 00/12] treewide: Fix GENMASK misuses Johannes Berg
2019-07-10 9:43 ` Russell King - ARM Linux admin
2019-07-10 15:45 ` Joe Perches
2019-07-10 16:01 ` Joe Perches
2019-07-27 19:54 ` Rikard Falkeborn
2019-07-28 23:45 ` Joe Perches
2019-07-31 19:03 ` [PATCH] linux/bits.h: Add compile time sanity check of GENMASK inputs Rikard Falkeborn
2019-07-31 19:27 ` Joe Perches
2019-08-01 23:03 ` Rikard Falkeborn
2019-08-02 1:40 ` Masahiro Yamada
2019-08-02 3:13 ` Joe Perches
2019-08-02 3:25 ` Masahiro Yamada
2019-08-02 18:18 ` Rikard Falkeborn
2019-08-03 3:03 ` Masahiro Yamada
2019-08-03 3:12 ` Masahiro Yamada
2019-08-03 18:36 ` Rikard Falkeborn
2019-08-04 6:45 ` Masahiro Yamada
2019-08-05 19:55 ` Rikard Falkeborn
2019-08-06 15:19 ` Masahiro Yamada
2019-08-06 19:27 ` Rikard Falkeborn
2019-08-06 21:15 ` Joe Perches
2019-08-07 20:53 ` Rikard Falkeborn
2019-08-01 2:50 ` Masahiro Yamada
2019-08-01 2:57 ` Joe Perches
2019-08-01 23:03 ` Rikard Falkeborn
2019-08-01 23:03 ` [PATCH v2 1/2] linux/bits.h: Clarify macro argument names Rikard Falkeborn
2019-08-01 23:03 ` [PATCH v2 2/2] linux/bits.h: Add compile time sanity check of GENMASK inputs Rikard Falkeborn
2019-08-01 23:14 ` Joe Perches
2019-08-07 14:27 ` Guenter Roeck
2019-08-07 14:55 ` Masahiro Yamada
2019-08-07 16:52 ` Guenter Roeck
2019-08-07 20:07 ` Rikard Falkeborn
2019-08-08 0:07 ` Joe Perches
2019-08-08 0:58 ` Guenter Roeck
2019-08-08 1:08 ` Joe Perches
2019-08-08 1:53 ` Guenter Roeck
2019-08-08 2:44 ` kbuild test robot
2019-08-08 2:44 ` kbuild test robot
2019-08-08 3:46 ` [PATCH v2 1/2] linux/bits.h: Clarify macro argument names Masahiro Yamada
2019-08-10 18:43 ` Rikard Falkeborn
2019-08-10 19:20 ` Joe Perches
2019-08-11 18:49 ` [PATCH v3 0/3] Add compile time sanity check of GENMASK inputs Rikard Falkeborn
2019-08-11 18:49 ` [PATCH v3 1/3] x86/boot: Use common BUILD_BUG_ON Rikard Falkeborn
2019-08-12 18:19 ` [tip:x86/boot] " tip-bot for Rikard Falkeborn
2019-08-16 12:19 ` tip-bot for Rikard Falkeborn
2019-08-11 18:49 ` [PATCH v3 2/3] linux/build_bug.h: Change type to int Rikard Falkeborn
2019-10-06 2:26 ` Masahiro Yamada
2019-08-11 18:49 ` [PATCH v3 3/3] linux/bits.h: Add compile time sanity check of GENMASK inputs Rikard Falkeborn
2019-10-06 2:30 ` Masahiro Yamada
2019-10-08 7:23 ` Geert Uytterhoeven
2019-10-08 7:44 ` Masahiro Yamada
2019-10-08 7:52 ` Masahiro Yamada
2019-10-08 19:06 ` Rikard Falkeborn
2019-08-12 17:58 ` [PATCH v3 0/3] " Kees Cook
2019-10-05 19:46 ` Rikard Falkeborn
2019-10-09 21:45 ` [Patch v4 0/2] " Rikard Falkeborn
2019-10-09 21:45 ` [Patch v4 1/2] linux/build_bug.h: Change type to int Rikard Falkeborn
2019-10-09 21:45 ` [Patch v4 2/2] linux/bits.h: Add compile time sanity check of GENMASK inputs Rikard Falkeborn
2019-10-10 2:24 ` Masahiro Yamada
2019-10-12 2:27 ` Andrew Morton
2019-10-22 19:53 ` Rikard Falkeborn
2019-11-01 21:28 ` Rikard Falkeborn
2020-03-08 19:39 ` [PATCH v5] " Rikard Falkeborn
2020-03-09 16:40 ` Kees Cook
2019-07-11 21:30 ` [PATCH 00/12] treewide: Fix GENMASK misuses David Miller
2019-07-12 12:54 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190714143756.2hqmncnbx7nftj7w@uno.localdomain \
--to=jacopo@jmondi.org \
--cc=akpm@linux-foundation.org \
--cc=jacopo+renesas@jmondi.org \
--cc=jic23@kernel.org \
--cc=joe@perches.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).