From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Brian Norris <briannorris@chromium.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
Yan-Hsuan Chuang <yhchuang@realtek.com>
Subject: Re: [PATCH] mac80211: don't warn about CW params when not using them
Date: Thu, 18 Jul 2019 09:45:23 +0200 [thread overview]
Message-ID: <20190718074522.GA13713@redhat.com> (raw)
In-Reply-To: <20190718015712.197499-1-briannorris@chromium.org>
On Wed, Jul 17, 2019 at 06:57:12PM -0700, Brian Norris wrote:
> ieee80211_set_wmm_default() normally sets up the initial CW min/max for
> each queue, except that it skips doing this if the driver doesn't
> support ->conf_tx. We still end up calling drv_conf_tx() in some cases
> (e.g., ieee80211_reconfig()), which also still won't do anything
> useful...except it complains here about the invalid CW parameters.
>
> Let's just skip the WARN if we weren't going to do anything useful with
> the parameters.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> Noticed because rtw88 does not currently implement .conf_tx()
>
> I think there are several ways to slice this one. I picked one fix,
> which may not be the best one.
Fix looks fine for me. However I think rtw88 should implement
drv_conf_tx() because parameters can be different on different
network setups and maybe more important WMM/AC parameters become
quite recently part of ETSI regulatory.
Stanislaw
next prev parent reply other threads:[~2019-07-18 7:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 1:57 [PATCH] mac80211: don't warn about CW params when not using them Brian Norris
2019-07-18 7:45 ` Stanislaw Gruszka [this message]
2019-07-18 15:48 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718074522.GA13713@redhat.com \
--to=sgruszka@redhat.com \
--cc=briannorris@chromium.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).