From: Hariprasad Kelam <hariprasad.kelam@gmail.com>
To: Steven Price <steven.price@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] rqchip/stm32: Remove unneeded call to kfree
Date: Tue, 23 Jul 2019 21:49:02 +0530 [thread overview]
Message-ID: <20190723161902.GA2910@hari-Inspiron-1545> (raw)
In-Reply-To: <1d9aa4be-4da2-b532-4787-c98869c0bd9d@arm.com>
On Mon, Jul 22, 2019 at 11:26:09AM +0100, Steven Price wrote:
> On 19/07/2019 19:46, Hariprasad Kelam wrote:
> > Memory allocated by devm_ alloc will be freed upon device detachment. So
> > we may not require free memory.
> >
> > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> > ---
> > drivers/irqchip/irq-stm32-exti.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
> > index e00f2fa..46ec0af 100644
> > --- a/drivers/irqchip/irq-stm32-exti.c
> > +++ b/drivers/irqchip/irq-stm32-exti.c
> > @@ -779,8 +779,6 @@ static int __init stm32_exti_init(const struct stm32_exti_drv_data *drv_data,
> > irq_domain_remove(domain);
> > out_unmap:
> > iounmap(host_data->base);
> > - kfree(host_data->chips_data);
> > - kfree(host_data);
>
> In the commit this is based on these variables are not allocated using a
> devm_ alloc function:
>
> $ git show e00f2fa | grep -A12 *stm32_exti_host_init
> > stm32_exti_host_data *stm32_exti_host_init(const struct stm32_exti_drv_data *dd,
> > struct device_node *node)
> > {
> > struct stm32_exti_host_data *host_data;
> >
> > host_data = kzalloc(sizeof(*host_data), GFP_KERNEL);
> > if (!host_data)
> > return NULL;
> >
> > host_data->drv_data = dd;
> > host_data->chips_data = kcalloc(dd->bank_nr,
> > sizeof(struct stm32_exti_chip_data),
> > GFP_KERNEL);
> The function stm32_exti_probe *does* use devm_k?alloc, so perhaps you
> were getting confused with that?
>
> Steve
>
Yes thanks for explanation. Please ignore this patch
Thanks,
Hariprasad k
> > return ret;
> > }
> >
> >
>
prev parent reply other threads:[~2019-07-23 16:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 18:46 [PATCH] rqchip/stm32: Remove unneeded call to kfree Hariprasad Kelam
2019-07-22 10:26 ` Steven Price
2019-07-23 16:19 ` Hariprasad Kelam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723161902.GA2910@hari-Inspiron-1545 \
--to=hariprasad.kelam@gmail.com \
--cc=alexandre.torgue@st.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marc.zyngier@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=steven.price@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).