From: Moritz Fischer <mdf@kernel.org>
To: thor.thayer@linux.intel.com
Cc: mdf@kernel.org, richard.gong@linux.intel.com, agust@denx.de,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 0/3] fpga: altera-cvp: Add Stratix10 Support
Date: Thu, 25 Jul 2019 10:22:31 -0700 [thread overview]
Message-ID: <20190725172231.GA9274@archbox> (raw)
In-Reply-To: <1564067808-21173-1-git-send-email-thor.thayer@linux.intel.com>
Hi Thor,
On Thu, Jul 25, 2019 at 10:16:45AM -0500, thor.thayer@linux.intel.com wrote:
> From: Thor Thayer <thor.thayer@linux.intel.com>
>
> Newer versions (V2) of Altera/Intel FPGAs CvP have different PCI
> Vendor Specific Capability offsets than the older (V1) Altera/FPGAs.
>
> Most of the CvP registers and their bitfields remain the same
> between both the older parts and the newer parts.
>
> This patchset implements changes to discover the Vendor Specific
> Capability offset and then add Stratix10 CvP support.
>
> V2 Changes:
> Remove inline designator from abstraction functions.
> Reverse Christmas Tree format for local variables
> Remove redundant mask from credit calculation
> Add commment for the delay(1) function in wait_for_credit()
>
> V3 Changes
> Return int instead of void for abstraction functions
> Check the return code from read in altera_cvp_chk_error()
> Move reset of current_credit_byte to clear_state().
> Check return codes of read/writes in added functions.
>
> Thor Thayer (3):
> fpga: altera-cvp: Discover Vendor Specific offset
> fpga: altera-cvp: Preparation for V2 parts.
> fpga: altera-cvp: Add Stratix10 (V2) Support
>
> drivers/fpga/altera-cvp.c | 348 ++++++++++++++++++++++++++++++++++++----------
> 1 file changed, 277 insertions(+), 71 deletions(-)
>
> --
> 2.7.4
>
this doesn't apply since I applied Carlos' patch 998c1de56dac7
("fpga: altera-cvp: Fix function definition argument") yesterday to
git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git
'for-next' branch.
Would you mind resending it on top of that and drop the extra dev_dbg()
for the offset in Patch [1/3]?
Sorry about that. Things are moving around a bit, but hopefully settle
down soon :)
- Moritz
prev parent reply other threads:[~2019-07-25 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 15:16 [PATCHv3 0/3] fpga: altera-cvp: Add Stratix10 Support thor.thayer
2019-07-25 15:16 ` [PATCHv3 1/3] fpga: altera-cvp: Discover Vendor Specific offset thor.thayer
2019-07-25 15:16 ` [PATCHv3 2/3] fpga: altera-cvp: Preparation for V2 parts thor.thayer
2019-07-25 15:16 ` [PATCHv3 3/3] fpga: altera-cvp: Add Stratix10 (V2) Support thor.thayer
2019-07-26 20:42 ` Moritz Fischer
2019-07-29 14:08 ` Thor Thayer
2019-07-25 17:22 ` Moritz Fischer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725172231.GA9274@archbox \
--to=mdf@kernel.org \
--cc=agust@denx.de \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.gong@linux.intel.com \
--cc=thor.thayer@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).