From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE0CC7618B for ; Fri, 26 Jul 2019 14:41:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06BCA20651 for ; Fri, 26 Jul 2019 14:41:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q7yPlGBx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387507AbfGZOl2 (ORCPT ); Fri, 26 Jul 2019 10:41:28 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:34828 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726491AbfGZOl2 (ORCPT ); Fri, 26 Jul 2019 10:41:28 -0400 Received: by mail-qt1-f194.google.com with SMTP id d23so52845831qto.2 for ; Fri, 26 Jul 2019 07:41:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RltjC0MFbvBe6X1Yz/ZCVy4yjaXXAxX4eCdM+4PWQDs=; b=Q7yPlGBxCHkuXoz3eGzhxU6LU1ka29sm3N3xqZDkAyoi4gVLa8JnJG8+Ahat+nLiLw 1afvh6pfHhmgUCc61zXOS+HlfwAvW8qkZcMff/NSFD9wvCzR2H2r0/3PfSdHIvCvNPr3 uVv0nvfGMiSOkXPV9HqU+GggKiEOVwqrfRgG/WHAtrYNA/7pEpNN112VIK0Umh2KM2oQ ezIj+0GizOODEVfwACoM3Rwo4ajXXuOKzYqIx09uaJ+3Ubfc9gkzTNp7uQoJ7zXcB3JH ViCYNtOM2DPlX1AncMeGt4uSVyfV6xcl1LFbuSbvRL+UXLwevzMlYIsX6bUCL9lc9CCD Etfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RltjC0MFbvBe6X1Yz/ZCVy4yjaXXAxX4eCdM+4PWQDs=; b=qa11goiHAFP7/JZVLE9TV3KEwrmjxxZ0UW/Z/6XoaaPX9u8tkRtmq6HymIgwAi33N4 8kU6RHh6Q4hd0KE6Hy+SwJS+wfJlzWDtF3DxdPsbEzL64MmGPxa4DuHLPUnyb3USzJT0 /FG41VIds2hiQuHetvGOxt0tWFBCL4bptick8sPjSX018/OoEvjOAVEzqeYNxwxto6M0 eKBb6V4ideXKqh/vAV7hYAo8vajFfhQ7xweAQz6ACsme+wfpqINE01jDTkExE6gb9l3S 3oyOpFuruTGeC1xdXmuLY4PKsam2iI4ToutWAcG1FRylH/bOwgKv8dAZfSxyt8YQiOoa ZZwg== X-Gm-Message-State: APjAAAUZaY8C0yE04IJnIkIFbmrr+TUL2+vN7OOMp/ULbzeyVPL/0tr+ x3ejjaGCWOdS3JWwvaPH5TK8qjIu X-Google-Smtp-Source: APXvYqybblvJeY8bgc4dydbCWp0bzF47hI+ys0eTRcPaYK4QTs6BGjpCLegQ4Ft1WCfavguH3f4R9w== X-Received: by 2002:ac8:354d:: with SMTP id z13mr68838722qtb.340.1564152087199; Fri, 26 Jul 2019 07:41:27 -0700 (PDT) Received: from quaco.ghostprotocols.net ([179.97.35.50]) by smtp.gmail.com with ESMTPSA id g3sm23179363qke.105.2019.07.26.07.41.24 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Jul 2019 07:41:25 -0700 (PDT) From: Arnaldo Carvalho de Melo X-Google-Original-From: Arnaldo Carvalho de Melo Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 87CFB40340; Fri, 26 Jul 2019 11:41:22 -0300 (-03) Date: Fri, 26 Jul 2019 11:41:22 -0300 To: Jiri Olsa Cc: lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Andi Kleen , Alexey Budankov , Michael Petlan Subject: Re: [PATCH 23/79] libperf: Make libperf.a part of the build Message-ID: <20190726144122.GA20482@kernel.org> References: <20190721112506.12306-1-jolsa@kernel.org> <20190721112506.12306-24-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190721112506.12306-24-jolsa@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sun, Jul 21, 2019 at 01:24:10PM +0200, Jiri Olsa escreveu: > Adding empty libperf.a under toos/perf/lib and > linking it with perf. > > It can also be built separately with: > > $ cd tools/perf/lib && make > CC core.o > LD libperf-in.o > AR libperf.a > LINK libperf.so Committer notes: Need to add -I$(srctree)/tools/arch/$(ARCH)/include/uapi -I$(srctree)/tools/include/uapi to tools/perf/lib/Makefile's INCLUDE variable to pick up the latest versions of kernel headers, even in older systems, this is in line with what is in tools/lib/bpf/Makefile. I.e. this patch: [acme@quaco perf]$ git diff diff --git a/tools/perf/lib/Makefile b/tools/perf/lib/Makefile index e6f2eb702aaa..33046e7c6a2a 100644 --- a/tools/perf/lib/Makefile +++ b/tools/perf/lib/Makefile @@ -33,7 +33,7 @@ else CFLAGS := -g -Wall endif -INCLUDES = -I. -Iinclude -I$(srctree)/tools/include -I$(srctree)/tools/arch/$(ARCH)/include/ +INCLUDES = -I$(srctree)/tools/perf/lib/include -I$(srctree)/tools/include -I$(srctree)/tools/arch/$(ARCH)/include/ -I$(srctree)/tools/arch/$(ARCH)/include/uapi -I$(srctree)/tools/include/uapi # Append required CFLAGS override CFLAGS += $(EXTRA_WARNINGS) [acme@quaco perf]$ - Arnaldo > Link: http://lkml.kernel.org/n/tip-lzrlfu3hutepbeqyntjks3za@git.kernel.org > Signed-off-by: Jiri Olsa > --- > tools/perf/Makefile.config | 1 + > tools/perf/Makefile.perf | 30 ++++++++-------- > tools/perf/lib/Build | 1 + > tools/perf/lib/Makefile | 74 ++++++++++++++++++++++++++++++++++++++ > tools/perf/lib/core.c | 0 > 5 files changed, 92 insertions(+), 14 deletions(-) > create mode 100644 tools/perf/lib/Build > create mode 100644 tools/perf/lib/Makefile > create mode 100644 tools/perf/lib/core.c > > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config > index 89ac5a1f1550..e4988f49ea79 100644 > --- a/tools/perf/Makefile.config > +++ b/tools/perf/Makefile.config > @@ -277,6 +277,7 @@ ifeq ($(DEBUG),0) > endif > endif > > +INC_FLAGS += -I$(src-perf)/lib/include > INC_FLAGS += -I$(src-perf)/util/include > INC_FLAGS += -I$(src-perf)/arch/$(SRCARCH)/include > INC_FLAGS += -I$(srctree)/tools/include/uapi > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > index 0fffd2bb6cd9..6e7e7d44ffac 100644 > --- a/tools/perf/Makefile.perf > +++ b/tools/perf/Makefile.perf > @@ -224,6 +224,7 @@ LIB_DIR = $(srctree)/tools/lib/api/ > TRACE_EVENT_DIR = $(srctree)/tools/lib/traceevent/ > BPF_DIR = $(srctree)/tools/lib/bpf/ > SUBCMD_DIR = $(srctree)/tools/lib/subcmd/ > +LIBPERF_DIR = $(srctree)/tools/perf/lib/ > > # Set FEATURE_TESTS to 'all' so all possible feature checkers are executed. > # Without this setting the output feature dump file misses some features, for > @@ -272,6 +273,7 @@ ifneq ($(OUTPUT),) > TE_PATH=$(OUTPUT) > BPF_PATH=$(OUTPUT) > SUBCMD_PATH=$(OUTPUT) > + LIBPERF_PATH=$(OUTPUT) > ifneq ($(subdir),) > API_PATH=$(OUTPUT)/../lib/api/ > else > @@ -282,6 +284,7 @@ else > API_PATH=$(LIB_DIR) > BPF_PATH=$(BPF_DIR) > SUBCMD_PATH=$(SUBCMD_DIR) > + LIBPERF_PATH=$(LIBPERF_DIR) > endif > > LIBTRACEEVENT = $(TE_PATH)libtraceevent.a > @@ -303,6 +306,8 @@ LIBBPF = $(BPF_PATH)libbpf.a > > LIBSUBCMD = $(SUBCMD_PATH)libsubcmd.a > > +LIBPERF = $(LIBPERF_PATH)libperf.a > + > # python extension build directories > PYTHON_EXTBUILD := $(OUTPUT)python_ext_build/ > PYTHON_EXTBUILD_LIB := $(PYTHON_EXTBUILD)lib/ > @@ -348,9 +353,7 @@ endif > > export PERL_PATH > > -LIBPERF_A=$(OUTPUT)libperf.a > - > -PERFLIBS = $(LIBAPI) $(LIBTRACEEVENT) $(LIBSUBCMD) > +PERFLIBS = $(LIBAPI) $(LIBTRACEEVENT) $(LIBSUBCMD) $(LIBPERF) > ifndef NO_LIBBPF > PERFLIBS += $(LIBBPF) > endif > @@ -583,8 +586,6 @@ JEVENTS_IN := $(OUTPUT)pmu-events/jevents-in.o > > PMU_EVENTS_IN := $(OUTPUT)pmu-events/pmu-events-in.o > > -LIBPERF_IN := $(OUTPUT)libperf-in.o > - > export JEVENTS > > build := -f $(srctree)/tools/build/Makefile.build dir=. obj > @@ -601,12 +602,9 @@ $(JEVENTS): $(JEVENTS_IN) > $(PMU_EVENTS_IN): $(JEVENTS) FORCE > $(Q)$(MAKE) -f $(srctree)/tools/build/Makefile.build dir=pmu-events obj=pmu-events > > -$(LIBPERF_IN): prepare FORCE > - $(Q)$(MAKE) $(build)=libperf > - > -$(OUTPUT)perf: $(PERFLIBS) $(PERF_IN) $(PMU_EVENTS_IN) $(LIBPERF_IN) $(LIBTRACEEVENT_DYNAMIC_LIST) > +$(OUTPUT)perf: $(PERFLIBS) $(PERF_IN) $(PMU_EVENTS_IN) $(LIBTRACEEVENT_DYNAMIC_LIST) > $(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $(LIBTRACEEVENT_DYNAMIC_LIST_LDFLAGS) \ > - $(PERF_IN) $(PMU_EVENTS_IN) $(LIBPERF_IN) $(LIBS) -o $@ > + $(PERF_IN) $(PMU_EVENTS_IN) $(LIBS) -o $@ > > $(GTK_IN): FORCE > $(Q)$(MAKE) $(build)=gtk > @@ -727,9 +725,6 @@ endif > > $(patsubst perf-%,%.o,$(PROGRAMS)): $(wildcard */*.h) > > -$(LIBPERF_A): $(LIBPERF_IN) > - $(QUIET_AR)$(RM) $@ && $(AR) rcs $@ $(LIBPERF_IN) $(LIB_OBJS) > - > LIBTRACEEVENT_FLAGS += plugin_dir=$(plugindir_SQ) 'EXTRA_CFLAGS=$(EXTRA_CFLAGS)' 'LDFLAGS=$(LDFLAGS)' > > $(LIBTRACEEVENT): FORCE > @@ -762,6 +757,13 @@ $(LIBBPF)-clean: > $(call QUIET_CLEAN, libbpf) > $(Q)$(MAKE) -C $(BPF_DIR) O=$(OUTPUT) clean >/dev/null > > +$(LIBPERF): FORCE > + $(Q)$(MAKE) -C $(LIBPERF_DIR) O=$(OUTPUT) $(OUTPUT)libperf.a > + > +$(LIBPERF)-clean: > + $(call QUIET_CLEAN, libperf) > + $(Q)$(MAKE) -C $(LIBPERF_DIR) O=$(OUTPUT) clean >/dev/null > + > $(LIBSUBCMD): FORCE > $(Q)$(MAKE) -C $(SUBCMD_DIR) O=$(OUTPUT) $(OUTPUT)libsubcmd.a > > @@ -948,7 +950,7 @@ config-clean: > python-clean: > $(python-clean) > > -clean:: $(LIBTRACEEVENT)-clean $(LIBAPI)-clean $(LIBBPF)-clean $(LIBSUBCMD)-clean config-clean fixdep-clean python-clean > +clean:: $(LIBTRACEEVENT)-clean $(LIBAPI)-clean $(LIBBPF)-clean $(LIBSUBCMD)-clean $(LIBPERF)-clean config-clean fixdep-clean python-clean > $(call QUIET_CLEAN, core-objs) $(RM) $(LIBPERF_A) $(OUTPUT)perf-archive $(OUTPUT)perf-with-kcore $(LANG_BINDINGS) > $(Q)find $(if $(OUTPUT),$(OUTPUT),.) -name '*.o' -delete -o -name '\.*.cmd' -delete -o -name '\.*.d' -delete > $(Q)$(RM) $(OUTPUT).config-detected > diff --git a/tools/perf/lib/Build b/tools/perf/lib/Build > new file mode 100644 > index 000000000000..5196958cec01 > --- /dev/null > +++ b/tools/perf/lib/Build > @@ -0,0 +1 @@ > +libperf-y += core.o > diff --git a/tools/perf/lib/Makefile b/tools/perf/lib/Makefile > new file mode 100644 > index 000000000000..e6f2eb702aaa > --- /dev/null > +++ b/tools/perf/lib/Makefile > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) > +# Most of this file is copied from tools/lib/bpf/Makefile > + > +MAKEFLAGS += --no-print-directory > + > +ifeq ($(srctree),) > +srctree := $(patsubst %/,%,$(dir $(CURDIR))) > +srctree := $(patsubst %/,%,$(dir $(srctree))) > +srctree := $(patsubst %/,%,$(dir $(srctree))) > +#$(info Determined 'srctree' to be $(srctree)) > +endif > + > +include $(srctree)/tools/scripts/Makefile.include > +include $(srctree)/tools/scripts/Makefile.arch > + > +ifeq ("$(origin V)", "command line") > + VERBOSE = $(V) > +endif > +ifndef VERBOSE > + VERBOSE = 0 > +endif > + > +ifeq ($(VERBOSE),1) > + Q = > +else > + Q = @ > +endif > + > +# Set compile option CFLAGS > +ifdef EXTRA_CFLAGS > + CFLAGS := $(EXTRA_CFLAGS) > +else > + CFLAGS := -g -Wall > +endif > + > +INCLUDES = -I. -Iinclude -I$(srctree)/tools/include -I$(srctree)/tools/arch/$(ARCH)/include/ > + > +# Append required CFLAGS > +override CFLAGS += $(EXTRA_WARNINGS) > +override CFLAGS += -Werror -Wall > +override CFLAGS += -fPIC > +override CFLAGS += $(INCLUDES) > +override CFLAGS += -fvisibility=hidden > + > +all: > + > +export srctree OUTPUT CC LD CFLAGS V > +include $(srctree)/tools/build/Makefile.include > + > +LIBPERF_SO := $(OUTPUT)libperf.so > +LIBPERF_A := $(OUTPUT)libperf.a > +LIBPERF_IN := $(OUTPUT)libperf-in.o > + > +$(LIBPERF_IN): FORCE > + $(Q)$(MAKE) $(build)=libperf > + > +$(LIBPERF_A): $(LIBPERF_IN) > + $(QUIET_AR)$(RM) $@ && $(AR) rcs $@ $(LIBPERF_IN) > + > +$(LIBPERF_SO): $(LIBPERF_IN) > + $(QUIET_LINK)$(CC) --shared -Wl,-soname,libperf.so $^ -o $@ > + > +libs: $(LIBPERF_A) $(LIBPERF_SO) > + > +all: fixdep > + $(Q)$(MAKE) libs > + > +clean: > + $(call QUIET_CLEAN, libperf) $(RM) $(LIBPERF_A) \ > + *.o *~ *.a *.so .*.d .*.cmd LIBPERF-CFLAGS > + > +FORCE: > + > +.PHONY: all install clean FORCE > diff --git a/tools/perf/lib/core.c b/tools/perf/lib/core.c > new file mode 100644 > index 000000000000..e69de29bb2d1 > -- > 2.21.0 -- - Arnaldo