From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74D8CC7618B for ; Mon, 29 Jul 2019 15:59:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C15421773 for ; Mon, 29 Jul 2019 15:59:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="GwjgBUER" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728758AbfG2P74 (ORCPT ); Mon, 29 Jul 2019 11:59:56 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:41668 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728265AbfG2P74 (ORCPT ); Mon, 29 Jul 2019 11:59:56 -0400 Received: by mail-pl1-f195.google.com with SMTP id m9so27575429pls.8 for ; Mon, 29 Jul 2019 08:59:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ypw9PUbsShknmT2duzGjmQ83venT9YzhrR/q0NdLkL4=; b=GwjgBUER3x86bQrzgggNOqaONeQm7M4oF4dWF9VHXIXm+J9ORp+B66F0mbXg3X4ikg FJfBV315qg3LM6m2+amp6YyawGiYqN5jaqmw7T4+kb1IYyB3VqTbP/v6eKB0LofMXShG NW8IG/xrk9KXSzf/dmPh7SkgYkTm2qiPaYojI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ypw9PUbsShknmT2duzGjmQ83venT9YzhrR/q0NdLkL4=; b=UKJrSwzWrNbuli51NbSbe8r882Bh5+Aq6XEcmdaW7f2Qy59fR5wiDnK7ZlqbpaIjjs RqlsBXY9HHlk1uJuVm8EYbQZvy6TJ+xXGSvFEoe9pwFnvFrVsOyiqodjhyTG0pPEeFoM GxwT2I1IhDGvqF74kd9DCCPO1BN7wZBgfntxgUothALMMNpQNjIpCAT9C+wKj07GodrI GPn0IIJYnhcmILFKTHnSQTbIqCy/Vvrekn7V7Ayzniw8bv1P/G5eHl6OJo2iV36FSxJq PltEKMyryRMcv05TT6Bb+xNHlbI14kd1kN6vRUFvjMaysJK3VzlxdW0uK4MO+s1UfgoW uDlw== X-Gm-Message-State: APjAAAUjFCJE7e1zjGlfTIAeMwnEpHTRXUiVNGkcNkuZ+TPnL/qjVBlU E8a+rByehGe20mkGxApolQLttQ== X-Google-Smtp-Source: APXvYqxQqArafC9IimGzDGwVWM723dCkB1XEmSqfUV0sVHdThXbA5OabXfrSR2b1qQhfBv/iOji9Tg== X-Received: by 2002:a17:902:bcc4:: with SMTP id o4mr108706932pls.90.1564415995533; Mon, 29 Jul 2019 08:59:55 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z63sm33165280pfb.98.2019.07.29.08.59.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Jul 2019 08:59:54 -0700 (PDT) Date: Mon, 29 Jul 2019 08:59:53 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Michael Grzeschik , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Rothwell Subject: Re: [PATCH] arcnet: com90xx: Mark expected switch fall-throughs Message-ID: <201907290859.E762A250@keescook> References: <20190729110953.GA3048@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190729110953.GA3048@embeddedor> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 29, 2019 at 06:09:53AM -0500, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warnings (Building: powerpc allyesconfig): > > drivers/net/arcnet/com90xx.c: In function 'com90xx_setup': > include/linux/printk.h:304:2: warning: this statement may fall through [-Wimplicit-fallthrough=] > printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/net/arcnet/com90xx.c:695:3: note: in expansion of macro 'pr_err' > pr_err("Too many arguments\n"); > ^~~~~~ > drivers/net/arcnet/com90xx.c:696:2: note: here > case 3: /* Mem address */ > ^~~~ > drivers/net/arcnet/com90xx.c:697:9: warning: this statement may fall through [-Wimplicit-fallthrough=] > shmem = ints[3]; > ~~~~~~^~~~~~~~~ > drivers/net/arcnet/com90xx.c:698:2: note: here > case 2: /* IRQ */ > ^~~~ > drivers/net/arcnet/com90xx.c:699:7: warning: this statement may fall through [-Wimplicit-fallthrough=] > irq = ints[2]; > ~~~~^~~~~~~~~ > drivers/net/arcnet/com90xx.c:700:2: note: here > case 1: /* IO address */ > ^~~~ > > Reported-by: Stephen Rothwell > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -Kees > --- > drivers/net/arcnet/com90xx.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/arcnet/com90xx.c b/drivers/net/arcnet/com90xx.c > index ca4a57c30bf8..bd75d06ad7df 100644 > --- a/drivers/net/arcnet/com90xx.c > +++ b/drivers/net/arcnet/com90xx.c > @@ -693,10 +693,13 @@ static int __init com90xx_setup(char *s) > switch (ints[0]) { > default: /* ERROR */ > pr_err("Too many arguments\n"); > + /* Fall through */ > case 3: /* Mem address */ > shmem = ints[3]; > + /* Fall through */ > case 2: /* IRQ */ > irq = ints[2]; > + /* Fall through */ > case 1: /* IO address */ > io = ints[1]; > } > -- > 2.22.0 > -- Kees Cook