From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Chunyan Zhang <zhang.lyra@gmail.com>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lvqiang Huang <lvqiang.huang@unisoc.com>
Subject: Re: [PATCH] ARM: check stmfd instruction using right shift
Date: Tue, 30 Jul 2019 12:02:04 +0100 [thread overview]
Message-ID: <20190730110204.GB1330@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAAfSe-tPVsMjmu0CoUATGRGevCpgqk999-rpfMuXqZ-V9ft7gg@mail.gmail.com>
On Tue, Jul 30, 2019 at 03:18:31PM +0800, Chunyan Zhang wrote:
> Gentle ping
>
> probably this patch was missed or entered into spam?
Please submit it to the patch system, thanks.
>
> On Mon, 22 Jul 2019 at 15:14, Chunyan Zhang <zhang.lyra@gmail.com> wrote:
> >
> > From: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
> >
> > In the commit ef41b5c92498 ("ARM: make kernel oops easier to read"),
> > - .word 0xe92d0000 >> 10 @ stmfd sp!, {}
> > + .word 0xe92d0000 >> 11 @ stmfd sp!, {}
> > then the shift need to change to 11.
> >
> > Fixes: ef41b5c92498 ("ARM: make kernel oops easier to read")
> > Signed-off-by: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
> > Signed-off-by: Chunyan Zhang <zhang.lyra@gmail.com>
> > ---
> > arch/arm/lib/backtrace.S | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/lib/backtrace.S b/arch/arm/lib/backtrace.S
> > index 7d7952e..926851b 100644
> > --- a/arch/arm/lib/backtrace.S
> > +++ b/arch/arm/lib/backtrace.S
> > @@ -70,7 +70,7 @@ for_each_frame: tst frame, mask @ Check for address exceptions
> >
> > 1003: ldr r2, [sv_pc, #-4] @ if stmfd sp!, {args} exists,
> > ldr r3, .Ldsi+4 @ adjust saved 'pc' back one
> > - teq r3, r2, lsr #10 @ instruction
> > + teq r3, r2, lsr #11 @ instruction
> > subne r0, sv_pc, #4 @ allow for mov
> > subeq r0, sv_pc, #8 @ allow for mov + stmia
> >
> > --
> > 1.7.9.5
> >
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-07-30 11:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 7:11 [PATCH] ARM: check stmfd instruction using right shift Chunyan Zhang
2019-07-22 7:14 ` Chunyan Zhang
2019-07-30 7:18 ` Chunyan Zhang
2019-07-30 11:02 ` Russell King - ARM Linux admin [this message]
2019-07-31 3:30 ` Chunyan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730110204.GB1330@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvqiang.huang@unisoc.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).