From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DFC4C433FF for ; Tue, 30 Jul 2019 12:35:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECA9E206E0 for ; Tue, 30 Jul 2019 12:35:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730053AbfG3Mfj (ORCPT ); Tue, 30 Jul 2019 08:35:39 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:38845 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727993AbfG3Mfi (ORCPT ); Tue, 30 Jul 2019 08:35:38 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hsRLj-0005tb-FO; Tue, 30 Jul 2019 14:35:27 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hsRLf-0001Vh-M1; Tue, 30 Jul 2019 14:35:23 +0200 Date: Tue, 30 Jul 2019 14:35:23 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: David Lechner Cc: linux-iio@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Mark Rutland , =?iso-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , William Breathitt Gray , Thierry Reding , linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org Subject: Re: [PATCH 2/4] counter: new TI eQEP driver Message-ID: <20190730123523.cjtmr3tpttn6r3pt@pengutronix.de> References: <20190722154538.5314-1-david@lechnology.com> <20190722154538.5314-3-david@lechnology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190722154538.5314-3-david@lechnology.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 22, 2019 at 10:45:36AM -0500, David Lechner wrote: > This adds a new counter driver for the Texas Instruments Enhanced > Quadrature Encoder Pulse (eQEP) module. > > Only very basic functionality is currently implemented - only enough to > be able to read the position. The actual device has many more features > which can be added to the driver on an as-needed basis. > > Signed-off-by: David Lechner > --- > MAINTAINERS | 6 + > drivers/counter/Kconfig | 12 ++ > drivers/counter/Makefile | 1 + > drivers/counter/ti-eqep.c | 381 ++++++++++++++++++++++++++++++++++++++ > drivers/pwm/Kconfig | 2 +- It's not obvious why the change to drivers/pwm/Kconfig is needed. Can you please motivate that in the change log? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |