From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF235C433FF for ; Tue, 30 Jul 2019 18:16:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 97BA72089E for ; Tue, 30 Jul 2019 18:16:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="hIdDJTyQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728930AbfG3SQL (ORCPT ); Tue, 30 Jul 2019 14:16:11 -0400 Received: from mail-pg1-f180.google.com ([209.85.215.180]:37454 "EHLO mail-pg1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728655AbfG3SQF (ORCPT ); Tue, 30 Jul 2019 14:16:05 -0400 Received: by mail-pg1-f180.google.com with SMTP id i70so19736705pgd.4 for ; Tue, 30 Jul 2019 11:16:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dV2FBRE428VEXIw34vqUyE1reej3GG1J5+23fb3pWDg=; b=hIdDJTyQnv2sCvpPPj8uG/bm1NM6+QP8RWrDpJCdYuITk3aToBDBc6jYhD/rrps3JH 1jFKO6Nr35YFOIqsQo4yvntlJkBWSGAZ+KU9YVAx3Mu7wuQH2Jhd6gknbUzE2Y4deSug XdppPOLMLj/r7fNj787tddVekWLSasaxnvglQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dV2FBRE428VEXIw34vqUyE1reej3GG1J5+23fb3pWDg=; b=p2Ugn5vhiesWqw0t3d/7Lr+XWAJi7fwQUl7iqpxQTSEYotpDWBBQJCBTlHC1LAVfKi r+UmxmLNUfsgQKRmFAOrVH8esXtRU9jlYAYSJjmOJyUXsh4AsxQpzXsihuYYQFrh1xyQ eL9054YJSt8/6GfC9DlWt/lR7kZyqC7yJNELZWOlC7YeUJUl22WAsAzyvoVKqnV3bjWP XCluvtZwvlkqgOhOZdzYc8lzTrRjWodrOZ++RX1+sG7CkR77s6mc7+N2B/2Dba9V43Vp V9rmRIDWe9Kbb6egQqhXqaMM6nHpNKBU5dQsBte0D0VsMXqsGUmjEHTZHX42vOzXGShY lgFA== X-Gm-Message-State: APjAAAXIIy80ZubI03VnSSpAZ2LkJsnXlL+EMKiH5RhaU9op7Uvx62AB Z8nPYs1HVyyRg/JH5RQ6KYzs7209XD4= X-Google-Smtp-Source: APXvYqx2Pqv5uDlrdziTUf03ket19wq3XsklTtQ40rrDwc4TnzRTamQqtGiQjDRMH9JAhWTfXXOa0Q== X-Received: by 2002:a63:6c4:: with SMTP id 187mr103277632pgg.401.1564510563865; Tue, 30 Jul 2019 11:16:03 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id g1sm106744083pgg.27.2019.07.30.11.16.03 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 11:16:03 -0700 (PDT) From: Stephen Boyd To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman Subject: [PATCH v6 06/57] cpufreq: Remove dev_err() usage after platform_get_irq() Date: Tue, 30 Jul 2019 11:15:06 -0700 Message-Id: <20190730181557.90391-7-swboyd@chromium.org> X-Mailer: git-send-email 2.22.0.709.g102302147b-goog In-Reply-To: <20190730181557.90391-1-swboyd@chromium.org> References: <20190730181557.90391-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | platform_get_irq_byname(E, ...) ); if ( \( ret < 0 \| ret <= 0 \) ) { ( -if (ret != -EPROBE_DEFER) -{ ... -dev_err(...); -... } | ... -dev_err(...); ) ... } // While we're here, remove braces on if statements that only have one statement (manually). Cc: Greg Kroah-Hartman Signed-off-by: Stephen Boyd --- Please apply directly to subsystem trees drivers/cpufreq/brcmstb-avs-cpufreq.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/cpufreq/brcmstb-avs-cpufreq.c b/drivers/cpufreq/brcmstb-avs-cpufreq.c index 77b0e5d0fb13..27057c8bf035 100644 --- a/drivers/cpufreq/brcmstb-avs-cpufreq.c +++ b/drivers/cpufreq/brcmstb-avs-cpufreq.c @@ -538,8 +538,6 @@ static int brcm_avs_prepare_init(struct platform_device *pdev) host_irq = platform_get_irq_byname(pdev, BRCM_AVS_HOST_INTR); if (host_irq < 0) { - dev_err(dev, "Couldn't find interrupt %s -- %d\n", - BRCM_AVS_HOST_INTR, host_irq); ret = host_irq; goto unmap_intr_base; } -- Sent by a computer through tubes