From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AA97C0650F for ; Tue, 30 Jul 2019 18:51:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 00110208E4 for ; Tue, 30 Jul 2019 18:51:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564512677; bh=CsmCRJXukR0FZ6/5kobffgcEJX6Pp1GPGySlVRYW5js=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=QfRNfUY1IZwBtR1iSq4Vv+CVIFIyTEuv9CmvxMS9tSDSKSZLXjZtBxIto9PTl1WSX T8O0/2MZ/04EAcQwYEkwRlVmZebsvUZg6+WT/gmQP/cS4nSqWhHAdATT7zCGcHvfxN K98NzGJfcJZ5UE94TJMA0ayWbM9AggxOepXJ3xY0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730220AbfG3SvQ (ORCPT ); Tue, 30 Jul 2019 14:51:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:33098 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726165AbfG3SvP (ORCPT ); Tue, 30 Jul 2019 14:51:15 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3053320693; Tue, 30 Jul 2019 18:51:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564512674; bh=CsmCRJXukR0FZ6/5kobffgcEJX6Pp1GPGySlVRYW5js=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bsuJcdmhOlXBLCSe1VpVY3yIZKNYZ0N60s/p0emjIOvoZqX6A7jACiG0cG9mxOM5K gRuxr/VkEAx5JFwfwpRcCl6SerEcYCVdMhvqENgmH99J1YN09T/dBp90H9ivis18+k J4Sz/nZgLHnzhCNzXTqtRm7Iddmr08EeaC9nQ4Qg= Date: Tue, 30 Jul 2019 20:51:12 +0200 From: Greg Kroah-Hartman To: Stephen Boyd Cc: "Rafael J. Wysocki" , Tri Vo , "Rafael J. Wysocki" , Viresh Kumar , Hridya Valsaraju , Sandeep Patil , Kalesh Singh , Ravi Chandra Sadineni , Linux Kernel Mailing List , Linux PM , "Cc: Android Kernel" , kbuild test robot Subject: Re: [PATCH v5] PM / wakeup: show wakeup sources stats in sysfs Message-ID: <20190730185112.GA17119@kroah.com> References: <20190730024309.233728-1-trong@android.com> <5d4090ea.1c69fb81.d5cab.4dcd@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d4090ea.1c69fb81.d5cab.4dcd@mx.google.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 30, 2019 at 11:48:09AM -0700, Stephen Boyd wrote: > Quoting Tri Vo (2019-07-30 11:39:34) > > On Mon, Jul 29, 2019 at 10:46 PM Rafael J. Wysocki wrote: > > > > > > On Tue, Jul 30, 2019 at 4:45 AM Tri Vo wrote: > > > > - Device registering the wakeup source is now the parent of the wakeup source. > > > > Updated wakeup_source_register()'s signature and its callers accordingly. > > > > > > And I really don't like these changes. Especially having "wakeup" > > > twice in the path. > > > > I can trim it down to /sys/class/wakeup//. Does that sound good? > > Using the same prefix for the class and the device name is quite common. > For example, see the input, regulator, tty, tpm, remoteproc, hwmon, > extcon classes. I'd prefer it was left as /sys/class/wakeup/wakeupN. The > class name could be changed to wakeup_source perhaps (i.e. > /sys/class/wakeup_source/wakeupN)? > Ah, the issue is that these end up on the virtual "bus". Yeah, sorry, you are right, they need to have a unique prefix in order to prevent name collisions. thanks, greg k-h