From: Steven Rostedt <rostedt@goodmis.org>
To: Matt Helsley <mhelsley@vmware.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v4 0/8] recordmcount cleanups
Date: Fri, 2 Aug 2019 13:47:12 -0400 [thread overview]
Message-ID: <20190802134712.2d8cc63f@gandalf.local.home> (raw)
In-Reply-To: <cover.1564596289.git.mhelsley@vmware.com>
On Wed, 31 Jul 2019 11:24:08 -0700
Matt Helsley <mhelsley@vmware.com> wrote:
> recordmcount presents unnecessary challenges to reviewers:
>
> It pretends to wrap access to the ELF file in
> uread/uwrite/ulseek functions which aren't related
> the way you might think (i.e. not the way read, write,
> and lseek are releated to each other).
>
> It uses setjmp/longjmp to handle errors (and success)
> during processing of the object files. This makes it
> hard to review what functions are doing, how globals
> change over time, etc.
>
> There are some kernel style nits.
>
> This series addresses all of those by removing un-helper functions,
> unused parameters, and rewriting the error/success handling to
> better resemble regular kernel C code.
>
I applied these patches to my queue.
I pushed them to my repo on branch ftrace/core
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
But note, that this branch will rebase, probably on top of v5.3-rc3
when it comes out.
-- Steve
prev parent reply other threads:[~2019-08-02 17:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 18:24 [PATCH v4 0/8] recordmcount cleanups Matt Helsley
2019-07-31 18:24 ` [PATCH v4 1/8] recordmcount: Remove redundant strcmp Matt Helsley
2019-07-31 18:24 ` [PATCH v4 2/8] recordmcount: Remove uread() Matt Helsley
2019-07-31 18:24 ` [PATCH v4 3/8] recordmcount: Remove unused fd from uwrite() and ulseek() Matt Helsley
2019-07-31 18:24 ` [PATCH v4 4/8] recordmcount: Rewrite error/success handling Matt Helsley
2019-10-09 10:46 ` Uwe Kleine-König
2019-10-09 15:05 ` Steven Rostedt
2019-10-09 15:22 ` Uwe Kleine-König
2019-10-10 16:23 ` Steven Rostedt
2019-10-10 20:14 ` Uwe Kleine-König
2019-07-31 18:24 ` [PATCH v4 5/8] recordmcount: Kernel style function signature formatting Matt Helsley
2019-07-31 18:24 ` [PATCH v4 6/8] recordmcount: Kernel style formatting Matt Helsley
2019-07-31 18:24 ` [PATCH v4 7/8] recordmcount: Remove redundant cleanup() calls Matt Helsley
2019-07-31 18:24 ` [PATCH v4 8/8] recordmcount: Clarify what cleanup() does Matt Helsley
2019-08-02 17:47 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190802134712.2d8cc63f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhelsley@vmware.com \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).