From: Jonathan Cameron <jic23@kernel.org>
To: Chuhong Yuan <hslester96@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Brian Masney <masneyb@onstation.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/4] iio: tsl2772: Use devm_iio_device_register
Date: Mon, 5 Aug 2019 16:32:12 +0100 [thread overview]
Message-ID: <20190805163157.1ee0c0c0@archlinux> (raw)
In-Reply-To: <20190801073612.9689-1-hslester96@gmail.com>
On Thu, 1 Aug 2019 15:36:12 +0800
Chuhong Yuan <hslester96@gmail.com> wrote:
> Use devm_iio_device_register, which removes the tsl2772_remove
> function.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Applied.
Thanks,
J
> ---
> Changes in v4:
> - Split v3 into three patches.
> - Revise description to make it more precise.
>
> drivers/iio/light/tsl2772.c | 19 +------------------
> 1 file changed, 1 insertion(+), 18 deletions(-)
>
> diff --git a/drivers/iio/light/tsl2772.c b/drivers/iio/light/tsl2772.c
> index e866ae40f157..680afdb078d2 100644
> --- a/drivers/iio/light/tsl2772.c
> +++ b/drivers/iio/light/tsl2772.c
> @@ -1890,14 +1890,7 @@ static int tsl2772_probe(struct i2c_client *clientp,
> if (ret < 0)
> return ret;
>
> - ret = iio_device_register(indio_dev);
> - if (ret) {
> - dev_err(&clientp->dev,
> - "%s: iio registration failed\n", __func__);
> - return ret;
> - }
> -
> - return 0;
> + return devm_iio_device_register(&clientp->dev, indio_dev);
> }
>
> static int tsl2772_suspend(struct device *dev)
> @@ -1934,15 +1927,6 @@ static int tsl2772_resume(struct device *dev)
> return tsl2772_chip_on(indio_dev);
> }
>
> -static int tsl2772_remove(struct i2c_client *client)
> -{
> - struct iio_dev *indio_dev = i2c_get_clientdata(client);
> -
> - iio_device_unregister(indio_dev);
> -
> - return 0;
> -}
> -
> static const struct i2c_device_id tsl2772_idtable[] = {
> { "tsl2571", tsl2571 },
> { "tsl2671", tsl2671 },
> @@ -1989,7 +1973,6 @@ static struct i2c_driver tsl2772_driver = {
> },
> .id_table = tsl2772_idtable,
> .probe = tsl2772_probe,
> - .remove = tsl2772_remove,
> };
>
> module_i2c_driver(tsl2772_driver);
prev parent reply other threads:[~2019-08-05 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 7:36 [PATCH v4 3/4] iio: tsl2772: Use devm_iio_device_register Chuhong Yuan
2019-08-05 15:32 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805163157.1ee0c0c0@archlinux \
--to=jic23@kernel.org \
--cc=hslester96@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).