From: Andrew Morton <akpm@linux-foundation.org>
To: NeilBrown <neilb@suse.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Sergei Turchanov <turchanov@farpost.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] seq_file: fix problem when seeking mid-record.
Date: Tue, 6 Aug 2019 15:42:33 -0700 [thread overview]
Message-ID: <20190806154233.5b16a91fd27c6cf129770566@linux-foundation.org> (raw)
In-Reply-To: <87mugojl0f.fsf@notabene.neil.brown.name>
On Mon, 05 Aug 2019 14:26:08 +1000 NeilBrown <neilb@suse.com> wrote:
> If you use lseek or similar (e.g. pread) to access
> a location in a seq_file file that is within a record,
> rather than at a record boundary, then the first read
> will return the remainder of the record, and the second
> read will return the whole of that same record (instead
> of the next record).
> Whnn seeking to a record boundary, the next record is
> correctly returned.
ouch. I'm surprised it took this long to be noticed.
Maybe we need a seqfile-basher in tools/testing/selftests/proc or
somewhere.
prev parent reply other threads:[~2019-08-06 22:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 6:16 [BUG] lseek on /proc/meminfo is broken in 4.19.59 Sergei Turchanov
2019-08-01 7:11 ` Gao Xiang
2019-08-01 7:52 ` Sergei Turchanov
2019-08-01 8:09 ` [BUG] lseek on /proc/meminfo is broken in 4.19.59 maybe due to commit 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and interface") Sergei Turchanov
2019-08-01 9:14 ` NeilBrown
2019-08-02 1:40 ` Sergei Turchanov
2019-08-05 4:26 ` [PATCH] seq_file: fix problem when seeking mid-record NeilBrown
2019-08-05 9:15 ` Markus Elfring
2019-08-05 10:08 ` NeilBrown
2019-08-06 22:42 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806154233.5b16a91fd27c6cf129770566@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.com \
--cc=turchanov@farpost.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).