From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Helen Koike <helen.koike@collabora.com>
Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
eddie.cai.linux@gmail.com, mchehab@kernel.org, heiko@sntech.de,
jacob2.chen@rock-chips.com, jeffy.chen@rock-chips.com,
zyc@rock-chips.com, linux-kernel@vger.kernel.org,
tfiga@chromium.org, hans.verkuil@cisco.com,
laurent.pinchart@ideasonboard.com, kernel@collabora.com,
ezequiel@collabora.com, linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, zhengsq@rock-chips.com,
Jacob Chen <cc@rock-chips.com>,
Allon Huang <allon.huang@rock-chips.com>
Subject: Re: [PATCH v8 09/14] media: rkisp1: add rockchip isp1 core driver
Date: Wed, 7 Aug 2019 18:36:46 +0300 [thread overview]
Message-ID: <20190807153646.GO21370@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20190730184256.30338-10-helen.koike@collabora.com>
Hi Helen,
On Tue, Jul 30, 2019 at 03:42:51PM -0300, Helen Koike wrote:
...
> +static int rkisp1_fwnode_parse(struct device *dev,
> + struct v4l2_fwnode_endpoint *vep,
> + struct v4l2_async_subdev *asd)
> +{
> + struct sensor_async_subdev *s_asd =
> + container_of(asd, struct sensor_async_subdev, asd);
> +
> + if (vep->bus_type != V4L2_MBUS_CSI2_DPHY) {
> + dev_err(dev, "Only CSI2 bus type is currently supported\n");
> + return -EINVAL;
> + }
> +
> + if (vep->base.port != 0) {
> + dev_err(dev, "The ISP has only port 0\n");
> + return -EINVAL;
> + }
> +
> + s_asd->mbus.type = vep->bus_type;
> + s_asd->mbus.flags = vep->bus.mipi_csi2.flags;
> + s_asd->lanes = vep->bus.mipi_csi2.num_data_lanes;
> +
> + switch (vep->bus.mipi_csi2.num_data_lanes) {
> + case 1:
> + s_asd->mbus.flags |= V4L2_MBUS_CSI2_1_LANE;
> + break;
> + case 2:
> + s_asd->mbus.flags |= V4L2_MBUS_CSI2_2_LANE;
> + break;
> + case 3:
> + s_asd->mbus.flags |= V4L2_MBUS_CSI2_3_LANE;
> + break;
> + case 4:
> + s_asd->mbus.flags |= V4L2_MBUS_CSI2_4_LANE;
> + break;
Could you use struct v4l2_fwnode_endpoint directly? The mbus config is a
legacy struct from bygone times and I'd like to avoid using it in new
drivers.
> + default:
> + return -EINVAL;
> + }
> +
> + return 0;
> +}
> +
> +static const struct v4l2_async_notifier_operations subdev_notifier_ops = {
> + .bound = subdev_notifier_bound,
> + .unbind = subdev_notifier_unbind,
> + .complete = subdev_notifier_complete,
> +};
> +
> +static int isp_subdev_notifier(struct rkisp1_device *isp_dev)
> +{
> + struct v4l2_async_notifier *ntf = &isp_dev->notifier;
> + struct device *dev = isp_dev->dev;
> + int ret;
> +
> + v4l2_async_notifier_init(ntf);
> +
> + ret = v4l2_async_notifier_parse_fwnode_endpoints_by_port(
> + dev, ntf, sizeof(struct sensor_async_subdev), 0,
> + rkisp1_fwnode_parse);
I know these functions aren't old but there's a better alternative. See
e.g. isp_parse_of_endpoints in drivers/media/platform/omap3isp/isp.c or
cio2_parse_firmware in drivers/media/pci/intel/ipu3/ipu3-cio2.c.
> + if (ret < 0)
> + return ret;
> +
> + if (list_empty(&ntf->asd_list))
> + return -ENODEV; /* no endpoint */
> +
> + ntf->ops = &subdev_notifier_ops;
> +
> + return v4l2_async_notifier_register(&isp_dev->v4l2_dev, ntf);
> +}
--
Sakari Ailus
sakari.ailus@linux.intel.com
next prev parent reply other threads:[~2019-08-07 15:36 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 18:42 [PATCH v8 00/14] Rockchip ISP1 Driver Helen Koike
2019-07-30 18:42 ` [PATCH v8 01/14] media: videodev2.h, v4l2-ioctl: add rkisp1 meta buffer format Helen Koike
2019-08-15 13:30 ` Laurent Pinchart
2019-07-30 18:42 ` [PATCH v8 02/14] media: doc: add document for " Helen Koike
2019-08-07 13:09 ` Sakari Ailus
2019-08-15 13:51 ` Laurent Pinchart
2019-07-30 18:42 ` [PATCH v8 03/14] media: rkisp1: Add user space ABI definitions Helen Koike
2019-08-15 18:46 ` Laurent Pinchart
2020-07-10 12:59 ` Dafna Hirschfeld
2020-07-10 13:36 ` Laurent Pinchart
2020-07-10 14:30 ` Dafna Hirschfeld
2019-07-30 18:42 ` [PATCH v8 04/14] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver Helen Koike
2019-08-07 13:05 ` Sakari Ailus
2019-08-07 13:37 ` Helen Koike
2019-08-15 17:54 ` Laurent Pinchart
2019-08-15 18:26 ` Heiko Stübner
2019-08-21 21:46 ` Helen Koike
2019-08-22 2:32 ` Laurent Pinchart
2019-07-30 18:42 ` [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver Helen Koike
2019-08-06 18:51 ` Helen Koike
2019-08-07 10:39 ` Hans Verkuil
2019-08-15 19:35 ` Laurent Pinchart
2020-03-25 6:34 ` Dafna Hirschfeld
2020-03-25 7:11 ` Laurent Pinchart
2020-03-25 8:51 ` Dafna Hirschfeld
2020-03-25 9:11 ` Laurent Pinchart
2019-08-08 9:14 ` Sakari Ailus
2019-08-15 0:58 ` Helen Koike
2019-08-15 8:24 ` Sakari Ailus
2019-08-15 10:29 ` Tomasz Figa
2019-08-15 10:45 ` Sakari Ailus
2019-08-15 13:17 ` Sakari Ailus
2020-01-31 19:38 ` Dafna Hirschfeld
2020-02-12 21:13 ` Sakari Ailus
2020-02-13 12:50 ` Dafna Hirschfeld
2019-08-16 0:13 ` Laurent Pinchart
2020-07-11 11:04 ` Dafna Hirschfeld
2020-07-17 7:46 ` Dafna Hirschfeld
2020-07-22 16:01 ` Tomasz Figa
2020-07-22 15:24 ` Tomasz Figa
2020-07-22 16:30 ` Laurent Pinchart
2020-07-22 17:12 ` Tomasz Figa
2020-07-22 17:50 ` Laurent Pinchart
2020-08-05 21:10 ` Dafna Hirschfeld
2020-08-06 9:21 ` Dafna Hirschfeld
2020-08-06 12:22 ` Tomasz Figa
2020-08-07 16:08 ` Dafna Hirschfeld
2020-08-13 6:17 ` Dafna Hirschfeld
2020-08-06 12:08 ` Tomasz Figa
2020-08-07 16:02 ` Dafna Hirschfeld
2019-07-30 18:42 ` [PATCH v8 06/14] media: rkisp1: add ISP1 statistics driver Helen Koike
2019-08-08 9:37 ` Sakari Ailus
2019-07-30 18:42 ` [PATCH v8 07/14] media: rkisp1: add ISP1 params driver Helen Koike
2019-07-30 18:42 ` [PATCH v8 08/14] media: rkisp1: add capture device driver Helen Koike
2019-07-30 18:42 ` [PATCH v8 09/14] media: rkisp1: add rockchip isp1 core driver Helen Koike
2019-08-07 15:27 ` Sakari Ailus
2019-08-08 21:59 ` Helen Koike
2019-08-09 12:05 ` Sakari Ailus
2019-08-07 15:36 ` Sakari Ailus [this message]
2019-07-30 18:42 ` [PATCH v8 10/14] dt-bindings: Document the Rockchip ISP1 bindings Helen Koike
2019-08-16 0:21 ` Laurent Pinchart
2019-07-30 18:42 ` [PATCH v8 11/14] dt-bindings: Document the Rockchip MIPI RX D-PHY bindings Helen Koike
2019-08-15 18:14 ` Laurent Pinchart
2019-07-30 18:42 ` [PATCH v8 12/14] arm64: dts: rockchip: add isp0 node for rk3399 Helen Koike
2019-07-30 18:42 ` [PATCH v8 13/14] arm64: dts: rockchip: add rx0 mipi-phy " Helen Koike
2019-07-30 18:42 ` [PATCH v8 14/14] MAINTAINERS: add entry for Rockchip ISP1 driver Helen Koike
2019-08-15 13:56 ` Laurent Pinchart
2019-07-30 20:15 ` [PATCH v8 00/14] Rockchip ISP1 Driver Hans Verkuil
2019-07-30 20:50 ` Helen Koike
2019-07-31 0:08 ` Helen Koike
2019-07-31 4:29 ` Hans Verkuil
2019-07-31 4:33 ` Hans Verkuil
2019-07-31 4:55 ` Hans Verkuil
2019-07-31 14:42 ` Helen Koike
2019-08-07 15:37 ` Sakari Ailus
2019-08-07 17:57 ` Helen Koike
2019-08-09 18:45 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807153646.GO21370@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=allon.huang@rock-chips.com \
--cc=cc@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.cai.linux@gmail.com \
--cc=ezequiel@collabora.com \
--cc=hans.verkuil@cisco.com \
--cc=heiko@sntech.de \
--cc=helen.koike@collabora.com \
--cc=jacob2.chen@rock-chips.com \
--cc=jeffy.chen@rock-chips.com \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=tfiga@chromium.org \
--cc=zhengsq@rock-chips.com \
--cc=zyc@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).