From: Andrew Lunn <andrew@lunn.ch>
To: Tao Ren <taoren@fb.com>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Samuel Mendoza-Jonas <sam@mendozajonas.com>,
"David S . Miller" <davem@davemloft.net>,
William Kennington <wak@google.com>
Subject: Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset
Date: Fri, 9 Aug 2019 01:03:12 +0200 [thread overview]
Message-ID: <20190808230312.GS27917@lunn.ch> (raw)
In-Reply-To: <ac22bbe0-36ca-b4b9-7ea7-7b1741c2070d@fb.com>
> After giving it more thought, I'm thinking about adding ncsi dt node
> with following structure (mac/ncsi similar to mac/mdio/phy):
>
> &mac0 {
> /* MAC properties... */
>
> use-ncsi;
This property seems to be specific to Faraday FTGMAC100. Are you going
to make it more generic?
> ncsi {
> /* ncsi level properties if any */
>
> package@0 {
You should get Rob Herring involved. This is not really describing
hardware, so it might get rejected by the device tree maintainer.
> 1) mac driver doesn't need to parse "mac-offset" stuff: these
> ncsi-network-controller specific settings should be parsed in ncsi
> stack.
> 2) get_bmc_mac_address command is a channel specific command, and
> technically people can configure different offset/formula for
> different channels.
Does that mean the NCSA code puts the interface into promiscuous mode?
Or at least adds these unicast MAC addresses to the MAC receive
filter? Humm, ftgmac100 only seems to support multicast address
filtering, not unicast filters, so it must be using promisc mode, if
you expect to receive frames using this MAC address.
Andrew
next prev parent reply other threads:[~2019-08-08 23:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 0:21 [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset Tao Ren
2019-08-07 18:25 ` Jakub Kicinski
2019-08-07 18:41 ` Andrew Lunn
2019-08-08 4:48 ` Tao Ren
2019-08-08 13:32 ` Andrew Lunn
2019-08-08 19:02 ` Tao Ren
2019-08-08 21:16 ` Andrew Lunn
2019-08-08 22:26 ` Tao Ren
2019-08-08 23:03 ` Andrew Lunn [this message]
2019-08-09 5:29 ` Tao Ren
[not found] ` <10079A1AC4244A41BC7939A794B72C238FCE0E03@fmsmsx104.amr.corp.intel.com>
[not found] ` <bc9da695-3fd3-6643-8e06-562cc08fbc62@linux.intel.com>
2019-08-13 16:31 ` Terry Duncan
[not found] ` <faa1b3c9-9ba3-0fff-e1d4-f6dddb60c52c@fb.com>
2019-08-13 20:54 ` Terry Duncan
2019-08-14 0:22 ` Terry Duncan
[not found] ` <CH2PR15MB3686B3A20A231FC111C42F40A3D20@CH2PR15MB3686.namprd15.prod.outlook.com>
2019-08-13 21:15 ` Terry Duncan
2019-08-07 17:36 Vijay Khemka
2019-08-08 4:51 ` [PATCH " Tao Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808230312.GS27917@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=sam@mendozajonas.com \
--cc=taoren@fb.com \
--cc=wak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).