From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DCBDC3A589 for ; Thu, 15 Aug 2019 12:42:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FF16208C2 for ; Thu, 15 Aug 2019 12:42:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="gHATmie+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731897AbfHOMmo (ORCPT ); Thu, 15 Aug 2019 08:42:44 -0400 Received: from mail.skyhub.de ([5.9.137.197]:45440 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725977AbfHOMmn (ORCPT ); Thu, 15 Aug 2019 08:42:43 -0400 Received: from zn.tnic (p200300EC2F0B52007D93C58FB2CAB236.dip0.t-ipconnect.de [IPv6:2003:ec:2f0b:5200:7d93:c58f:b2ca:b236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A11E31EC0959; Thu, 15 Aug 2019 14:42:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1565872962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=nh3pf51gCZmQw2YfQM+MgPsZnvg6T7RDaOXPp08q8gE=; b=gHATmie+7+tCBI8m6VDMKU7fIzpG6Gr6CPMbvoCpY4Sx/6dNSKkaakRabgFwpXnYcUMDmo IVIPjnTBkD9mOTeMUULICeC+sF25MCrVSpnq/Gjr+S7YBaj3cLwseX9+xPd5Qug0V6sEUj 71VETtXK6yLjo8ZjMz65r/bk4DIXbCU= Date: Thu, 15 Aug 2019 14:43:28 +0200 From: Borislav Petkov To: Jiri Slaby Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 04/28] x86/asm/entry: annotate THUNKs Message-ID: <20190815124328.GG15313@zn.tnic> References: <20190808103854.6192-1-jslaby@suse.cz> <20190808103854.6192-5-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190808103854.6192-5-jslaby@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 08, 2019 at 12:38:30PM +0200, Jiri Slaby wrote: > Place SYM_*_START_NOALIGN and SYM_*_END around the THUNK macro body. > Preserve @function by FUNC (64bit) and CODE (32bit). Given it was not > marked as aligned, use NOALIGN. > > The common tail .L_restore is put inside SYM_CODE_START_LOCAL_NOALIGN > and SYM_CODE_END too. What is that needed for? It is a local label... > The result: > Value Size Type Bind Vis Ndx Name > 0000 28 FUNC GLOBAL DEFAULT 1 trace_hardirqs_on_thunk > 001c 28 FUNC GLOBAL DEFAULT 1 trace_hardirqs_off_thunk > 0038 24 FUNC GLOBAL DEFAULT 1 lockdep_sys_exit_thunk > 0050 24 FUNC GLOBAL DEFAULT 1 ___preempt_schedule > 0068 24 FUNC GLOBAL DEFAULT 1 ___preempt_schedule_notra No difference except alignment: before: 70545: ffffffff81001c20 28 FUNC GLOBAL DEFAULT 1 trace_hardirqs_off_thunk 78965: ffffffff81001c00 28 FUNC GLOBAL DEFAULT 1 trace_hardirqs_on_thunk 82545: ffffffff81001c80 24 FUNC GLOBAL DEFAULT 1 ___preempt_schedule_notra 86963: ffffffff81001c40 24 FUNC GLOBAL DEFAULT 1 lockdep_sys_exit_thunk 88045: ffffffff81001c60 24 FUNC GLOBAL DEFAULT 1 ___preempt_schedule after: 70545: ffffffff81001c10 28 FUNC GLOBAL DEFAULT 1 trace_hardirqs_off_thunk 78965: ffffffff81001bf4 28 FUNC GLOBAL DEFAULT 1 trace_hardirqs_on_thunk 82545: ffffffff81001c5c 24 FUNC GLOBAL DEFAULT 1 ___preempt_schedule_notra 86963: ffffffff81001c2c 24 FUNC GLOBAL DEFAULT 1 lockdep_sys_exit_thunk 88045: ffffffff81001c44 24 FUNC GLOBAL DEFAULT 1 ___preempt_schedule -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.