From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Michał Mirosław <mirq-linux@rere.qmqm.pl>,
"Rob Herring" <robh-dt@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Joseph Lo" <josephl@nvidia.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Peter De Schrijver" <pdeschrijver@nvidia.com>,
"Prashant Gaikwad" <pgaikwad@nvidia.com>,
"Stephen Boyd" <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 01/15] clk: tegra20/30: Add custom EMC clock implementation
Date: Wed, 21 Aug 2019 18:46:05 +0200 [thread overview]
Message-ID: <20190821164605.GA31425@ulmo> (raw)
In-Reply-To: <8369884e-1bd7-063f-e053-5152378078e9@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1868 bytes --]
On Tue, Aug 13, 2019 at 05:36:41AM +0300, Dmitry Osipenko wrote:
> 13.08.2019 2:12, Michał Mirosław пишет:
> > On Mon, Aug 12, 2019 at 12:00:29AM +0300, Dmitry Osipenko wrote:
> >> A proper External Memory Controller clock rounding and parent selection
> >> functionality is required by the EMC drivers, it is not available using
> >> the generic clock implementation because only the Memory Controller driver
> >> is aware of what clock rates are actually available for a particular
> >> device. EMC drivers will have to register a Tegra-specific CLK-API
> >> callback which will perform rounding of a requested rate. EMC clock users
> >> won't be able to request EMC clock by getting -EPROBE_DEFER until EMC
> >> driver is probed and the callback is set up.
> > [...]
> >> diff --git a/drivers/clk/tegra/Makefile b/drivers/clk/tegra/Makefile
> >> index 4812e45c2214..df966ca06788 100644
> >> --- a/drivers/clk/tegra/Makefile
> >> +++ b/drivers/clk/tegra/Makefile
> >> @@ -17,7 +17,9 @@ obj-y += clk-tegra-fixed.o
> >> obj-y += clk-tegra-super-gen4.o
> >> obj-$(CONFIG_TEGRA_CLK_EMC) += clk-emc.o
> >> obj-$(CONFIG_ARCH_TEGRA_2x_SOC) += clk-tegra20.o
> >> +obj-$(CONFIG_ARCH_TEGRA_2x_SOC) += clk-tegra20-emc.o
> >> obj-$(CONFIG_ARCH_TEGRA_3x_SOC) += clk-tegra30.o
> >> +obj-$(CONFIG_ARCH_TEGRA_3x_SOC) += clk-tegra20-emc.o
> >> obj-$(CONFIG_ARCH_TEGRA_114_SOC) += clk-tegra114.o
> >> obj-$(CONFIG_ARCH_TEGRA_124_SOC) += clk-tegra124.o
> >> obj-$(CONFIG_TEGRA_CLK_DFLL) += clk-tegra124-dfll-fcpu.o
> >
> > Doesn't it complain when both CONFIG_ARCH_TEGRA_2x_SOC and
> > CONFIG_ARCH_TEGRA_3x_SOC are enabled at the same time?
>
> No, at least not with my toolchain setup. Are you getting some warning?
Kbuild actually filters out duplicates to facilitate this kind of
construct.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-08-21 16:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-11 21:00 [PATCH v10 00/15] memory: tegra: Introduce Tegra30 EMC driver Dmitry Osipenko
2019-08-11 21:00 ` [PATCH v10 01/15] clk: tegra20/30: Add custom EMC clock implementation Dmitry Osipenko
2019-08-12 23:12 ` Michał Mirosław
2019-08-13 2:36 ` Dmitry Osipenko
2019-08-21 16:46 ` Thierry Reding [this message]
2019-09-10 10:33 ` Stephen Boyd
2019-08-11 21:00 ` [PATCH v10 02/15] memory: tegra20-emc: Drop setting EMC rate to max on probe Dmitry Osipenko
2019-08-11 21:00 ` [PATCH v10 03/15] memory: tegra20-emc: Adapt for clock driver changes Dmitry Osipenko
2019-08-11 21:00 ` [PATCH v10 04/15] memory: tegra20-emc: Include io.h instead of iopoll.h Dmitry Osipenko
2019-08-11 21:00 ` [PATCH v10 05/15] memory: tegra20-emc: Pre-configure debug register Dmitry Osipenko
2019-08-11 21:00 ` [PATCH v10 06/15] memory: tegra20-emc: Print a brief info message about the timings Dmitry Osipenko
2019-08-11 21:00 ` [PATCH v10 07/15] memory: tegra20-emc: Increase handshake timeout Dmitry Osipenko
2019-08-11 21:00 ` [PATCH v10 08/15] memory: tegra20-emc: wait_for_completion_timeout() doesn't return error Dmitry Osipenko
2019-08-11 21:00 ` [PATCH v10 09/15] dt-bindings: memory: tegra30: Convert to Tegra124 YAML Dmitry Osipenko
2019-08-12 19:53 ` Rob Herring
2019-08-12 19:54 ` Rob Herring
2019-08-12 20:19 ` Dmitry Osipenko
2019-08-11 21:00 ` [PATCH v10 10/15] dt-bindings: memory: Add binding for NVIDIA Tegra30 Memory Controller Dmitry Osipenko
2019-08-12 19:55 ` Rob Herring
2019-08-11 21:00 ` [PATCH v10 11/15] dt-bindings: memory: Add binding for NVIDIA Tegra30 External " Dmitry Osipenko
2019-08-12 19:56 ` Rob Herring
2019-08-11 21:00 ` [PATCH v10 12/15] memory: tegra: Introduce Tegra30 EMC driver Dmitry Osipenko
2019-10-05 16:28 ` Peter Geis
2019-10-09 8:52 ` Dmitry Osipenko
2019-11-15 12:54 ` Jon Hunter
2019-11-15 13:17 ` Dmitry Osipenko
2019-08-11 21:00 ` [PATCH v10 13/15] memory: tegra: Ensure timing control debug features are disabled Dmitry Osipenko
2019-08-11 21:00 ` [PATCH v10 14/15] memory: tegra: Consolidate registers definition into common header Dmitry Osipenko
2019-08-11 21:00 ` [PATCH v10 15/15] ARM: dts: tegra30: Add External Memory Controller node Dmitry Osipenko
2019-10-29 13:51 ` [PATCH v10 00/15] memory: tegra: Introduce Tegra30 EMC driver Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821164605.GA31425@ulmo \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=josephl@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=robh-dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).