From: Petr Mladek <pmladek@suse.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: rafael@kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
devicetree@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v5 09/11] lib/vsprintf: OF nodes are first and foremost, struct device_nodes
Date: Tue, 3 Sep 2019 11:28:16 +0200 [thread overview]
Message-ID: <20190903092816.qutqnjba7okcauim@pathway.suse.cz> (raw)
In-Reply-To: <20190903085233.oksjcwqwdxb53eig@pathway.suse.cz>
On Tue 2019-09-03 10:52:33, Petr Mladek wrote:
> On Mon 2019-09-02 16:57:30, Sakari Ailus wrote:
> > Factor out static kobject_string() function that simply calls
> > device_node_string(), and thus remove references to kobjects (as these are
> > struct device_node).
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > lib/vsprintf.c | 16 ++++------------
> > 1 file changed, 4 insertions(+), 12 deletions(-)
> >
> > diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> > index a04a2167101ef..4ad9332d54ba6 100644
> > --- a/lib/vsprintf.c
> > +++ b/lib/vsprintf.c
> > @@ -1905,6 +1905,9 @@ char *device_node_string(char *buf, char *end, struct device_node *dn,
> > struct printf_spec str_spec = spec;
> > str_spec.field_width = -1;
> >
> > + if (fmt[0] != 'F')
> > + return error_string(buf, end, "(%pO?)", spec);
> > +
> > if (!IS_ENABLED(CONFIG_OF))
> > return error_string(buf, end, "(%pOF?)", spec);
> >
> > @@ -1978,17 +1981,6 @@ char *device_node_string(char *buf, char *end, struct device_node *dn,
> > return widen_string(buf, buf - buf_start, end, spec);
> > }
> >
> > -static char *kobject_string(char *buf, char *end, void *ptr,
> > - struct printf_spec spec, const char *fmt)
> > -{
> > - switch (fmt[1]) {
> > - case 'F':
> > - return device_node_string(buf, end, ptr, spec, fmt + 1);
> > - }
> > -
> > - return error_string(buf, end, "(%pO?)", spec);
> > -}
> > -
> > /*
> > * Show a '%p' thing. A kernel extension is that the '%p' is followed
> > * by an extra set of alphanumeric characters that are extended format
> > @@ -2167,7 +2159,7 @@ char *pointer(const char *fmt, char *buf, char *end, void *ptr,
> > case 'G':
> > return flags_string(buf, end, ptr, spec, fmt);
> > case 'O':
> > - return kobject_string(buf, end, ptr, spec, fmt);
> > + return device_node_string(buf, end, ptr, spec, fmt + 1);
>
> I know that this come from from kobject_string(). But please, modify
> it to follow the style used by other %p modifiers. I mean to pass
> "fmt" as is and then use:
>
> if (fmt[1] != 'F')
Ah, I see that it would need more changes in device_node_string().
OK, let's leave the patch as is. I am sorry for the noise.
Best Regards,
Petr
next prev parent reply other threads:[~2019-09-03 9:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 13:57 [PATCH v5 00/11] Device property improvements, add %pfw format specifier Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 01/11] software node: Get reference to parent swnode in get_parent op Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 02/11] software node: Make argument to to_software_node const Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 03/11] device property: Move fwnode_get_parent() up Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 04/11] device property: Add functions for accessing node's parents Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 05/11] device property: Add fwnode_get_name for returning the name of a node Sakari Ailus
2019-09-03 10:10 ` Heikki Krogerus
2019-09-03 11:24 ` Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 06/11] device property: Add a function to obtain a node's prefix Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 07/11] lib/vsprintf: Remove support for %pF and %pf in favour of %pS and %ps Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 08/11] lib/vsprintf: Make use of fwnode API to obtain node names and separators Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 09/11] lib/vsprintf: OF nodes are first and foremost, struct device_nodes Sakari Ailus
2019-09-03 8:52 ` Petr Mladek
2019-09-03 9:28 ` Petr Mladek [this message]
2019-09-03 11:28 ` Andy Shevchenko
2019-09-06 7:04 ` Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 10/11] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 11/11] lib/test_printf: Add tests for %pfw printk modifier Sakari Ailus
2019-09-02 16:13 ` Andy Shevchenko
2019-09-04 16:10 ` Sakari Ailus
2019-09-04 17:22 ` Andy Shevchenko
2019-09-06 7:00 ` Sakari Ailus
2019-09-03 9:38 ` [PATCH v5 00/11] Device property improvements, add %pfw format specifier Joe Perches
2019-09-04 16:04 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903092816.qutqnjba7okcauim@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).