From: Gerd Hoffmann <kraxel@redhat.com>
To: dri-devel@lists.freedesktop.org
Cc: Gerd Hoffmann <kraxel@redhat.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v3 1/7] drm: add drm_print_bits
Date: Wed, 4 Sep 2019 07:47:34 +0200 [thread overview]
Message-ID: <20190904054740.20817-2-kraxel@redhat.com> (raw)
In-Reply-To: <20190904054740.20817-1-kraxel@redhat.com>
New helper to print named bits of some value (think flags fields).
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
include/drm/drm_print.h | 3 +++
drivers/gpu/drm/drm_print.c | 33 +++++++++++++++++++++++++++++++++
2 files changed, 36 insertions(+)
diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
index 112165d3195d..12d4916254b4 100644
--- a/include/drm/drm_print.h
+++ b/include/drm/drm_print.h
@@ -89,6 +89,9 @@ __printf(2, 3)
void drm_printf(struct drm_printer *p, const char *f, ...);
void drm_puts(struct drm_printer *p, const char *str);
void drm_print_regset32(struct drm_printer *p, struct debugfs_regset32 *regset);
+void drm_print_bits(struct drm_printer *p,
+ unsigned long value, const char *bits[],
+ unsigned int from, unsigned int to);
__printf(2, 0)
/**
diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c
index ad302d71eeee..dfa27367ebb8 100644
--- a/drivers/gpu/drm/drm_print.c
+++ b/drivers/gpu/drm/drm_print.c
@@ -185,6 +185,39 @@ void drm_printf(struct drm_printer *p, const char *f, ...)
}
EXPORT_SYMBOL(drm_printf);
+/**
+ * drm_print_bits - print bits to a &drm_printer stream
+ *
+ * Print bits (in flag fields for example) in human readable form.
+ * The first name in the @bits array is for the bit indexed by @from.
+ *
+ * @p: the &drm_printer
+ * @value: field value.
+ * @bits: Array with bit names.
+ * @from: start of bit range to print (inclusive).
+ * @to: end of bit range to print (exclusive).
+ */
+void drm_print_bits(struct drm_printer *p,
+ unsigned long value, const char *bits[],
+ unsigned int from, unsigned int to)
+{
+ bool first = true;
+ unsigned int i;
+
+ for (i = from; i < to; i++) {
+ if (!(value & (1 << i)))
+ continue;
+ if (WARN_ON_ONCE(!bits[i-from]))
+ continue;
+ drm_printf(p, "%s%s", first ? "" : ",",
+ bits[i-from]);
+ first = false;
+ }
+ if (first)
+ drm_printf(p, "(none)");
+}
+EXPORT_SYMBOL(drm_print_bits);
+
void drm_dev_printk(const struct device *dev, const char *level,
const char *format, ...)
{
--
2.18.1
next parent reply other threads:[~2019-09-04 5:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190904054740.20817-1-kraxel@redhat.com>
2019-09-04 5:47 ` Gerd Hoffmann [this message]
2019-09-09 12:46 ` [PATCH v3 1/7] drm: add drm_print_bits Thomas Zimmermann
2019-09-17 12:33 ` Daniel Vetter
2019-09-18 12:24 ` Jani Nikula
2019-09-04 5:47 ` [PATCH v3 2/7] drm/ttm: add drm gem ttm helpers, starting with drm_gem_ttm_print_info() Gerd Hoffmann
2019-09-04 5:47 ` [PATCH v3 3/7] drm/vram: use drm_gem_ttm_print_info Gerd Hoffmann
2019-09-04 5:47 ` [PATCH v3 4/7] drm/vram: add vram-mm debugfs file Gerd Hoffmann
2019-09-04 5:47 ` [PATCH v3 5/7] drm/qxl: use drm_gem_object_funcs callbacks Gerd Hoffmann
2019-09-04 5:47 ` [PATCH v3 6/7] drm/qxl: use drm_gem_ttm_print_info Gerd Hoffmann
2019-09-04 5:47 ` [PATCH v3 7/7] drm/vram: fix Kconfig Gerd Hoffmann
2019-09-09 12:47 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904054740.20817-2-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).