From: Masami Hiramatsu <mhiramat@kernel.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ingo Molnar <mingo@kernel.org>, Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Randy Dunlap <rdunlap@infradead.org>, <x86@kernel.org>,
<linux-kernel@vger.kernel.org>, Borislav Petkov <bp@alien8.de>,
Josh Poimboeuf <jpoimboe@redhat.com>,
<xen-devel@lists.xenproject.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [Xen-devel] [PATCH -tip 0/2] x86: Prohibit kprobes on XEN_EMULATE_PREFIX
Date: Thu, 5 Sep 2019 10:49:37 +0900 [thread overview]
Message-ID: <20190905104937.60aa03f699a9c0fbf1b651b9@kernel.org> (raw)
In-Reply-To: <ad6431be-c86e-5ed5-518a-d1e9d1959e80@citrix.com>
On Wed, 4 Sep 2019 12:54:55 +0100
Andrew Cooper <andrew.cooper3@citrix.com> wrote:
> On 04/09/2019 12:45, Masami Hiramatsu wrote:
> > Hi,
> >
> > These patches allow x86 instruction decoder to decode
> > xen-cpuid which has XEN_EMULATE_PREFIX, and prohibit
> > kprobes to probe on it.
> >
> > Josh reported that the objtool can not decode such special
> > prefixed instructions, and I found that we also have to
> > prohibit kprobes to probe on such instruction.
> >
> > This series can be applied on -tip master branch which
> > has merged Josh's objtool/perf sharing common x86 insn
> > decoder series.
>
> The paravirtualised xen-cpuid is were you'll see it most in a regular
> kernel, but be aware that it is also used for testing purposes in other
> circumstances, and there is an equivalent KVM prefix which is used for
> KVM testing.
Good catch! I didn't notice that. Is that really same sequance or KVM uses
another sequence of instructions for KVM prefix?
>
> It might be better to generalise the decode support to "virtualisation
> escape prefix" or something slightly more generic.
Agreed, it is easy to expand it, we can switch the prefix template.
Could you tell me where I should look? I will add it.
Thank you,
>
> ~Andrew
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2019-09-05 1:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 11:45 [PATCH -tip 0/2] x86: Prohibit kprobes on XEN_EMULATE_PREFIX Masami Hiramatsu
2019-09-04 11:45 ` [PATCH -tip 1/2] x86: xen: insn: Decode XEN_EMULATE_PREFIX correctly Masami Hiramatsu
2019-09-04 11:46 ` [PATCH -tip 2/2] x86: kprobes: Prohibit probing on instruction which has Xen prefix Masami Hiramatsu
2019-09-04 11:54 ` [Xen-devel] [PATCH -tip 0/2] x86: Prohibit kprobes on XEN_EMULATE_PREFIX Andrew Cooper
2019-09-05 1:49 ` Masami Hiramatsu [this message]
2019-09-05 7:54 ` Andrew Cooper
2019-09-05 8:26 ` Peter Zijlstra
2019-09-05 8:53 ` Andrew Cooper
2019-09-05 9:26 ` Peter Zijlstra
2019-09-05 9:38 ` Andrew Cooper
2019-09-05 12:49 ` [OT] " Masami Hiramatsu
2019-09-05 11:32 ` Masami Hiramatsu
2019-09-05 13:09 ` Masami Hiramatsu
2019-09-05 13:31 ` Andrew Cooper
2019-09-05 16:12 ` Masami Hiramatsu
2019-09-04 12:02 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905104937.60aa03f699a9c0fbf1b651b9@kernel.org \
--to=mhiramat@kernel.org \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=jgross@suse.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=sstabellini@kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).