From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACAC3C43140 for ; Fri, 6 Sep 2019 19:53:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 84B6820842 for ; Fri, 6 Sep 2019 19:53:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567799632; bh=44OuvarrjJYG10b9Rp3iZi7GWWZRyB2mpVd3L0pG6yg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=xd1v8QEVPs55ijBPbVEEGMkqeXG9N3QNd97EgQu9rKuGYDGFCls9Ftr/X7L/ytObf 2kT7ighg5ugxoF0xenupdeVBprxNtmXqNkssd6dJUZpkfxiPmXT//PIlBU+rec1fzd WM+otBsuHCjW++NsHNkGYvjhkN87fshGzlkIN+gw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393925AbfIFTxw (ORCPT ); Fri, 6 Sep 2019 15:53:52 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:39280 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727004AbfIFTxv (ORCPT ); Fri, 6 Sep 2019 15:53:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ew6/0qVAdmZqdoKuB0ftq6YKxojcd2lW86roVTM6SN0=; b=HaDIZREUU4sYgn/JzFNf6E0OZ wUV/Zha1HrvFqpRxD1keIy+llfbiYbyO54VUM5f14UIi3JBAs86JzzzA99a3oqAbsCfWCa3j9D5Il Ul9csN2rC3lOfxHUkE3Nur3f17cxxoyo+NJZbmQO4IV/gC95JSVPhjhYrajx+qvRluFGsRuG3eKC+ pMchkuAKJ3LpEIkBkmTDw/+ai08Rk50M18mwfnNfCYsLlXEEJ2sGNmfiC8w2cnmml6WGjhnENKE2b 9y1CdcuQbB8qsi9RgytnVvp8W/fRwJ7e+YwUOwQi5K+8dKgAeN99bYl3lucqlkPTQ/g1iRzoJLnGQ MBaqbwQkA==; Received: from [177.159.253.249] (helo=coco.lan) by bombadil.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1i6KIn-0006S3-1u; Fri, 06 Sep 2019 19:53:49 +0000 Date: Fri, 6 Sep 2019 16:53:41 -0300 From: Mauro Carvalho Chehab To: Joe Perches Cc: Greg Kroah-Hartman , Linux Media Mailing List , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, Jonathan Corbet , Jessica Yu , Federico Vaga , Thomas Gleixner , linux-doc@vger.kernel.org, Robert Moore , Erik Schmauss , "Rafael J. Wysocki" , Len Brown , Thomas Renninger , Shuah Khan , Valentina Manea , linux-acpi@vger.kernel.org, devel@acpica.org, linux-pm@vger.kernel.org, linux-usb Subject: Re: [RFC PATCH] tools: Add SPDX license to man pages Message-ID: <20190906164959.288ab3d5@coco.lan> In-Reply-To: <1b1cfc9c8c13b58c47d1d123763c8bc412abf9d4.camel@perches.com> References: <20190905055614.7958918b@coco.lan> <88e638eb959095ab6657d295f9f8c27169569bf2.1567675272.git.mchehab+samsung@kernel.org> <20190905092703.GA30899@kroah.com> <20190905090701.37dcf75e@coco.lan> <20190906083457.7e7934ec@coco.lan> <1b1cfc9c8c13b58c47d1d123763c8bc412abf9d4.camel@perches.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, 06 Sep 2019 11:12:58 -0700 Joe Perches escreveu: > On Fri, 2019-09-06 at 08:34 -0300, Mauro Carvalho Chehab wrote: > > Warning: SPDX header for file tools/thermal/tmon/tmon.8 is at line 2 > [] > > The last one is interesting... what's the "very first line" where a > > SPDX header tag should be on a man page? > > just fyi: > > It looks like .man pages could use a comment form > using '.\"' like this example on the first line: > > $ head -5 tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.8 > .\" This page Copyright (C) 2010 - 2015 Len Brown > .\" Distributed under the GPL, Copyleft 1994. > .TH X86_ENERGY_PERF_POLICY 8 > .SH NAME > x86_energy_perf_policy \- Manage Energy vs. Performance Policy via x86 Model Specific Registers > > So maybe: > --- > tools/power/acpi/man/acpidump.8 | 1 + > tools/power/cpupower/man/cpupower-frequency-info.1 | 1 + > tools/power/cpupower/man/cpupower-frequency-set.1 | 1 + > tools/power/cpupower/man/cpupower-idle-info.1 | 1 + > tools/power/cpupower/man/cpupower-idle-set.1 | 1 + > tools/power/cpupower/man/cpupower-info.1 | 1 + > tools/power/cpupower/man/cpupower-monitor.1 | 1 + > tools/power/cpupower/man/cpupower-set.1 | 1 + > tools/power/cpupower/man/cpupower.1 | 1 + > tools/power/pm-graph/bootgraph.8 | 1 + > tools/power/pm-graph/sleepgraph.8 | 1 + > tools/power/x86/turbostat/turbostat.8 | 1 + > tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.8 | 1 + > tools/thermal/tmon/tmon.8 | 1 + > tools/usb/usbip/doc/usbip.8 | 1 + > tools/usb/usbip/doc/usbipd.8 | 1 + > 16 files changed, 16 insertions(+) Makes sense. I would also patch license-rules.txt with something like: diff --git a/Documentation/process/license-rules.rst b/Documentation/process/license-rules.rst index 5d23e3498b1c..6224421ee120 100644 --- a/Documentation/process/license-rules.rst +++ b/Documentation/process/license-rules.rst @@ -76,12 +76,13 @@ License identifier syntax The SPDX license identifier is added in form of a comment. The comment style depends on the file type:: - C source: // SPDX-License-Identifier: - C header: /* SPDX-License-Identifier: */ - ASM: /* SPDX-License-Identifier: */ - scripts: # SPDX-License-Identifier: - .rst: .. SPDX-License-Identifier: - .dts{i}: // SPDX-License-Identifier: + C source: // SPDX-License-Identifier: + C header: /* SPDX-License-Identifier: */ + ASM: /* SPDX-License-Identifier: */ + scripts: # SPDX-License-Identifier: + .rst: .. SPDX-License-Identifier: + .dts{i}: // SPDX-License-Identifier: + man pages: .\" SPDX-License-Identifier: If a specific tool cannot handle the standard comment style, then the appropriate comment mechanism which the tool accepts shall be used. This > diff --git a/tools/thermal/tmon/tmon.8 b/tools/thermal/tmon/tmon.8 > index 2f122de5841b..cffaa0d65478 100644 > --- a/tools/thermal/tmon/tmon.8 > +++ b/tools/thermal/tmon/tmon.8 > @@ -1,3 +1,4 @@ > +.\" SPDX-License-Identifier: GPL-2.0-only > .TH TMON 8 > # SPDX-License-Identifier: GPL-2.0 > .SH NAME Hmm... here, you should probably keep the same license as defined at the existing tag (GPL-2.0) and remove the comment one. Thanks, Mauro