From: Krzysztof Wilczynski <kw@linux.com>
To: Jonathan Cameron <jonathan.cameron@huawei.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: light: bh1750: Move static keyword to the front of declaration
Date: Tue, 10 Sep 2019 22:25:06 +0200 [thread overview]
Message-ID: <20190910202504.GA19939@rocinante> (raw)
In-Reply-To: <20190910143550.00000e64@huawei.com>
Hello Jonathan,
Thank you for the feedback. I really appreciate it.
[...]
> We can do that of course, but that's nothing to do with moving the static
> keyword to the front of the declaration which is what the patch claims
> to be doing.
I see your point. I am going to send a v2 that hopefully will be much
cleaner and better worded. Thank you!
Krzysztof
prev parent reply other threads:[~2019-09-10 20:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 11:31 [PATCH] iio: light: bh1750: Move static keyword to the front of declaration Krzysztof Wilczynski
2019-09-03 17:35 ` Tomasz Duszynski
2019-09-08 10:49 ` Jonathan Cameron
2019-09-08 13:52 ` Krzysztof Wilczynski
2019-09-10 13:35 ` Jonathan Cameron
2019-09-10 20:25 ` Krzysztof Wilczynski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190910202504.GA19939@rocinante \
--to=kw@linux.com \
--cc=jic23@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).