On Thu, 12 Sep 2019 06:39:50 -0500 Dan Murphy wrote: > Andreas > > On 9/11/19 12:21 PM, Andreas Kemnade wrote: > > add enable-gpios to describe HWEN pin > > > > Signed-off-by: Andreas Kemnade > > Acked-by: Daniel Thompson > > --- > > changes in v2: added example > > changes in v3: added Acked-by > > .../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > > index dc129d9a329e..1fa83feffe16 100644 > > --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > > +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > > @@ -29,6 +29,10 @@ properties: > > '#size-cells': > > const: 0 > > > > + enable-gpios: > > + description: GPIO to use to enable/disable the backlight (HWEN pin). > > + maxItems: 1 > > + > > required: > > - compatible > > - reg > > @@ -92,6 +96,7 @@ examples: > > i2c { > > #address-cells = <1>; > > #size-cells = <0>; > > + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; > > > > led-controller@38 { > > compatible = "ti,lm3630a"; > > Looks good to me > well, the enable-gpios is still at the same place as in v2. This was sent before your comments to v2 have been arrived. Regards, Andreas