From: Rob Herring <robh@kernel.org>
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
bjorn.andersson@linaro.org, edubezval@gmail.com,
agross@kernel.org, masneyb@onstation.org, swboyd@chromium.org,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Zhang Rui <rui.zhang@intel.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 07/15] dt-bindings: thermal: tsens: Convert over to a yaml schema
Date: Tue, 17 Sep 2019 14:06:19 -0500 [thread overview]
Message-ID: <20190917190619.GA9311@bogus> (raw)
In-Reply-To: <933f033298cbd7726a6c0b4b3b6cc7adc81784ba.1568185732.git.amit.kucheria@linaro.org>
On Wed, Sep 11, 2019 at 12:46:24PM +0530, Amit Kucheria wrote:
> Document interrupt support in the tsens driver by converting over to a
> YAML schema.
>
> Suggested-by: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> .../bindings/thermal/qcom-tsens.txt | 55 ------
> .../bindings/thermal/qcom-tsens.yaml | 174 ++++++++++++++++++
> MAINTAINERS | 1 +
> 3 files changed, 175 insertions(+), 55 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/thermal/qcom-tsens.txt
> create mode 100644 Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> new file mode 100644
> index 000000000000..6784766fe58f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -0,0 +1,174 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +# Copyright 2019 Linaro Ltd.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/qcom-tsens.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: QCOM SoC Temperature Sensor (TSENS)
> +
> +maintainers:
> + - Amit Kucheria <amit.kucheria@linaro.org>
> +
> +description: |
> + QCOM SoCs have TSENS IP to allow temperature measurement. There are currently
> + three distinct major versions of the IP that is supported by a single driver.
> + The IP versions are named v0.1, v1 and v2 in the driver, where v0.1 captures
> + everything before v1 when there was no versioning information.
> +
> +properties:
> + compatible:
> + oneOf:
> + - description: v0.1 of TSENS
> + items:
> + - enum:
> + - qcom,msm8916-tsens
> + - qcom,msm8974-tsens
> + - const: qcom,tsens-v0_1
> +
> + - description: v1 of TSENS
> + items:
> + - enum:
> + - qcom,qcs404-tsens
> + - const: qcom,tsens-v1
> +
> + - description: v2 of TSENS
> + items:
> + - enum:
> + - qcom,msm8996-tsens
> + - qcom,msm8998-tsens
> + - qcom,sdm845-tsens
> + - const: qcom,tsens-v2
> +
> + reg:
> + maxItems: 2
> + items:
> + - description: TM registers
> + - description: SROT registers
> +
> + nvmem-cells:
> + minItems: 1
> + maxItems: 2
> + description:
> + Reference to an nvmem node for the calibration data
> +
> + nvmem-cells-names:
This is going to require 2 items, so you need an explicit minItems and
maxItems.
> + items:
> + - enum:
> + - caldata
> + - calsel
> +
> + "#qcom,sensors":
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + - minimum: 1
> + - maximum: 16
> + description:
> + Number of sensors enabled on this platform
> +
> + "#thermal-sensor-cells":
> + const: 1
> + description:
> + Number of cells required to uniquely identify the thermal sensors. Since
> + we have multiple sensors this is set to 1
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,msm8916-tsens
> + - qcom,msm8974-tsens
> + - qcom,qcs404-tsens
> + - qcom,tsens-v0_1
> + - qcom,tsens-v1
> + then:
> + properties:
> + interrupts:
> + minItems: 1
> + maxItems: 1
These can be implicit.
> + items:
> + - description: Combined interrupt if upper or lower threshold crossed
> + interrupt-names:
> + minItems: 1
> + maxItems: 1
ditto.
> + items:
> + - const: uplow
> +
> + else:
> + properties:
> + interrupts:
> + minItems: 2
> + maxItems: 2
ditto.
> + items:
> + - description: Combined interrupt if upper or lower threshold crossed
> + - description: Interrupt if critical threshold crossed
> + interrupt-names:
> + minItems: 2
> + maxItems: 2
ditto.
> + items:
> + - const: uplow
> + - const: critical
> +
> +required:
> + - compatible
> + - reg
> + - "#qcom,sensors"
> + - interrupts
> + - interrupt-names
> + - "#thermal-sensor-cells"
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + // Example 1 (legacy: for pre v1 IP):
> + tsens1: thermal-sensor@900000 {
> + compatible = "qcom,msm8916-tsens", "qcom,tsens-v0_1";
> + reg = <0x4a9000 0x1000>, /* TM */
> + <0x4a8000 0x1000>; /* SROT */
> +
> + nvmem-cells = <&tsens_caldata>, <&tsens_calsel>;
> + nvmem-cell-names = "caldata", "calsel";
> +
> + interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "uplow";
> +
> + #qcom,sensors = <5>;
> + #thermal-sensor-cells = <1>;
> + };
> +
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + // Example 2 (for any platform containing v1 of the TSENS IP):
> + tsens2: thermal-sensor@4a9000 {
> + compatible = "qcom,qcs404-tsens", "qcom,tsens-v1";
> + reg = <0x004a9000 0x1000>, /* TM */
> + <0x004a8000 0x1000>; /* SROT */
> +
> + nvmem-cells = <&tsens_caldata>;
> + nvmem-cell-names = "calib";
> +
> + interrupts = <GIC_SPI 506 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "uplow";
> +
> + #qcom,sensors = <10>;
> + #thermal-sensor-cells = <1>;
> + };
> +
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + // Example 3 (for any platform containing v2 of the TSENS IP):
> + tsens3: thermal-sensor@c263000 {
> + compatible = "qcom,sdm845-tsens", "qcom,tsens-v2";
> + reg = <0xc263000 0x1ff>,
> + <0xc222000 0x1ff>;
> +
> + interrupts = <GIC_SPI 506 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 508 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "uplow", "critical";
> +
> + #qcom,sensors = <13>;
> + #thermal-sensor-cells = <1>;
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e7a47b5210fd..ff757a4a060c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -13360,6 +13360,7 @@ L: linux-pm@vger.kernel.org
> L: linux-arm-msm@vger.kernel.org
> S: Maintained
> F: drivers/thermal/qcom/
> +F: Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>
> QUALCOMM VENUS VIDEO ACCELERATOR DRIVER
> M: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-09-17 19:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 7:16 [PATCH v3 00/15] thermal: qcom: tsens: Add interrupt support Amit Kucheria
2019-09-11 7:16 ` [PATCH v3 01/15] drivers: thermal: tsens: Get rid of id field in tsens_sensor Amit Kucheria
2019-09-11 7:16 ` [PATCH v3 02/15] drivers: thermal: tsens: Simplify code flow in tsens_probe Amit Kucheria
2019-09-11 7:16 ` [PATCH v3 03/15] drivers: thermal: tsens: Add __func__ identifier to debug statements Amit Kucheria
2019-09-11 7:16 ` [PATCH v3 04/15] drivers: thermal: tsens: Add debugfs support Amit Kucheria
2019-09-11 7:16 ` [PATCH v3 05/15] arm: dts: msm8974: thermal: Add thermal zones for each sensor Amit Kucheria
2019-09-11 7:16 ` [PATCH v3 06/15] arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors Amit Kucheria
2019-09-11 7:16 ` [PATCH v3 07/15] dt-bindings: thermal: tsens: Convert over to a yaml schema Amit Kucheria
2019-09-17 19:06 ` Rob Herring [this message]
2019-09-20 21:42 ` Amit Kucheria
2019-09-11 7:16 ` [PATCH v3 08/15] arm64: dts: sdm845: thermal: Add interrupt support Amit Kucheria
2019-09-11 7:16 ` [PATCH v3 09/15] arm64: dts: msm8996: " Amit Kucheria
2019-09-11 7:16 ` [PATCH v3 10/15] arm64: dts: msm8998: " Amit Kucheria
2019-09-11 7:16 ` [PATCH v3 11/15] arm64: dts: qcs404: " Amit Kucheria
2019-09-11 7:16 ` [PATCH v3 12/15] arm: dts: msm8974: " Amit Kucheria
2019-09-11 7:16 ` [PATCH v3 13/15] arm64: dts: msm8916: " Amit Kucheria
2019-09-11 7:16 ` [PATCH v3 14/15] drivers: thermal: tsens: Create function to return sign-extended temperature Amit Kucheria
2019-09-11 7:16 ` [PATCH v3 15/15] drivers: thermal: tsens: Add interrupt support Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190917190619.GA9311@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masneyb@onstation.org \
--cc=rui.zhang@intel.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).