linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Pawel Dembicki <paweldembicki@gmail.com>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] net: dsa: vsc73xx: Return an error code as a constant in vsc73xx_platform_probe()
Date: Fri, 20 Sep 2019 17:08:29 +0200	[thread overview]
Message-ID: <20190920150829.GF3530@lunn.ch> (raw)
In-Reply-To: <738c12c8-f51e-d2e5-f31e-7f726cf6325d@web.de>

On Fri, Sep 20, 2019 at 04:30:13PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 20 Sep 2019 16:07:07 +0200
> 
> * Return an error code without storing it in an intermediate variable.
> 
> * Delete the local variable “ret” which became unnecessary
>   with this refactoring.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew


  reply	other threads:[~2019-09-20 15:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-20 14:25 [PATCH 0/2] net: dsa: vsc73xx: Adjustments for vsc73xx_platform_probe() Markus Elfring
2019-09-20 14:28 ` [PATCH 1/2] net: dsa: vsc73xx: Use devm_platform_ioremap_resource() in vsc73xx_platform_probe() Markus Elfring
2019-09-20 15:08   ` Andrew Lunn
2019-09-20 14:30 ` [PATCH 2/2] net: dsa: vsc73xx: Return an error code as a constant " Markus Elfring
2019-09-20 15:08   ` Andrew Lunn [this message]
2019-09-20 15:09 ` [PATCH 0/2] net: dsa: vsc73xx: Adjustments for vsc73xx_platform_probe() Andrew Lunn
2019-09-20 15:30   ` [0/2] " Markus Elfring
2019-09-20 16:36     ` Florian Fainelli
2019-09-20 22:12       ` Jakub Kicinski
2019-09-21  7:12         ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190920150829.GF3530@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Markus.Elfring@web.de \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paweldembicki@gmail.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).