From: Andrew Morton <akpm@linux-foundation.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Qian Cai <cai@lca.pw>, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mm/kmemleak: record the current memory pool size
Date: Fri, 20 Sep 2019 16:22:21 -0700 [thread overview]
Message-ID: <20190920162221.51a800630561489a7e62821a@linux-foundation.org> (raw)
In-Reply-To: <20190815100215.GB9352@arrakis.emea.arm.com>
On Thu, 15 Aug 2019 11:02:16 +0100 Catalin Marinas <catalin.marinas@arm.com> wrote:
> On Wed, Aug 14, 2019 at 03:07:11PM -0400, Qian Cai wrote:
> > The only way to obtain the current memory pool size for a running kernel
> > is to check back the kernel config file which is inconvenient. Record it
> > in the kernel messages.
> >
> > Signed-off-by: Qian Cai <cai@lca.pw>
> > ---
> > mm/kmemleak.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/mm/kmemleak.c b/mm/kmemleak.c
> > index b8bbe9ac5472..1f74f8bcb4eb 100644
> > --- a/mm/kmemleak.c
> > +++ b/mm/kmemleak.c
> > @@ -1967,7 +1967,8 @@ static int __init kmemleak_late_init(void)
> > mutex_unlock(&scan_mutex);
> > }
> >
> > - pr_info("Kernel memory leak detector initialized\n");
> > + pr_info("Kernel memory leak detector initialized (mem pool size: %d)\n",
> > + mem_pool_free_count);
>
> I wouldn't actually call it the "memory pool size" as I see the size as
> a constant set at config time. What about "memory pool available"?
>
> (even this one is not entirely accurate since we have a
> mem_pool_free_list but I expect such list not to have too many elements
> at the late_initcall time)
>
> If you change the printed string:
>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
--- a/mm/kmemleak.c~mm-kmemleak-record-the-current-memory-pool-size-fix
+++ a/mm/kmemleak.c
@@ -1967,7 +1967,7 @@ static int __init kmemleak_late_init(voi
mutex_unlock(&scan_mutex);
}
- pr_info("Kernel memory leak detector initialized (mem pool size: %d)\n",
+ pr_info("Kernel memory leak detector initialized (mem pool available: %d)\n",
mem_pool_free_count);
return 0;
_
prev parent reply other threads:[~2019-09-20 23:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 19:07 [PATCH -next] mm/kmemleak: record the current memory pool size Qian Cai
2019-08-15 10:02 ` Catalin Marinas
2019-09-20 23:22 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920162221.51a800630561489a7e62821a@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).