From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F714C4360C for ; Fri, 27 Sep 2019 13:41:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D571B217D9 for ; Fri, 27 Sep 2019 13:41:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Fy5j/qmg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727635AbfI0NlP (ORCPT ); Fri, 27 Sep 2019 09:41:15 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:53477 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726540AbfI0NlO (ORCPT ); Fri, 27 Sep 2019 09:41:14 -0400 Received: by mail-wm1-f65.google.com with SMTP id i16so6667634wmd.3 for ; Fri, 27 Sep 2019 06:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hgnZlYVxe7nccl/AMGN96sUvuUJBPHkcwyTYZiuZshQ=; b=Fy5j/qmgSJyd5tLd2E0Y0I0s9aR2rJOX18jYABdElAIytSroY2DHEGWmW/j4lQl/7v BV8qyTbP3eT2rDYHKIYH4rUw+7ynj1SZW+f2+c/PtW+B2420sM6AvwYT80Q8f7NbUXSI oss4WK0y9hAGXrGtV5kjOpIDh675S8dOWTH5k/5MiPYMVlIuppQbCfdInRGDwaYTfvPb xUINeYpDP1TqXNgVLsAMW6pIX/k23rdz+Uf6/3bciD7dmL0P0jzF/Ce+KhzoU5vARPRO Ri/fiVoygkeAXTmR/32zEyHI8Dh07iF5haiSg0bMWx3I4uqyNZtkCsnEFihizD8NizDY jaoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hgnZlYVxe7nccl/AMGN96sUvuUJBPHkcwyTYZiuZshQ=; b=pQTVH12XL6hCphMVK4s88nfzsfydNqXEa40Jo10m7TEQubedtYJvODbZEMvHXxMQSL fv3+ZxK0WM2FY9z/8Y3E4Ha6r2LQgjX1tcHsGop0EUFFDONBHqv1qHQbpXGpeoGHjx/+ jIXSEHfMMUKaMiQdETqPPrlz/vAGwyaFbyz+4F+qdOeu0mADVELuCGgXj3NbD4YjPMy6 mxaicvDkzikR6Ap6rYjprhmfYT8hfaNyjzW/uExXHhaVeebCj1qlLLttH6R3PSDx2bYE A6Y7b4nzDTb9WZG2aX/TNh6IXXY0aYHrzg2X/eQOQBNlLlCKuIEqShJsXOU1ZQB+jyuG YSWQ== X-Gm-Message-State: APjAAAWTUOLV0p22O3VTOeT9q5e8JgrBCi2hocHdBknVnzw0tP2fURq7 5UDQa3eARMIx8O79fYWp6mebvQ== X-Google-Smtp-Source: APXvYqzZfdxZiASgKEvFOVVutuQt3UJ3zjs7fZoAAlxXaz5VadUxbevICIzD6S4z7DdpOnCOlJczLQ== X-Received: by 2002:a1c:a8cb:: with SMTP id r194mr4464907wme.156.1569591672626; Fri, 27 Sep 2019 06:41:12 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:e8f7:125b:61e9:733d]) by smtp.gmail.com with ESMTPSA id t18sm6535777wmi.44.2019.09.27.06.41.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Sep 2019 06:41:11 -0700 (PDT) Date: Fri, 27 Sep 2019 14:41:08 +0100 From: Matthias Maennich To: Masahiro Yamada Cc: Jessica Yu , Greg Kroah-Hartman , Joel Fernandes , Martijn Coenen , Will Deacon , Michal Marek , Will Deacon , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/7] module: various bug-fixes and clean-ups for module namespace Message-ID: <20190927134108.GC187147@google.com> References: <20190927093603.9140-1-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190927093603.9140-1-yamada.masahiro@socionext.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 27, 2019 at 06:35:56PM +0900, Masahiro Yamada wrote: > >I was hit by some problems caused by the module namespace feature >that was merged recently. At least, the breakage of >external module builds is a fatal one. I just took a look at the code >closer, and I noticed some more issues and improvements. > >I hope these patches are mostly OK. >The 4th patch might have room for argument since it is a trade-off >of "cleaner implermentation" vs "code size". > Thanks Masahiro for taking the time to improve the implementation of the symbol namespaces. These are all good points that you addressed! For [04/07], I can work on this if you do not mind. Cheers, Matthias > >Masahiro Yamada (7): > modpost: fix broken sym->namespace for external module builds > module: swap the order of symbol.namespace > module: rename __kstrtab_ns_* to __kstrtabns_* to avoid symbol > conflict > module: avoid code duplication in include/linux/export.h > kbuild: fix build error of 'make nsdeps' in clean tree > nsdeps: fix hashbang of scripts/nsdeps > nsdeps: make generated patches independent of locale > > Makefile | 2 +- > include/linux/export.h | 104 ++++++++++++++--------------------------- > kernel/module.c | 2 +- > scripts/mod/modpost.c | 20 ++++---- > scripts/nsdeps | 4 +- > 5 files changed, 47 insertions(+), 85 deletions(-) > >-- >2.17.1 >