From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Anson Huang <Anson.Huang@nxp.com>,
Dong Aisheng <aisheng.dong@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Sasha Levin <sashal@kernel.org>,
linux-rtc@vger.kernel.org
Subject: [PATCH AUTOSEL 4.19 14/33] rtc: snvs: fix possible race condition
Date: Sun, 29 Sep 2019 13:34:02 -0400 [thread overview]
Message-ID: <20190929173424.9361-14-sashal@kernel.org> (raw)
In-Reply-To: <20190929173424.9361-1-sashal@kernel.org>
From: Anson Huang <Anson.Huang@nxp.com>
[ Upstream commit 6fd4fe9b496d9ba3382992ff4fde3871d1b6f63d ]
The RTC IRQ is requested before the struct rtc_device is allocated,
this may lead to a NULL pointer dereference in IRQ handler.
To fix this issue, allocating the rtc_device struct before requesting
the RTC IRQ using devm_rtc_allocate_device, and use rtc_register_device
to register the RTC device.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Link: https://lore.kernel.org/r/20190716071858.36750-1-Anson.Huang@nxp.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/rtc/rtc-snvs.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/rtc/rtc-snvs.c b/drivers/rtc/rtc-snvs.c
index b2483a749ac45..3cf011e120530 100644
--- a/drivers/rtc/rtc-snvs.c
+++ b/drivers/rtc/rtc-snvs.c
@@ -273,6 +273,10 @@ static int snvs_rtc_probe(struct platform_device *pdev)
if (!data)
return -ENOMEM;
+ data->rtc = devm_rtc_allocate_device(&pdev->dev);
+ if (IS_ERR(data->rtc))
+ return PTR_ERR(data->rtc);
+
data->regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "regmap");
if (IS_ERR(data->regmap)) {
@@ -335,10 +339,9 @@ static int snvs_rtc_probe(struct platform_device *pdev)
goto error_rtc_device_register;
}
- data->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,
- &snvs_rtc_ops, THIS_MODULE);
- if (IS_ERR(data->rtc)) {
- ret = PTR_ERR(data->rtc);
+ data->rtc->ops = &snvs_rtc_ops;
+ ret = rtc_register_device(data->rtc);
+ if (ret) {
dev_err(&pdev->dev, "failed to register rtc: %d\n", ret);
goto error_rtc_device_register;
}
--
2.20.1
next prev parent reply other threads:[~2019-09-29 17:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-29 17:33 [PATCH AUTOSEL 4.19 01/33] MIPS: Ingenic: Disable broken BTB lookup optimization Sasha Levin
2019-09-29 17:33 ` [PATCH AUTOSEL 4.19 02/33] clk: jz4740: Add TCU clock Sasha Levin
2019-09-29 17:33 ` [PATCH AUTOSEL 4.19 03/33] MIPS: tlbex: Explicitly cast _PAGE_NO_EXEC to a boolean Sasha Levin
2019-09-29 17:33 ` [PATCH AUTOSEL 4.19 04/33] i2c-cht-wc: Fix lockdep warning Sasha Levin
2019-09-29 17:33 ` [PATCH AUTOSEL 4.19 05/33] mfd: intel-lpss: Remove D3cold delay Sasha Levin
2019-09-29 17:33 ` [PATCH AUTOSEL 4.19 06/33] PCI: tegra: Fix OF node reference leak Sasha Levin
2019-09-29 17:33 ` [PATCH AUTOSEL 4.19 07/33] HID: wacom: Fix several minor compiler warnings Sasha Levin
2019-09-29 17:33 ` [PATCH AUTOSEL 4.19 08/33] livepatch: Nullify obj->mod in klp_module_coming()'s error path Sasha Levin
2019-09-29 17:33 ` [PATCH AUTOSEL 4.19 09/33] ARM: 8898/1: mm: Don't treat faults reported from cache maintenance as writes Sasha Levin
2019-09-29 17:33 ` [PATCH AUTOSEL 4.19 10/33] soundwire: intel: fix channel number reported by hardware Sasha Levin
2019-09-29 17:33 ` [PATCH AUTOSEL 4.19 11/33] ARM: 8875/1: Kconfig: default to AEABI w/ Clang Sasha Levin
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 12/33] MIPS: lantiq: update the clock alias' for the mainline PCIe PHY driver Sasha Levin
2019-09-29 17:40 ` Martin Blumenstingl
2019-10-05 23:01 ` Sasha Levin
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 13/33] firmware: bcm47xx_nvram: Correct size_t printf format Sasha Levin
2019-09-29 17:34 ` Sasha Levin [this message]
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 15/33] rtc: pcf85363/pcf85263: fix regmap error in set_time Sasha Levin
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 16/33] HID: apple: Fix stuck function keys when using FN Sasha Levin
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 17/33] PCI: rockchip: Propagate errors for optional regulators Sasha Levin
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 18/33] PCI: histb: " Sasha Levin
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 19/33] PCI: imx6: " Sasha Levin
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 20/33] PCI: exynos: Propagate errors for optional PHYs Sasha Levin
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 21/33] security: smack: Fix possible null-pointer dereferences in smack_socket_sock_rcv_skb() Sasha Levin
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 22/33] ARM: 8903/1: ensure that usable memory in bank 0 starts from a PMD-aligned address Sasha Levin
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 23/33] fat: work around race with userspace's read via blockdev while mounting Sasha Levin
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 24/33] pktcdvd: remove warning on attempting to register non-passthrough dev Sasha Levin
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 25/33] hypfs: Fix error number left in struct pointer member Sasha Levin
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 26/33] crypto: hisilicon - Fix double free in sec_free_hw_sgl() Sasha Levin
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 27/33] kbuild: clean compressed initramfs image Sasha Levin
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 28/33] ocfs2: wait for recovering done after direct unlock request Sasha Levin
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 29/33] kmemleak: increase DEBUG_KMEMLEAK_EARLY_LOG_SIZE default to 16K Sasha Levin
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 30/33] arm64: consider stack randomization for mmap base only when necessary Sasha Levin
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 31/33] mips: properly account for stack randomization and stack guard gap Sasha Levin
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 32/33] arm: " Sasha Levin
2019-09-29 17:34 ` [PATCH AUTOSEL 4.19 33/33] arm: use STACK_TOP when computing mmap base address Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190929173424.9361-14-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).