From: Andreas Kemnade <andreas@kemnade.info>
To: Marco Felsch <m.felsch@pengutronix.de>, festevam@gmail.com
Cc: Rob Herring <robh@kernel.org>,
mark.rutland@arm.com, marex@denx.de, devicetree@vger.kernel.org,
andrew.smirnov@gmail.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, angus@akkea.ca,
linux-kernel@vger.kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de, manivannan.sadhasivam@linaro.org,
j.neuschaefer@gmx.net,
Discussions about the Letux Kernel
<letux-kernel@openphoenux.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/3] ARM: dts: add Netronix E60K02 board common file
Date: Sun, 13 Oct 2019 17:56:44 +0200 [thread overview]
Message-ID: <20191013175644.4fc264d0@kemnade.info> (raw)
In-Reply-To: <20191011165633.5ty3yux4ljrcycux@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 4019 bytes --]
On Fri, 11 Oct 2019 18:56:33 +0200
Marco Felsch <m.felsch@pengutronix.de> wrote:
> On 19-10-11 18:19, Andreas Kemnade wrote:
> > On Fri, 11 Oct 2019 17:22:14 +0200
> > Marco Felsch <m.felsch@pengutronix.de> wrote:
> >
> > > On 19-10-11 17:05, Andreas Kemnade wrote:
> > > > On Fri, 11 Oct 2019 09:29:27 -0500
> > > > Rob Herring <robh@kernel.org> wrote:
> > > >
> > > > > On Fri, Oct 11, 2019 at 09:41:48AM +0200, Andreas Kemnade wrote:
> > > > > > On Fri, 11 Oct 2019 08:56:09 +0200
> > > > > > Marco Felsch <m.felsch@pengutronix.de> wrote:
> > > > > >
> > > > > > > Hi Andreas,
> > > > > > >
> > > > > > > On 19-10-10 21:23, Andreas Kemnade wrote:
> > > > > > > > The Netronix board E60K02 can be found some several Ebook-Readers,
> > > > > > > > at least the Kobo Clara HD and the Tolino Shine 3. The board
> > > > > > > > is equipped with different SoCs requiring different pinmuxes.
> > > > > > > >
> > > > > > > > For now the following peripherals are included:
> > > > > > > > - LED
> > > > > > > > - Power Key
> > > > > > > > - Cover (gpio via hall sensor)
> > > > > > > > - RC5T619 PMIC (the kernel misses support for rtc and charger
> > > > > > > > subdevices).
> > > > > > > > - Backlight via lm3630a
> > > > > > > > - Wifi sdio chip detection (mmc-powerseq and stuff)
> > > > > > > >
> > > > > > > > It is based on vendor kernel but heavily reworked due to many
> > > > > > > > changed bindings.
> > > > > > > >
> > > > > > > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > > > > > > > ---
> > > > > > > > Changes in v3:
> > > > > > > > - better led name
> > > > > > > > - correct memory size
> > > > > > > > - comments about missing devices
> > > > > > > >
> > > > > > > > Changes in v2:
> > > > > > > > - reordered, was 1/3
> > > > > > > > - moved pinmuxes to their actual users, not the parents
> > > > > > > > of them
> > > > > > > > - removed some already-disabled stuff
> > > > > > > > - minor cleanups
> > > > > > >
> > > > > > > You won't change the muxing, so a this dtsi can be self contained?
> > > > > > >
> > > > > > So you want me to put a big
> > > > > > #if defined(MX6SLL)
> > > > >
> > > > > Not sure what the comment meant, but no, don't do this. C defines in dts
> > > > > files are for symbolic names for numbers and assembling bitfields and
> > > > > that's it.
> > > >
> > > > yes, that is also my opinion. For now, there is only one user
> > > > of this .dtsi, but I have another one in preparation. That is the
> > > > reason for splitting things between .dts and .dtsi to avoid such ugly
> > > > ifdefs
> > >
> > > Then IMHO the pnictrl-* entries shouldn't appear in the dsti.
> > >
> > hmm, maybe now I understand your idea:
> > You do not want only to have
> >
> > pinctrl_lm3630a_bl_gpio: lm3630a_bl_gpio_grp {
> > fsl,pins = <
> > MX6SLL_PAD_EPDC_PWR_CTRL3__GPIO2_IO10 0x10059 /* HWEN */
> > >;
> > };
> > in dts, but also do not have these in .dtsi:
> >
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_lm3630a_bl_gpio>;
> >
> > and instead have in dts:
> > &lm3630a {
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_lm3630a_bl_gpio>;
> >
> > };
> >
> >
> > just to make sure I get it right before doing the restructuring work. That way of structuring things did not come to my mind, but then the .dtsi is self-contained.
>
> That is what I mean but wait for Shawn's comments. It's just my opinion
> that .dtsi and .dts files should be self-contained.
for files like the imx6sll.dtsi, I would clearly agree, here it might
hide errors like missing pinmuxes in the dts, so it is not so clear.
But if there is is consensus about .dtsi being self-contained I will not
refuse to restructurize my work.
Regards,
Andreas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-10-14 6:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 19:23 [PATCH v3 0/3] dts: ARM: add Kobo Clara HD eBook reader Andreas Kemnade
2019-10-10 19:23 ` [PATCH v3 1/3] dt-bindings: arm: fsl: add compatible string for Kobo Clara HD Andreas Kemnade
2019-10-11 14:29 ` Rob Herring
2019-10-10 19:23 ` [PATCH v3 2/3] ARM: dts: add Netronix E60K02 board common file Andreas Kemnade
2019-10-11 6:56 ` Marco Felsch
2019-10-11 7:41 ` Andreas Kemnade
2019-10-11 14:29 ` Rob Herring
2019-10-11 15:05 ` Andreas Kemnade
2019-10-11 15:22 ` Marco Felsch
2019-10-11 16:19 ` Andreas Kemnade
2019-10-11 16:56 ` Marco Felsch
2019-10-13 15:56 ` Andreas Kemnade [this message]
2019-10-25 9:14 ` Shawn Guo
2019-10-25 10:09 ` Andreas Kemnade
2019-10-25 13:06 ` Shawn Guo
2019-10-10 19:23 ` [PATCH v3 3/3] ARM: dts: imx: add devicetree for Kobo Clara HD Andreas Kemnade
2019-10-25 13:46 ` Shawn Guo
2019-10-25 18:07 ` Andreas Kemnade
2019-10-26 8:12 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191013175644.4fc264d0@kemnade.info \
--to=andreas@kemnade.info \
--cc=andrew.smirnov@gmail.com \
--cc=angus@akkea.ca \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=j.neuschaefer@gmx.net \
--cc=kernel@pengutronix.de \
--cc=letux-kernel@openphoenux.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marex@denx.de \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).