From: <Narendra.K@dell.com>
To: <geert@linux-m68k.org>
Cc: <ard.biesheuvel@linaro.org>, <linux-efi@vger.kernel.org>,
<Mario.Limonciello@dell.com>, <tglx@linutronix.de>,
<linux-kernel@vger.kernel.org>, <james.morse@arm.com>,
<mingo@kernel.org>
Subject: Re: [PATCH] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y
Date: Sun, 13 Oct 2019 19:08:24 +0000 [thread overview]
Message-ID: <20191013190813.GA2742@localhost.localdomain> (raw)
In-Reply-To: <CAMuHMdWALc_hneRaiwQbMWUXe=LnVqU7dkkWibV0cqb8Gc5e0g@mail.gmail.com>
Geert,
On Sat, Oct 12, 2019 at 07:04:15PM +0200, Geert Uytterhoeven wrote:
[...]
> > From the discussion in [1] and [2](pasted a part of it above), my understanding
> > of the issue you reported is that 'make oldconfig' asks the user a question for arm64
> > though the EFI_RCI2_TABLE is not relevant for arm64. From the tests,
> > it seemed like adding "depends on X86 || COMPILE_TEST" does not fix the
> > issue, splitting bool into bool + prompt fixes it.
> >
> > Please let me know if I am missing any detail in the issue you reported.
>
> Adding a "depends on X86 || COMPILE_TEST" should fix the issue, as
> X86 is never set on arm64, nor on any other architecture than X86.
> If COMPILE_TEST=y, it's normal expected behavior to show the question.
Ok. Thank you for the details.
>
> > With the way EFI_RCI2_TABLE is currently defined, my understanding is
> > that 'make oldconfig' does not set the EFI_RCI2_TABLE to 'y' by default
> > on arm64, but it asks the user the question. User has to say 'y' if he
> > wants it to be set to 'y', else by default 'n' is set. This behavior is
> > as expected.
>
> If the option doesn't make sense on arm64 (more broadly: on non-X86),
> it should depend on X86 || COMPILE_TEST, to avoid spamming the user
> with (zillions of) options that do not matter for his platform.
Ok.
>
> > > One common approach is to let the Kconfig symbol for the platform (not for
> > > all of X86!) select EFI_RCI2_TABLE.
> > > That way it will be enabled automatically when needed.
> >
> > We did not intend to enable EFI_RCI2_TABLE option by default even on all
> > X86 systems from the begining. As a result, we chose to set it to 'n' by
> > default and added the guidance in 'help' section to say 'y' for Dell EMC
> > PowerEdge systems.
>
> Good.
>
> >> > Another approach is to not force the option on, but guide the user towards
> > > enabling it, by adding "default y if <platform_symbol>".
> >
> > As mentioned above, we want to keep the default to n.
>
> OK.
>
> > > Without the "|| COMPILE_TEST", you cannot enable compile-testing of
> > > the driver on non-x86 platforms with EFI.
> >
> > Ok. We could keep the check. Could we make it independent of platforms
> > by adding 'defbool y if COMPILE_TEST' ?
>
> Please don't do that, as it with always enable the driver if COMPILE_TEST=y,
> without providing a way to opt-out for the user.
Ok.
Thank you for the inputs.
I have submitted the patch with 'depends on X86 || COMPILE_TEST' added to
the Kconfig file. Could you please help test it on your platform/system to
verify if the patch works as expected ?
--
With regards,
Narendra K
prev parent reply other threads:[~2019-10-13 19:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 19:44 [PATCH] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y Narendra.K
2019-10-09 14:11 ` Ard Biesheuvel
2019-10-10 17:47 ` Narendra.K
2019-10-10 18:50 ` Geert Uytterhoeven
2019-10-11 9:43 ` Narendra.K
2019-10-11 10:01 ` Geert Uytterhoeven
2019-10-11 12:55 ` Narendra.K
2019-10-12 17:04 ` Geert Uytterhoeven
2019-10-13 19:08 ` Narendra.K [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191013190813.GA2742@localhost.localdomain \
--to=narendra.k@dell.com \
--cc=Mario.Limonciello@dell.com \
--cc=ard.biesheuvel@linaro.org \
--cc=geert@linux-m68k.org \
--cc=james.morse@arm.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).