From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] perf test: Report failure for mmap events
Date: Mon, 14 Oct 2019 11:09:21 -0300 [thread overview]
Message-ID: <20191014140921.GC19627@kernel.org> (raw)
In-Reply-To: <20191011091942.29841-1-leo.yan@linaro.org>
Em Fri, Oct 11, 2019 at 05:19:41PM +0800, Leo Yan escreveu:
> When fail to mmap events in task exit case, it misses to set 'err' to
> -1; thus the testing will not report failure for it.
>
> This patch sets 'err' to -1 when fails to mmap events, thus Perf tool
> can report correct result.
Thanks, applied and added:
Fixes: d723a55096b8 ("perf test: Add test case for checking number of EXIT events")
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> tools/perf/tests/task-exit.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/tests/task-exit.c b/tools/perf/tests/task-exit.c
> index bce3a4cb4c89..ca0a6ca43b13 100644
> --- a/tools/perf/tests/task-exit.c
> +++ b/tools/perf/tests/task-exit.c
> @@ -110,6 +110,7 @@ int test__task_exit(struct test *test __maybe_unused, int subtest __maybe_unused
> if (evlist__mmap(evlist, 128) < 0) {
> pr_debug("failed to mmap events: %d (%s)\n", errno,
> str_error_r(errno, sbuf, sizeof(sbuf)));
> + err = -1;
> goto out_delete_evlist;
> }
>
> --
> 2.17.1
--
- Arnaldo
next prev parent reply other threads:[~2019-10-14 14:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 9:19 [PATCH v1 1/2] perf test: Report failure for mmap events Leo Yan
2019-10-11 9:19 ` [PATCH v1 2/2] perf test: Avoid infinite loop for task exit case Leo Yan
2019-10-11 14:38 ` Arnaldo Carvalho de Melo
2019-10-14 14:11 ` Arnaldo Carvalho de Melo
2019-10-15 3:20 ` Leo Yan
2019-10-21 23:19 ` [tip: perf/core] " tip-bot2 for Leo Yan
2019-10-14 14:09 ` Arnaldo Carvalho de Melo [this message]
2019-10-21 23:19 ` [tip: perf/core] perf test: Report failure for mmap events tip-bot2 for Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014140921.GC19627@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).