From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v5 04/14] software node: mark internal macros with double underscores
Date: Tue, 15 Oct 2019 15:03:50 +0300 [thread overview]
Message-ID: <20191015120350.GF32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191011230721.206646-5-dmitry.torokhov@gmail.com>
On Fri, Oct 11, 2019 at 04:07:11PM -0700, Dmitry Torokhov wrote:
> Let's mark PROPERTY_ENTRY_* macros that are internal with double leading
> underscores so users are not tempted to use them.
We may undef them at the end of file, right?
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> include/linux/property.h | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/include/linux/property.h b/include/linux/property.h
> index f89b930ca4b7..2c9d4d209296 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -256,7 +256,7 @@ struct property_entry {
> * and structs.
> */
>
> -#define PROPERTY_ENTRY_ARRAY_LEN(_name_, _type_, _Type_, _val_, _len_) \
> +#define __PROPERTY_ENTRY_ARRAY_LEN(_name_, _type_, _Type_, _val_, _len_)\
> (struct property_entry) { \
> .name = _name_, \
> .length = (_len_) * sizeof(_type_), \
> @@ -266,13 +266,13 @@ struct property_entry {
> }
>
> #define PROPERTY_ENTRY_U8_ARRAY_LEN(_name_, _val_, _len_) \
> - PROPERTY_ENTRY_ARRAY_LEN(_name_, u8, U8, _val_, _len_)
> + __PROPERTY_ENTRY_ARRAY_LEN(_name_, u8, U8, _val_, _len_)
> #define PROPERTY_ENTRY_U16_ARRAY_LEN(_name_, _val_, _len_) \
> - PROPERTY_ENTRY_ARRAY_LEN(_name_, u16, U16, _val_, _len_)
> + __PROPERTY_ENTRY_ARRAY_LEN(_name_, u16, U16, _val_, _len_)
> #define PROPERTY_ENTRY_U32_ARRAY_LEN(_name_, _val_, _len_) \
> - PROPERTY_ENTRY_ARRAY_LEN(_name_, u32, U32, _val_, _len_)
> + __PROPERTY_ENTRY_ARRAY_LEN(_name_, u32, U32, _val_, _len_)
> #define PROPERTY_ENTRY_U64_ARRAY_LEN(_name_, _val_, _len_) \
> - PROPERTY_ENTRY_ARRAY_LEN(_name_, u64, U64, _val_, _len_)
> + __PROPERTY_ENTRY_ARRAY_LEN(_name_, u64, U64, _val_, _len_)
>
> #define PROPERTY_ENTRY_STRING_ARRAY_LEN(_name_, _val_, _len_) \
> (struct property_entry) { \
> @@ -294,7 +294,7 @@ struct property_entry {
> #define PROPERTY_ENTRY_STRING_ARRAY(_name_, _val_) \
> PROPERTY_ENTRY_STRING_ARRAY_LEN(_name_, _val_, ARRAY_SIZE(_val_))
>
> -#define PROPERTY_ENTRY_INTEGER(_name_, _type_, _Type_, _val_) \
> +#define __PROPERTY_ENTRY_INTEGER(_name_, _type_, _Type_, _val_) \
> (struct property_entry) { \
> .name = _name_, \
> .length = sizeof(_type_), \
> @@ -303,13 +303,13 @@ struct property_entry {
> }
>
> #define PROPERTY_ENTRY_U8(_name_, _val_) \
> - PROPERTY_ENTRY_INTEGER(_name_, u8, U8, _val_)
> + __PROPERTY_ENTRY_INTEGER(_name_, u8, U8, _val_)
> #define PROPERTY_ENTRY_U16(_name_, _val_) \
> - PROPERTY_ENTRY_INTEGER(_name_, u16, U16, _val_)
> + __PROPERTY_ENTRY_INTEGER(_name_, u16, U16, _val_)
> #define PROPERTY_ENTRY_U32(_name_, _val_) \
> - PROPERTY_ENTRY_INTEGER(_name_, u32, U32, _val_)
> + __PROPERTY_ENTRY_INTEGER(_name_, u32, U32, _val_)
> #define PROPERTY_ENTRY_U64(_name_, _val_) \
> - PROPERTY_ENTRY_INTEGER(_name_, u64, U64, _val_)
> + __PROPERTY_ENTRY_INTEGER(_name_, u64, U64, _val_)
>
> #define PROPERTY_ENTRY_STRING(_name_, _val_) \
> (struct property_entry) { \
> --
> 2.23.0.700.g56cf767bdb-goog
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-10-15 12:03 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 23:07 [PATCH v5 00/14] software node: add support for reference properties Dmitry Torokhov
2019-10-11 23:07 ` [PATCH v5 01/14] software node: remove DEV_PROP_MAX Dmitry Torokhov
2019-10-11 23:07 ` [PATCH v5 02/14] software node: introduce PROPERTY_ENTRY_ARRAY_XXX_LEN() Dmitry Torokhov
2019-10-15 12:02 ` Andy Shevchenko
2019-10-11 23:07 ` [PATCH v5 03/14] efi/apple-properties: use PROPERTY_ENTRY_U8_ARRAY_LEN Dmitry Torokhov
2019-10-15 12:01 ` Andy Shevchenko
2019-10-15 18:02 ` Dmitry Torokhov
2019-10-11 23:07 ` [PATCH v5 04/14] software node: mark internal macros with double underscores Dmitry Torokhov
2019-10-15 12:03 ` Andy Shevchenko [this message]
2019-10-15 18:09 ` Dmitry Torokhov
2019-10-11 23:07 ` [PATCH v5 05/14] software node: clean up property_copy_string_array() Dmitry Torokhov
2019-10-15 12:07 ` Andy Shevchenko
2019-10-15 18:12 ` Dmitry Torokhov
2019-10-16 7:53 ` Andy Shevchenko
2019-10-16 17:00 ` Dmitry Torokhov
2019-10-17 7:02 ` Andy Shevchenko
2019-10-11 23:07 ` [PATCH v5 06/14] software node: get rid of property_set_pointer() Dmitry Torokhov
2019-10-15 12:09 ` Andy Shevchenko
2019-10-15 18:14 ` Dmitry Torokhov
2019-10-11 23:07 ` [PATCH v5 07/14] software node: remove property_entry_read_uNN_array functions Dmitry Torokhov
2019-10-11 23:07 ` [PATCH v5 08/14] software node: unify PROPERTY_ENTRY_XXX macros Dmitry Torokhov
2019-10-11 23:07 ` [PATCH v5 09/14] software node: simplify property_entry_read_string_array() Dmitry Torokhov
2019-10-11 23:07 ` [PATCH v5 10/14] software node: rename is_array to is_inline Dmitry Torokhov
2019-10-14 7:37 ` Andy Shevchenko
2019-10-15 18:22 ` Dmitry Torokhov
2019-10-16 7:59 ` Andy Shevchenko
2019-10-16 16:54 ` Dmitry Torokhov
2019-10-17 7:16 ` Andy Shevchenko
2019-10-17 16:00 ` Dmitry Torokhov
2019-10-17 16:02 ` Dmitry Torokhov
2019-10-11 23:07 ` [PATCH v5 11/14] software node: move small properties inline when copying Dmitry Torokhov
2019-10-15 12:20 ` Andy Shevchenko
2019-10-15 18:25 ` Dmitry Torokhov
2019-10-16 7:48 ` Andy Shevchenko
2019-10-16 16:01 ` Dmitry Torokhov
2019-10-16 16:18 ` Andy Shevchenko
2019-10-16 16:23 ` Andy Shevchenko
2019-10-16 16:44 ` Dmitry Torokhov
2019-10-17 16:04 ` Dmitry Torokhov
2019-10-11 23:07 ` [PATCH v5 12/14] software node: implement reference properties Dmitry Torokhov
2019-10-11 23:07 ` [PATCH v5 13/14] platform/x86: intel_cht_int33fe: use inline " Dmitry Torokhov
2019-10-16 8:01 ` Andy Shevchenko
2019-10-11 23:07 ` [PATCH v5 14/14] software node: remove separate handling of references Dmitry Torokhov
2019-10-14 7:38 ` [PATCH v5 00/14] software node: add support for reference properties Andy Shevchenko
2019-10-14 23:57 ` Dmitry Torokhov
2019-10-16 8:02 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015120350.GF32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).