From: Shawn Guo <shawnguo@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: jacek.anaszewski@gmail.com, pavel@ucw.cz,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH v13 10/18] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node
Date: Mon, 28 Oct 2019 10:55:26 +0800 [thread overview]
Message-ID: <20191028025524.GF16985@dragon> (raw)
In-Reply-To: <20191016155954.29044-11-dmurphy@ti.com>
On Wed, Oct 16, 2019 at 10:59:46AM -0500, Dan Murphy wrote:
> Add the reg property to each channel node. This update is
> to accomodate the multicolor framework. In addition to the
> accomodation this allows the LEDs to be placed on any channel
> and allow designs to skip channels as opposed to requiring
> sequential order.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> CC: Shawn Guo <shawnguo@kernel.org>
> CC: Sascha Hauer <s.hauer@pengutronix.de>
> CC: Pengutronix Kernel Team <kernel@pengutronix.de>
> CC: Fabio Estevam <festevam@gmail.com>
> CC: NXP Linux Team <linux-imx@nxp.com>
> ---
> arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> index e8d800fec637..efc466ed1fea 100644
> --- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> @@ -257,29 +257,35 @@
> reg = <0x30>;
> clock-mode = /bits/ 8 <1>;
> status = "disabled";
> + #address-cells = <1>;
> + #size-cells = <0>;
>
> - chan0 {
> + chan@0 {
Patch #18 updates bindings example to use led as node name. Maybe we
should do the same here?
Shawn
> chan-name = "R";
> led-cur = /bits/ 8 <0x20>;
> max-cur = /bits/ 8 <0x60>;
> + reg = <0>;
> };
>
> - chan1 {
> + chan@1 {
> chan-name = "G";
> led-cur = /bits/ 8 <0x20>;
> max-cur = /bits/ 8 <0x60>;
> + reg = <1>;
> };
>
> - chan2 {
> + chan@2 {
> chan-name = "B";
> led-cur = /bits/ 8 <0x20>;
> max-cur = /bits/ 8 <0x60>;
> + reg = <2>;
> };
>
> - chan3 {
> + chan@3 {
> chan-name = "W";
> led-cur = /bits/ 8 <0x0>;
> max-cur = /bits/ 8 <0x0>;
> + reg = <3>;
> };
> };
>
> --
> 2.22.0.214.g8dca754b1e
>
next prev parent reply other threads:[~2019-10-28 2:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 15:59 [PATCH v13 00/18] Multicolor Framework v13 Dan Murphy
2019-10-16 15:59 ` [PATCH v13 01/18] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2019-10-16 15:59 ` [PATCH v13 02/18] dt-bindings: leds: Add multicolor ID to the color ID list Dan Murphy
2019-10-16 15:59 ` [PATCH v13 03/18] " Dan Murphy
2019-10-16 15:59 ` [PATCH v13 04/18] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2019-10-19 18:33 ` Jacek Anaszewski
2019-10-16 15:59 ` [PATCH v13 05/18] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2019-10-16 15:59 ` [PATCH v13 06/18] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2019-10-16 15:59 ` [PATCH v13 07/18] dt: bindings: lp55xx: Be consistent in the document with LED acronym Dan Murphy
2019-10-16 15:59 ` [PATCH v13 08/18] dt: bindings: lp55xx: Update binding for Multicolor Framework Dan Murphy
2019-10-16 15:59 ` [PATCH v13 09/18] ARM: dts: n900: Add reg property to the LP5523 channel node Dan Murphy
2019-10-17 16:10 ` Tony Lindgren
2019-10-16 15:59 ` [PATCH v13 10/18] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 " Dan Murphy
2019-10-28 2:55 ` Shawn Guo [this message]
2019-10-16 15:59 ` [PATCH v13 11/18] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes Dan Murphy
2019-10-16 15:59 ` [PATCH v13 12/18] leds: lp55xx: Convert LED class registration to devm_* Dan Murphy
2019-10-16 15:59 ` [PATCH v13 13/18] leds: lp55xx: Add multicolor framework support to lp55xx Dan Murphy
2019-10-16 20:44 ` Jacek Anaszewski
2019-10-16 21:09 ` Jacek Anaszewski
2019-10-16 15:59 ` [PATCH v13 14/18] leds: lp5523: Update the lp5523 code to add multicolor brightness function Dan Murphy
2019-10-16 15:59 ` [PATCH v13 15/18] leds: lp5521: Add multicolor framework multicolor brightness support Dan Murphy
2019-10-16 15:59 ` [PATCH v13 16/18] leds: lp55xx: Fix checkpatch file permissions issues Dan Murphy
2019-10-16 15:59 ` [PATCH v13 17/18] leds: lp5523: Fix checkpatch issues in the code Dan Murphy
2019-10-16 15:59 ` [PATCH v13 18/18] dt: bindings: Update lp55xx binding to recommended LED naming Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028025524.GF16985@dragon \
--to=shawnguo@kernel.org \
--cc=dmurphy@ti.com \
--cc=festevam@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).