From: Jacopo Mondi <jacopo@jmondi.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
Rich Felker <dalias@libc.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Jingoo Han <jingoohan1@gmail.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Linux-sh list <linux-sh@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v7 0/9] backlight: gpio: simplify the driver
Date: Fri, 1 Nov 2019 16:41:33 +0100 [thread overview]
Message-ID: <20191101154133.qqjj3uriwrl2j5r5@uno.localdomain> (raw)
In-Reply-To: <20191101085803.GD5700@dell>
[-- Attachment #1: Type: text/plain, Size: 4761 bytes --]
Hello,
as promised...
On Fri, Nov 01, 2019 at 08:58:03AM +0000, Lee Jones wrote:
> On Thu, 24 Oct 2019, Jacopo Mondi wrote:
>
> > Hello,
> >
> > On Thu, Oct 24, 2019 at 07:47:26AM +0100, Lee Jones wrote:
> > > On Wed, 23 Oct 2019, Daniel Thompson wrote:
> > >
> > > > On Tue, Oct 22, 2019 at 11:29:54AM +0200, Bartosz Golaszewski wrote:
> > > > > wt., 22 paź 2019 o 10:36 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a):
> > > > > >
> > > > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > > > >
> > > > > > While working on my other series related to gpio-backlight[1] I noticed
> > > > > > that we could simplify the driver if we made the only user of platform
> > > > > > data use GPIO lookups and device properties. This series tries to do
> > > > > > that.
> > > > > >
> > > > > > First two patches contain minor fixes. Third patch makes the driver
> > > > > > explicitly drive the GPIO line. Fourth patch adds all necessary data
> > > > > > structures to ecovec24. Patch 5/9 unifies much of the code for both
> > > > > > pdata and non-pdata cases. Patches 6-7/9 remove unused platform data
> > > > > > fields. Last two patches contain additional improvements for the GPIO
> > > > > > backlight driver while we're already modifying it.
> > > > > >
> > > > > > I don't have access to this HW but hopefully this works. Only compile
> > > > > > tested.
> > > > > >
> > > > > > [1] https://lkml.org/lkml/2019/6/25/900
> > > > > >
> > > > > > v1 -> v2:
> > > > > > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy
> > > > > > - added additional two patches with minor improvements
> > > > > >
> > > > > > v2 -> v3:
> > > > > > - in patch 7/7: used initializers to set values for pdata and dev local vars
> > > > > >
> > > > > > v3 -> v4:
> > > > > > - rebased on top of v5.4-rc1
> > > > > > - removed changes that are no longer relevant after commit ec665b756e6f
> > > > > > ("backlight: gpio-backlight: Correct initial power state handling")
> > > > > > - added patch 7/7
> > > > > >
> > > > > > v4 -> v5:
> > > > > > - in patch 7/7: added a comment replacing the name of the function being
> > > > > > pulled into probe()
> > > > > >
> > > > > > v5 -> v6:
> > > > > > - added a patch making the driver explicitly set the direction of the GPIO
> > > > > > to output
> > > > > > - added a patch removing a redundant newline
> > > > > >
> > > > > > v6 -> v7:
> > > > > > - renamed the function calculating the new GPIO value for status update
> > > > > > - collected more tags
> > > > > >
> > > > > > Bartosz Golaszewski (9):
> > > > > > backlight: gpio: remove unneeded include
> > > > > > backlight: gpio: remove stray newline
> > > > > > backlight: gpio: explicitly set the direction of the GPIO
> > > > > > sh: ecovec24: add additional properties to the backlight device
> > > > > > backlight: gpio: simplify the platform data handling
> > > > > > sh: ecovec24: don't set unused fields in platform data
> > > > > > backlight: gpio: remove unused fields from platform data
> > > > > > backlight: gpio: use a helper variable for &pdev->dev
> > > > > > backlight: gpio: pull gpio_backlight_initial_power_state() into probe
> > > > > >
> > > > > > arch/sh/boards/mach-ecovec24/setup.c | 33 +++--
> > > > > > drivers/video/backlight/gpio_backlight.c | 128 +++++++------------
> > > > > > include/linux/platform_data/gpio_backlight.h | 3 -
> > > > > > 3 files changed, 69 insertions(+), 95 deletions(-)
> > > > > >
> > > > > >
> > > > >
> > > > > Lee, Daniel, Jingoo,
> > > > >
> > > > > Jacopo is travelling until November 1st and won't be able to test this
> > > > > again before this date. Do you think you can pick it up and in case
> > > > > anything's broken on SH, we can fix it after v5.5-rc1, so that it
> > > > > doesn't miss another merge window?
> > >
> > > November 1st (-rc6) will be fine.
> > >
> > > I'd rather apply it late-tested than early-non-tested.
> > >
> > > Hopefully Jacopo can prioritise testing this on Thursday or Friday,
> > > since Monday will be -rc7 which is really cutting it fine.
> >
> > I'll do my best, I'll get home Friday late afternoon :)
>
> Welcome home!
>
> Just a little reminder in your inbox. TIA. :)
For the ecovec part:
Tested-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Thanks
j
>
> --
> Lee Jones [李琼斯]
> Linaro Services Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-11-01 15:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 8:36 [PATCH v7 0/9] backlight: gpio: simplify the driver Bartosz Golaszewski
2019-10-22 8:36 ` [PATCH v7 1/9] backlight: gpio: remove unneeded include Bartosz Golaszewski
2019-10-22 8:36 ` [PATCH v7 2/9] backlight: gpio: remove stray newline Bartosz Golaszewski
2019-10-22 8:36 ` [PATCH v7 3/9] backlight: gpio: explicitly set the direction of the GPIO Bartosz Golaszewski
2019-10-22 10:14 ` Daniel Thompson
2019-10-22 8:36 ` [PATCH v7 4/9] sh: ecovec24: add additional properties to the backlight device Bartosz Golaszewski
2019-10-22 8:36 ` [PATCH v7 5/9] backlight: gpio: simplify the platform data handling Bartosz Golaszewski
2019-10-22 8:36 ` [PATCH v7 6/9] sh: ecovec24: don't set unused fields in platform data Bartosz Golaszewski
2019-10-22 8:36 ` [PATCH v7 7/9] backlight: gpio: remove unused fields from " Bartosz Golaszewski
2019-10-22 8:36 ` [PATCH v7 8/9] backlight: gpio: use a helper variable for &pdev->dev Bartosz Golaszewski
2019-10-22 8:36 ` [PATCH v7 9/9] backlight: gpio: pull gpio_backlight_initial_power_state() into probe Bartosz Golaszewski
2019-10-22 9:29 ` [PATCH v7 0/9] backlight: gpio: simplify the driver Bartosz Golaszewski
2019-10-23 15:59 ` Daniel Thompson
2019-10-24 6:47 ` Lee Jones
2019-10-24 7:17 ` Jacopo Mondi
2019-10-24 12:10 ` Lee Jones
2019-11-01 8:58 ` Lee Jones
2019-11-01 15:41 ` Jacopo Mondi [this message]
2019-11-04 9:22 ` Bartosz Golaszewski
2019-11-08 9:24 ` Bartosz Golaszewski
2019-11-11 7:44 ` Lee Jones
2019-11-11 11:41 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101154133.qqjj3uriwrl2j5r5@uno.localdomain \
--to=jacopo@jmondi.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=b.zolnierkie@samsung.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=dalias@libc.org \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).