From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Marta Rybczynska <mrybczyn@kalray.eu>,
Charles Machalow <csm10495@gmail.com>,
linux-nvme <linux-nvme@lists.infradead.org>, axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvme: change nvme_passthru_cmd64's result field.
Date: Tue, 5 Nov 2019 00:32:49 +0900 [thread overview]
Message-ID: <20191104153249.GC26808@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <20191104152916.GB17050@lst.de>
On Mon, Nov 04, 2019 at 04:29:16PM +0100, Christoph Hellwig wrote:
>
> Except on 32-bit x86, which does not have the padding. Which is why
> the current layout is so bad, as it breaks 32-it x86 compat.
Yeah, fair enough.
Charles, let's just define an explicit padding rsvd field and use the
appropriate struct for the different ioctl's.
next prev parent reply other threads:[~2019-11-04 15:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 5:03 [PATCH] nvme: change nvme_passthru_cmd64's result field Charles Machalow
2019-10-31 13:39 ` Christoph Hellwig
[not found] ` <CANSCoS8rN6g7u6iG4SRTcXjdj68cbimvX1n1Ex+FBAkhAAivJA@mail.gmail.com>
2019-10-31 13:59 ` Christoph Hellwig
2019-10-31 15:39 ` Charles Machalow
2019-10-31 13:59 ` Charles Machalow
2019-11-04 14:34 ` Marta Rybczynska
2019-11-04 14:51 ` Charles Machalow
2019-11-04 14:56 ` Marta Rybczynska
2019-11-04 15:01 ` Keith Busch
2019-11-04 15:29 ` Christoph Hellwig
2019-11-04 15:32 ` Keith Busch [this message]
2019-11-04 15:01 ` Charles Machalow
2019-11-04 15:16 ` Marta Rybczynska
2019-11-04 15:20 ` Charles Machalow
2019-11-04 15:30 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104153249.GC26808@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=csm10495@gmail.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mrybczyn@kalray.eu \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).