From: Greg KH <gregkh@linuxfoundation.org>
To: Jiri Slaby <jslaby@suse.com>
Cc: Xiaoming Ni <nixiaoming@huawei.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty:n_gsm.c: destroy port by tty_port_destroy()
Date: Mon, 4 Nov 2019 17:49:19 +0100 [thread overview]
Message-ID: <20191104164919.GA2282079@kroah.com> (raw)
In-Reply-To: <1fd7d2eb-7497-254b-b40f-84bc4114f8a3@suse.com>
On Thu, Oct 31, 2019 at 11:11:24AM +0100, Jiri Slaby wrote:
> On 24. 09. 19, 11:25, Xiaoming Ni wrote:
> > According to the comment of tty_port_destroy():
> > When a port was initialized using tty_port_init, one has to destroy
> > the port by tty_port_destroy();
>
> It continues with a part saying:
> Either indirectly by using tty_port refcounting
> (tty_port_put) or directly if refcounting is not used.
>
> > tty_port_init() is called in gsm_dlci_alloc()
> > so tty_port_destroy() needs to be called in gsm_dlci_free()
> >
> > Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>
> > ---
> > drivers/tty/n_gsm.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
> > index 36a3eb4..3f5bcc9 100644
> > --- a/drivers/tty/n_gsm.c
> > +++ b/drivers/tty/n_gsm.c
> > @@ -1681,6 +1681,7 @@ static void gsm_dlci_free(struct tty_port *port)
> >
> > del_timer_sync(&dlci->t1);
> > dlci->gsm->dlci[dlci->addr] = NULL;
> > + tty_port_destroy(&dlci->port);
>
> This is wrong. gsm_dlci_free is tty_port_operations->destruct, i.e.
> n_gsm uses tty_port refcounting and tty_port_destroy was called on this
> port in tty_port_destructor already.
>
> Greg, please revert.
Now reverted.
sorry about that.
greg k-h
prev parent reply other threads:[~2019-11-04 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 9:25 [PATCH] tty:n_gsm.c: destroy port by tty_port_destroy() Xiaoming Ni
2019-10-31 10:11 ` Jiri Slaby
2019-10-31 12:38 ` Xiaoming Ni
2019-11-04 16:49 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104164919.GA2282079@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nixiaoming@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).