From: Rob Herring <robh@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
mazziesaccount@gmail.com,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Mark Rutland <mark.rutland@arm.com>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org
Subject: Re: [RFC PATCH v3 04/15] dt-bindings: leds: ROHM BD71282 PMIC LED driver
Date: Tue, 5 Nov 2019 14:59:34 -0600 [thread overview]
Message-ID: <20191105205934.GD629@bogus> (raw)
In-Reply-To: <37d85b2d-8fca-a998-95ae-61f0c049054d@ti.com>
On Tue, Nov 05, 2019 at 01:14:33PM -0600, Dan Murphy wrote:
> Matti
>
> On 11/1/19 6:32 AM, Matti Vaittinen wrote:
> > Document ROHM BD71828 PMIC LED driver device tree bindings.
> >
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > ---
> >
> > Changes from v2 - new patch
> >
> > .../bindings/leds/rohm,leds-bd71828.yaml | 46 +++++++++++++++++++
> > 1 file changed, 46 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/leds/rohm,leds-bd71828.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/leds/rohm,leds-bd71828.yaml b/Documentation/devicetree/bindings/leds/rohm,leds-bd71828.yaml
> > new file mode 100644
> > index 000000000000..d8aeac9911ef
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/leds/rohm,leds-bd71828.yaml
> > @@ -0,0 +1,46 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/leds/rohm,leds-bd71828.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ROHM BD71828 Power Management Integrated Circuit LED driver
> > +
> > +maintainers:
> > + - Jacek Anaszewski <jacek.anaszewski@gmail.com>
> > + - Pavel Machek <pavel@ucw.cz>
> > + - Dan Murphy <dmurphy@ti.com>
> > + - Rob Herring <robh+dt@kernel.org>
> > + - Mark Rutland <mark.rutland@arm.com>
> I believe you are the maintainer of this driver not the maintainers
Right, should have been clearer in my other response. Put
owner/maintainer of the device binding, not subsystem.
> > +
> > +description: |
> > + This module is part of the ROHM BD71828 MFD device. For more details
> > + see Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml.
> > +
> > + The LED controller is represented as a sub-node of the PMIC node on the device
> > + tree.
> > +
> > + The device has two LED outputs referred as GRNLED and AMBLED in data-sheet.
> > +
> > +properties:
> > + compatible:
> > + const: rohm,bd71828-led
> > +
> > +patternProperties:
> > + "^led-[1-2]$":
> > + type: object
> > + description:
> > + Properties for a single LED. Nodes must be named as led-1 and led-2.
>
> Why is this required? Can't we use the reg as the number and then we can
> use standard node labels
>
> like led@<reg value>. Then we can check in the code to make sure that the
> output is not out of bounds.
>
> > + properties:
> > + #$ref: "common.yaml#"
> > + function:
> > + description:
> > + Purpose of LED as defined in dt-bindings/leds/common.h
> > + $ref: "/schemas/types.yaml#/definitions/string"
> > + color:
> > + description:
> > + LED colour as defined in dt-bindings/leds/common.h
>
> s/colour/color
>
> But again I believe it is indicated above that the LEDs are either going to
> be green or amber. Unless they can be any color.
>
> Are there plans to make sure that the color is either green or amber in the
> code? I don't see a patch for the code in this series
>
> > + $ref: "/schemas/types.yaml#/definitions/uint32"
> > +
> > +required:
> > + - compatible
>
> Is there an example of the node and properties?
For MFDs, I prefer a complete example in the MFD binding doc. We need it
complete to validate the example.
Rob
next prev parent reply other threads:[~2019-11-05 20:59 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 11:28 [RFC PATCH v3 00/15] Support ROHM BD71828 PMIC Matti Vaittinen
2019-11-01 11:29 ` [RFC PATCH v3 01/15] mfd: bd71828: Support ROHM BD71828 PMIC - core Matti Vaittinen
2019-11-11 10:57 ` Lee Jones
2019-11-11 11:20 ` Vaittinen, Matti
2019-11-01 11:31 ` [RFC PATCH v3 02/15] dt-bindings: mfd: Document ROHM BD71828 bindings Matti Vaittinen
2019-11-05 20:43 ` Rob Herring
2019-11-06 12:55 ` SPAM (R/EU IT) // " Vaittinen, Matti
2019-11-01 11:31 ` [RFC PATCH v3 03/15] dt-bindings: regulator: Document ROHM BD71282 regulator bindings Matti Vaittinen
2019-11-05 20:52 ` Rob Herring
2019-11-07 6:50 ` SPAM (R/EU IT) // " Vaittinen, Matti
2019-11-01 11:32 ` [RFC PATCH v3 04/15] dt-bindings: leds: ROHM BD71282 PMIC LED driver Matti Vaittinen
2019-11-05 19:14 ` Dan Murphy
2019-11-05 20:59 ` Rob Herring [this message]
2019-11-06 13:05 ` Vaittinen, Matti
2019-11-05 20:57 ` Rob Herring
2019-11-01 11:33 ` [RFC PATCH v3 05/15] mfd: input: bd71828: Add power-key support Matti Vaittinen
2019-11-11 10:59 ` Lee Jones
2019-11-11 11:07 ` Vaittinen, Matti
2019-11-01 11:38 ` [RFC PATCH v3 06/15] clk: bd718x7: Support ROHM BD71828 clk block Matti Vaittinen
2019-11-01 11:39 ` [RFC PATCH v3 07/15] clk: bd718x7: simplify header dependencies Matti Vaittinen
2019-11-01 11:41 ` [RFC PATCH v3 08/15] regulator: bd718x7: Split driver to common and bd718x7 specific parts Matti Vaittinen
2019-11-01 11:42 ` [RFC PATCH v3 09/15] regulator: bd71828: Basic support for ROHM bd71828 PMIC regulators Matti Vaittinen
2019-11-01 11:43 ` [RFC PATCH v3 10/15] regulator: bd71828: Add GPIO based run-level control for regulators Matti Vaittinen
2019-11-03 22:27 ` Linus Walleij
2019-11-04 7:05 ` Vaittinen, Matti
2019-11-05 13:24 ` Linus Walleij
2019-11-05 14:07 ` Vaittinen, Matti
2019-11-01 11:44 ` [RFC PATCH v3 11/15] regulator: bd71828: enhanced run-level support Matti Vaittinen
2019-11-01 11:45 ` [RFC PATCH v3 12/15] regulator: bd71828: Support in-kernel APIs to change run-level Matti Vaittinen
2019-11-01 11:49 ` [RFC PATCH v3 13/15] rtc: bd70528 add BD71828 support Matti Vaittinen
2019-11-01 11:49 ` [RFC PATCH v3 14/15] gpio: Add definition for GPIO direction Matti Vaittinen
2019-11-03 22:30 ` Linus Walleij
2019-11-04 6:57 ` Vaittinen, Matti
2019-11-04 15:48 ` Vaittinen, Matti
2019-11-05 15:05 ` Linus Walleij
2019-11-06 6:51 ` Vaittinen, Matti
2019-11-01 11:51 ` [RFC PATCH v3 15/15] gpio: bd71828: Initial support for ROHM BD71828 PMIC GPIOs Matti Vaittinen
2019-11-01 11:53 ` [RFC PATCH v3 00/15] Support ROHM BD71828 PMIC Vaittinen, Matti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105205934.GD629@bogus \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=mturquette@baylibre.com \
--cc=pavel@ucw.cz \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).