From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 998D2FC6196 for ; Fri, 8 Nov 2019 22:18:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B91F20865 for ; Fri, 8 Nov 2019 22:18:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730799AbfKHWSP (ORCPT ); Fri, 8 Nov 2019 17:18:15 -0500 Received: from mga03.intel.com ([134.134.136.65]:2880 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726095AbfKHWSP (ORCPT ); Fri, 8 Nov 2019 17:18:15 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Nov 2019 14:18:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,283,1569308400"; d="scan'208";a="377883818" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by orsmga005.jf.intel.com with ESMTP; 08 Nov 2019 14:18:13 -0800 Date: Fri, 8 Nov 2019 14:22:42 -0800 From: Jacob Pan To: Auger Eric Cc: iommu@lists.linux-foundation.org, LKML , Joerg Roedel , David Woodhouse , Alex Williamson , Jean-Philippe Brucker , Yi Liu , "Tian, Kevin" , Raj Ashok , Christoph Hellwig , Lu Baolu , Jonathan Cameron , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v7 02/11] iommu/vt-d: Enlightened PASID allocation Message-ID: <20191108142242.5eb2b0bc@jacob-builder> In-Reply-To: <79e3f867-8892-2314-e6f6-eac7d9b4f15b@redhat.com> References: <1571946904-86776-1-git-send-email-jacob.jun.pan@linux.intel.com> <1571946904-86776-3-git-send-email-jacob.jun.pan@linux.intel.com> <79e3f867-8892-2314-e6f6-eac7d9b4f15b@redhat.com> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Nov 2019 11:33:22 +0100 Auger Eric wrote: > Hi Jacob, > On 10/24/19 9:54 PM, Jacob Pan wrote: > > From: Lu Baolu > > > > Enabling IOMMU in a guest requires communication with the host > > driver for certain aspects. Use of PASID ID to enable Shared Virtual > > Addressing (SVA) requires managing PASID's in the host. VT-d 3.0 > > spec provides a Virtual Command Register (VCMD) to facilitate this. > > Writes to this register in the guest are trapped by QEMU which > > proxies the call to the host driver. > > > > This virtual command interface consists of a capability register, > > a virtual command register, and a virtual response register. Refer > > to section 10.4.42, 10.4.43, 10.4.44 for more information. > > > > This patch adds the enlightened PASID allocation/free interfaces > > via the virtual command interface. > > > > Cc: Ashok Raj > > Cc: Jacob Pan > > Cc: Kevin Tian > > Signed-off-by: Liu Yi L > > Signed-off-by: Lu Baolu > > Signed-off-by: Jacob Pan > > Reviewed-by: Eric Auger > > --- > > drivers/iommu/intel-pasid.c | 56 > > +++++++++++++++++++++++++++++++++++++++++++++ > > drivers/iommu/intel-pasid.h | 13 ++++++++++- > > include/linux/intel-iommu.h | 2 ++ 3 files changed, 70 > > insertions(+), 1 deletion(-) > > > > diff --git a/drivers/iommu/intel-pasid.c > > b/drivers/iommu/intel-pasid.c index 040a445be300..d81e857d2b25 > > 100644 --- a/drivers/iommu/intel-pasid.c > > +++ b/drivers/iommu/intel-pasid.c > > @@ -63,6 +63,62 @@ void *intel_pasid_lookup_id(int pasid) > > return p; > > } > > > > +int vcmd_alloc_pasid(struct intel_iommu *iommu, unsigned int > > *pasid) +{ > > + unsigned long flags; > > + u8 status_code; > > + int ret = 0; > > + u64 res; > > + > > + raw_spin_lock_irqsave(&iommu->register_lock, flags); > > + dmar_writeq(iommu->reg + DMAR_VCMD_REG, VCMD_CMD_ALLOC); > > + IOMMU_WAIT_OP(iommu, DMAR_VCRSP_REG, dmar_readq, > > + !(res & VCMD_VRSP_IP), res); > > + raw_spin_unlock_irqrestore(&iommu->register_lock, flags); > > + > > + status_code = VCMD_VRSP_SC(res); > > + switch (status_code) { > > + case VCMD_VRSP_SC_SUCCESS: > > + *pasid = VCMD_VRSP_RESULT(res); > > + break; > > + case VCMD_VRSP_SC_NO_PASID_AVAIL: > > + pr_info("IOMMU: %s: No PASID available\n", > > iommu->name); > > + ret = -ENOMEM; > > + break; > > + default: > > + ret = -ENODEV; > > + pr_warn("IOMMU: %s: Unexpected error code %d\n", > > + iommu->name, status_code); > > + } > > + > > + return ret; > > +} > > + > > +void vcmd_free_pasid(struct intel_iommu *iommu, unsigned int pasid) > > +{ > > + unsigned long flags; > > + u8 status_code; > > + u64 res; > > + > > + raw_spin_lock_irqsave(&iommu->register_lock, flags); > > + dmar_writeq(iommu->reg + DMAR_VCMD_REG, (pasid << 8) | > > VCMD_CMD_FREE); > > + IOMMU_WAIT_OP(iommu, DMAR_VCRSP_REG, dmar_readq, > > + !(res & VCMD_VRSP_IP), res); > > + raw_spin_unlock_irqrestore(&iommu->register_lock, flags); > > + > > + status_code = VCMD_VRSP_SC(res); > > + switch (status_code) { > > + case VCMD_VRSP_SC_SUCCESS: > > + break; > > + case VCMD_VRSP_SC_INVALID_PASID: > > + pr_info("IOMMU: %s: Invalid PASID\n", iommu->name); > > + break; > > + default: > > + pr_warn("IOMMU: %s: Unexpected error code %d\n", > > + iommu->name, status_code); > > + } > > +} > > + > > /* > > * Per device pasid table management: > > */ > > diff --git a/drivers/iommu/intel-pasid.h > > b/drivers/iommu/intel-pasid.h index fc8cd8f17de1..e413e884e685 > > 100644 --- a/drivers/iommu/intel-pasid.h > > +++ b/drivers/iommu/intel-pasid.h > > @@ -23,6 +23,16 @@ > > #define is_pasid_enabled(entry) (((entry)->lo >> 3) > > & 0x1) #define get_pasid_dir_size(entry) (1 << > > ((((entry)->lo >> 9) & 0x7) + 7)) > > +/* Virtual command interface for enlightened pasid management. */ > > +#define VCMD_CMD_ALLOC 0x1 > > +#define VCMD_CMD_FREE 0x2 > > +#define VCMD_VRSP_IP 0x1 > > +#define VCMD_VRSP_SC(e) (((e) >> 1) & 0x3) > > +#define VCMD_VRSP_SC_SUCCESS 0 > > +#define VCMD_VRSP_SC_NO_PASID_AVAIL 1 > > +#define VCMD_VRSP_SC_INVALID_PASID 1 > > +#define VCMD_VRSP_RESULT(e) (((e) >> 8) & 0xfffff) > nit: pasid is 20b but result field is 56b large > Just in case a new command were to be added later on. Good point, will rename to VCMD_VRSP_RESULT_PASID andd new macros for future new commands with different results. > > + > > /* > > * Domain ID reserved for pasid entries programmed for first-level > > * only and pass-through transfer modes. > > @@ -95,5 +105,6 @@ int intel_pasid_setup_pass_through(struct > > intel_iommu *iommu, struct device *dev, int pasid); > > void intel_pasid_tear_down_entry(struct intel_iommu *iommu, > > struct device *dev, int pasid); > > - > > +int vcmd_alloc_pasid(struct intel_iommu *iommu, unsigned int > > *pasid); +void vcmd_free_pasid(struct intel_iommu *iommu, unsigned > > int pasid); #endif /* __INTEL_PASID_H */ > > diff --git a/include/linux/intel-iommu.h > > b/include/linux/intel-iommu.h index 2e1bed9b7eef..1d4b8dcdc5d8 > > 100644 --- a/include/linux/intel-iommu.h > > +++ b/include/linux/intel-iommu.h > > @@ -161,6 +161,7 @@ > > #define ecap_smpwc(e) (((e) >> 48) & 0x1) > > #define ecap_flts(e) (((e) >> 47) & 0x1) > > #define ecap_slts(e) (((e) >> 46) & 0x1) > > +#define ecap_vcs(e) (((e) >> 44) & 0x1) > nit: this addition is not related to this patch > may be moved to [3] as vccap_pasid Sounds good. Thanks > > #define ecap_smts(e) (((e) >> 43) & 0x1) > > #define ecap_dit(e) ((e >> 41) & 0x1) > > #define ecap_pasid(e) ((e >> 40) & 0x1) > > @@ -282,6 +283,7 @@ > > > > /* PRS_REG */ > > #define DMA_PRS_PPR ((u32)1) > > +#define DMA_VCS_PAS ((u64)1) > > > > #define IOMMU_WAIT_OP(iommu, offset, op, cond, > > sts) \ do > > { > > \ > Otherwise looks good to me > > Thanks > > Eric > [Jacob Pan]