From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: jolsa@kernel.org, acme@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v5 13/13] perf stat: Use affinity for enabling/disabling events
Date: Mon, 11 Nov 2019 15:04:15 +0100 [thread overview]
Message-ID: <20191111140415.GA26980@krava> (raw)
In-Reply-To: <20191107181646.506734-14-andi@firstfloor.org>
On Thu, Nov 07, 2019 at 10:16:46AM -0800, Andi Kleen wrote:
SNIP
> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
> index 33080f79b977..571bb102b432 100644
> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -378,11 +378,28 @@ bool evsel__cpu_iter_skip(struct evsel *ev, int cpu)
> void evlist__disable(struct evlist *evlist)
> {
> struct evsel *pos;
> + struct affinity affinity;
> + int cpu, i;
should we have the fallback to current code in here (and below) as well?
also for reading/openning?
jirka
> +
> + if (affinity__setup(&affinity) < 0)
> + return;
> +
> + evlist__for_each_cpu (evlist, i, cpu) {
> + affinity__set(&affinity, cpu);
>
> + evlist__for_each_entry(evlist, pos) {
> + if (evsel__cpu_iter_skip(pos, cpu))
> + continue;
> + if (pos->disabled || !perf_evsel__is_group_leader(pos) || !pos->core.fd)
> + continue;
> + evsel__disable_cpu(pos, pos->cpu_iter - 1);
> + }
> + }
> + affinity__cleanup(&affinity);
> evlist__for_each_entry(evlist, pos) {
> - if (pos->disabled || !perf_evsel__is_group_leader(pos) || !pos->core.fd)
> + if (!perf_evsel__is_group_leader(pos) || !pos->core.fd)
> continue;
> - evsel__disable(pos);
> + pos->disabled = true;
> }
>
> evlist->enabled = false;
> @@ -391,11 +408,28 @@ void evlist__disable(struct evlist *evlist)
> void evlist__enable(struct evlist *evlist)
> {
> struct evsel *pos;
> + struct affinity affinity;
> + int cpu, i;
>
> + if (affinity__setup(&affinity) < 0)
> + return;
> +
> + evlist__for_each_cpu (evlist, i, cpu) {
> + affinity__set(&affinity, cpu);
> +
> + evlist__for_each_entry(evlist, pos) {
> + if (evsel__cpu_iter_skip(pos, cpu))
> + continue;
> + if (!perf_evsel__is_group_leader(pos) || !pos->core.fd)
> + continue;
> + evsel__enable_cpu(pos, pos->cpu_iter - 1);
> + }
> + }
> + affinity__cleanup(&affinity);
> evlist__for_each_entry(evlist, pos) {
> if (!perf_evsel__is_group_leader(pos) || !pos->core.fd)
> continue;
> - evsel__enable(pos);
> + pos->disabled = false;
> }
>
> evlist->enabled = true;
> --
> 2.23.0
>
next prev parent reply other threads:[~2019-11-11 14:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 18:16 Optimize perf stat for large number of events/cpus Andi Kleen
2019-11-07 18:16 ` [PATCH v5 01/13] perf pmu: Use file system cache to optimize sysfs access Andi Kleen
2019-11-07 18:16 ` [PATCH v5 02/13] perf affinity: Add infrastructure to save/restore affinity Andi Kleen
2019-11-07 18:16 ` [PATCH v5 03/13] perf cpumap: Maintain cpumaps ordered and without dups Andi Kleen
2019-11-07 18:16 ` [PATCH v5 04/13] perf evlist: Maintain evlist->all_cpus Andi Kleen
2019-11-11 13:31 ` Jiri Olsa
2019-11-07 18:16 ` [PATCH v5 05/13] perf evsel: Add iterator to iterate over events ordered by CPU Andi Kleen
2019-11-07 18:16 ` [PATCH v5 06/13] perf evsel: Add functions to close evsel on a CPU Andi Kleen
2019-11-07 18:16 ` [PATCH v5 07/13] perf stat: Use affinity for closing file descriptors Andi Kleen
2019-11-11 13:30 ` Jiri Olsa
2019-11-11 16:56 ` Andi Kleen
2019-11-07 18:16 ` [PATCH v5 08/13] perf stat: Factor out open error handling Andi Kleen
2019-11-07 18:16 ` [PATCH v5 09/13] perf evsel: Support opening on a specific CPU Andi Kleen
2019-11-11 13:30 ` Jiri Olsa
2019-11-12 0:41 ` Andi Kleen
2019-11-07 18:16 ` [PATCH v5 10/13] perf stat: Use affinity for opening events Andi Kleen
2019-11-11 13:30 ` Jiri Olsa
2019-11-11 13:30 ` Jiri Olsa
2019-11-11 13:31 ` Jiri Olsa
2019-11-11 17:02 ` Andi Kleen
2019-11-07 18:16 ` [PATCH v5 11/13] perf stat: Use affinity for reading Andi Kleen
2019-11-11 13:31 ` Jiri Olsa
2019-11-07 18:16 ` [PATCH v5 12/13] perf evsel: Add functions to enable/disable for a specific CPU Andi Kleen
2019-11-11 13:30 ` Jiri Olsa
2019-11-07 18:16 ` [PATCH v5 13/13] perf stat: Use affinity for enabling/disabling events Andi Kleen
2019-11-11 14:04 ` Jiri Olsa [this message]
2019-11-11 16:50 ` Andi Kleen
2019-11-11 20:06 ` Jiri Olsa
2019-11-11 23:31 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111140415.GA26980@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).