From: Christoph Hellwig <hch@infradead.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Elliot Berman <eberman@codeaurora.org>,
sre@kernel.org, tkjos@google.com, tsoni@codeaurora.org,
rananta@codeaurora.org, bjorn.andersson@linaro.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/2] reboot: Export reboot_mode
Date: Mon, 11 Nov 2019 08:17:43 -0800 [thread overview]
Message-ID: <20191111161743.GA24952@infradead.org> (raw)
In-Reply-To: <20191108193958.GA1273544@kroah.com>
On Fri, Nov 08, 2019 at 08:39:58PM +0100, Greg KH wrote:
> > diff --git a/kernel/reboot.c b/kernel/reboot.c
> > index c4d472b..6518370 100644
> > --- a/kernel/reboot.c
> > +++ b/kernel/reboot.c
> > @@ -32,7 +32,9 @@ EXPORT_SYMBOL(cad_pid);
> > #define DEFAULT_REBOOT_MODE
> > #endif
> > enum reboot_mode reboot_mode DEFAULT_REBOOT_MODE;
> > +EXPORT_SYMBOL(reboot_mode);
> > enum reboot_mode panic_reboot_mode = REBOOT_UNDEFINED;
> > +EXPORT_SYMBOL(panic_reboot_mode);
>
> EXPORT_SYMBOL_GPL() perhaps?
Absolutely. But then again drivers/power/reset/reboot-mode.c, which
he wants to make modular in patch 2 is just a trivial abstraction
that avoids drivers directly poking into these values. I really don't
see a point to make that modular to start with.
next prev parent reply other threads:[~2019-11-11 16:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 19:32 [PATCH 0/2] Support reboot power-off driver as module Elliot Berman
2019-11-08 19:32 ` [PATCH 1/2] reboot: Export reboot_mode Elliot Berman
2019-11-08 19:39 ` Greg KH
2019-11-11 16:17 ` Christoph Hellwig [this message]
2019-11-08 19:32 ` [PATCH 2/2] power: reset: Enable tristate on restart power-off driver Elliot Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111161743.GA24952@infradead.org \
--to=hch@infradead.org \
--cc=bjorn.andersson@linaro.org \
--cc=eberman@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rananta@codeaurora.org \
--cc=sre@kernel.org \
--cc=tkjos@google.com \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).