From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1084C432C0 for ; Tue, 19 Nov 2019 05:31:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8AD4B21939 for ; Tue, 19 Nov 2019 05:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574141518; bh=brsGMJbB8Y/X6b87XrfPuGi9CYA42fx94LcAjJEr0TY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=wEXXplPJuu1nJI6it7D4+Q53AblSs4E8bNrVXfzI6/YgbyVDbGdJQYxcOiSzqpaL7 iW6aQty/n/QMQpAiiowDekVhSSrk2FxwiEUY4MNsiHqrABTRJurJSpQtWHfqfyQWPZ 02RbGS3l8ylzgA0VcQ32uf7PY4yFEDfAGdHxAMcg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729329AbfKSFb5 (ORCPT ); Tue, 19 Nov 2019 00:31:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:51652 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729315AbfKSFbx (ORCPT ); Tue, 19 Nov 2019 00:31:53 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 69A8A222A2; Tue, 19 Nov 2019 05:31:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574141512; bh=brsGMJbB8Y/X6b87XrfPuGi9CYA42fx94LcAjJEr0TY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xMw79pKO5REx/sZtaLVltzPIbl+jKzugfAJOmfT5EQf7Tc7ouoHAytBjvxlGusloh SpU7oo3MEtP738cYlcuqmU3NHsAEGT8CgLgNRaMYTg8RoLot9ASPmBvoTy1zdzL/qI 7W2YzSVHw/5MQdwvZj7FYPQIHT1c+/Cmp7eMPqc4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Philipp Klocke , Nick Desaulniers , "Peter Zijlstra (Intel)" , Linus Torvalds , Thomas Gleixner , Ingo Molnar , Sasha Levin Subject: [PATCH 4.19 146/422] sched/debug: Explicitly cast sched_feat() to bool Date: Tue, 19 Nov 2019 06:15:43 +0100 Message-Id: <20191119051408.155153867@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191119051400.261610025@linuxfoundation.org> References: <20191119051400.261610025@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Zijlstra [ Upstream commit 7e6f4c5d600c1c8e2a1d900e65cab319d9b6782e ] LLVM has a warning that tags expressions like: if (foo && non-bool-const) This pattern triggers for CONFIG_SCHED_DEBUG=n where sched_feat() ends up being whatever bit we select. Avoid the warning with an explicit cast to bool. Reported-by: Philipp Klocke Tested-by: Nick Desaulniers Signed-off-by: Peter Zijlstra (Intel) Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-kernel@vger.kernel.org Signed-off-by: Ingo Molnar Signed-off-by: Sasha Levin --- kernel/sched/sched.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 62058fd6dcf63..94bec97bd5e28 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -1389,7 +1389,7 @@ static const_debug __maybe_unused unsigned int sysctl_sched_features = 0; #undef SCHED_FEAT -#define sched_feat(x) (sysctl_sched_features & (1UL << __SCHED_FEAT_##x)) +#define sched_feat(x) !!(sysctl_sched_features & (1UL << __SCHED_FEAT_##x)) #endif /* SCHED_DEBUG && CONFIG_JUMP_LABEL */ -- 2.20.1